Skip to content

Ensure that initialLocation doesn't take precedence over deep-links #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johnpryan merged 3 commits into from
Jun 24, 2022
Merged

Ensure that initialLocation doesn't take precedence over deep-links #2275

johnpryan merged 3 commits into from
Jun 24, 2022

Conversation

@johnpryan
Copy link
Contributor

@johnpryan johnpryan commented Jun 23, 2022

Fixes flutter/flutter#106204

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@johnpryan johnpryan requested a review from loic-sharma June 23, 2022 18:57
@johnpryan johnpryan force-pushed the go-router-initial-location-bug branch from c91b9d0 to 9033a34 Compare June 24, 2022 17:38
@johnpryan johnpryan marked this pull request as ready for review June 24, 2022 17:39
@johnpryan johnpryan merged commit 002b45a into flutter:main Jun 24, 2022
@darshankawar darshankawar mentioned this pull request Jun 27, 2022
Closed
@johnpryan johnpryan deleted the go-router-initial-location-bug branch July 22, 2022 18:46
@BrilliantFish
Copy link

BrilliantFish commented Dec 19, 2022

the bug now have

@BrilliantFish
Copy link

BrilliantFish commented Dec 19, 2022

I can't understand "Ensure that initialLocation doesn't take precedence over deep-links"

@johnpryan
Copy link
Contributor Author

johnpryan commented Dec 19, 2022

The GoRouter's state was being set to initialLocation (for example /home) when a deep link was received by the platform (such as /my-deep-link)

@thierryoliveira
Copy link

thierryoliveira commented Jan 3, 2023

Is this bug happening again? When my app was not launched yet, and I call a deep-link, the router is going to initialLocation instead of the right route. It's working correctly when the app is already open/minimized.

@johnpryan
Copy link
Contributor Author

johnpryan commented Jan 3, 2023

Hi @thierryoliveira, would you mind filing a new issue?

@thierryoliveira
Copy link

thierryoliveira commented Jan 3, 2023

Hi @johnpryan. I will create a new one right now, thank you!

@gyuri-fluttech gyuri-fluttech mentioned this pull request Aug 11, 2023
Closed
2 tasks
@danagbemava-nc danagbemava-nc mentioned this pull request Aug 15, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

Assignees

No one assigned

Labels

p: go_router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[go_router] initialLocation overrides deep link since 4.0.0

4 participants

@johnpryan @BrilliantFish @thierryoliveira @loic-sharma