Revert "[go_router] Refactor RouterDelegate into functional pieces" #2183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
johnpryan
approved these changes
Jun 1, 2022
Collaborator
Author
|
Landing on red to fix the tree. |
This was referenced Jun 2, 2022
johnpryan
added a commit
that referenced
this pull request
Jun 15, 2022
* Revert "Revert "[go_router] Refactor RouterDelegate into functional pieces (#1653)" (#2183)" This reverts commit d39ffb1. * [go_router] Continue searching for top-level routes if the recursive search doesn't find any * Remove Route.push from demo app * update CHANGELOG.md * Avoid pushing the same page in example bump go_router_builder to 1.0.5 * Change published version to 4.0.0 * Specify dart SDK version >=2.17.0 to avoid analyzer errors Analyzing go_router... error - lib/src/go_route_information_provider.dart:24:41 - A value of type 'WidgetsBinding?' can't be returned from the function '_binding' because it has a return type of 'WidgetsBinding'. - return_of_invalid_type error - lib/src/go_router.dart:51:33 - The property 'platformDispatcher' can't be unconditionally accessed because the receiver can be 'null'. Try making the access conditional (using '?.') or adding a null check to the target ('!'). - unchecked_use_of_nullable_value 2 issues found. * Specify flutter >=3.0.0 in go_router * Apply suggestions from code review Co-authored-by: Loïc Sharma <[email protected]> * Apply suggestions from code review * Update packages/go_router/lib/src/go_route_information_parser.dart Co-authored-by: Loïc Sharma <[email protected]> * Update packages/go_router/lib/src/go_route_information_parser.dart Co-authored-by: Loïc Sharma <[email protected]> * Update packages/go_router/lib/src/go_route_information_parser.dart Co-authored-by: Loïc Sharma <[email protected]> * Update packages/go_router/lib/src/go_route_information_parser.dart Co-authored-by: Loïc Sharma <[email protected]> * Add '/' route to test * add go_route_information_provider_test.dart * Add test for redirect detection in GoRouteInformationParser * format Co-authored-by: Loïc Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1653
That PR fails postsubmit, so has closed the tree. See flutter/flutter#105150