Skip to content

[flutter_template_images] Minor cleanup #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 19, 2022
Merged

[flutter_template_images] Minor cleanup #1951

fluttergithubbot merged 1 commit into from
May 19, 2022

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented May 17, 2022

  • Removes the empty Dart file, which used to be required by pub.dev
    checks but no longer is.
  • Opts into NNBD so it's not flagged by pub.dev as not having been
    modernized, since it's a no-op to do so.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g
[flutter_template_images] Minor cleanup
f887042 
- Removes the empty Dart file, which used to be required by pub.dev
  checks but no longer is.
- Opts into NNBD so it's not flagged by pub.dev as not having been
  modernized, since it's a no-op to do so.
@stuartmorgan-g stuartmorgan-g requested a review from cbracken May 17, 2022 17:04
@fluttergithubbot fluttergithubbot merged commit d35211b into flutter:main May 19, 2022
This was referenced Jul 19, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes

Assignees

No one assigned

Labels

p: flutter_template_images waiting for tree to go green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stuartmorgan-g @cbracken @fluttergithubbot