Skip to content

[flutter_template_images] Add macOS app icon assets #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cbracken merged 1 commit into from
May 13, 2022
Merged

[flutter_template_images] Add macOS app icon assets #1930

cbracken merged 1 commit into from
May 13, 2022

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented May 13, 2022

Adds the the AppIcon assets in the macOS app template while
simultaneously updating them to meet Apple's icon guidelines as of macOS
Big Sur.

Ref: https://developer.apple.com/design/human-interface-guidelines/macos/icons-and-images/app-icon/

Issue: flutter/flutter#103371

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken cbracken requested review from Hixie and stuartmorgan-g May 13, 2022 20:07
@cbracken cbracken mentioned this pull request May 13, 2022
Merged
8 tasks
stuartmorgan-g
stuartmorgan-g approved these changes May 13, 2022
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with changelog style nits.

@cbracken
[flutter_template_images] Add macOS app icon assets
7f0f1d1 
Adds the the AppIcon assets in the macOS app template while
simultaneously updating them to meet Apple's icon guidelines as of macOS
Big Sur.

Ref: https://developer.apple.com/design/human-interface-guidelines/macos/icons-and-images/app-icon/

Issue: flutter/flutter#103371
@cbracken cbracken merged commit 20b8026 into flutter:main May 13, 2022
@cbracken cbracken deleted the add-mac-template-icons branch May 13, 2022 21:17
@cbracken cbracken mentioned this pull request May 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@Hixie Hixie Awaiting requested review from Hixie

Assignees

No one assigned

Labels

p: flutter_template_images

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbracken @stuartmorgan-g