[pointer_interceptor] Fix tests for flutter stable. #1731
Conversation
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with one question about how we skip.
Feel free to either land, or push this to my PR, as you prefer.
|
|
||
| if (!_newSemanticsAvailable()) { | ||
| print('Skipping test: Needs flutter > 2.10'); | ||
| return; |
There was a problem hiding this comment.
Could we do these via skip, or do you actually have to run main and pumpAndSettle to be able to do the check?
Not a big deal either way since it's temporary code.
There was a problem hiding this comment.
Yeah, I tried to find a way to do a proper skip, but I couldn't call skip, because the check that I do is at runtime (it needs to look at the html code of a rendered app). If we could do: skip: !isMaster, I'd prefer to do that :P (but yeah, this is very temporary)
ditman
added
waiting for tree to go green
and removed
waiting for tree to go green
labels
|
I'm going to cherry-pick this into @stuartmorgan's PR, so we can land both the fix+enabling of tests at the same time. |
|
Changes cherry-picked into #1726 |
3 participants
There have been a few changes in the hit order + semantics implementations on the Flutter Web engine. Some tests were added, but those can only run on
master, with the new semantics approach.This change skips those tests unless the "new semantics" are available (runs in
masterbut skips instable).Unblocks: #1726
No CHANGELOG change: this code should be reverted in a few days.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.