It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

test-exempt: code refactor with no semantic change

@werainkhatri Are you planning on updating this to fix the failing unit test?

I can't seem to understand what's causing the issue, can you help (or point to someone who can help) me with this? thanks!

Can you elaborate what specific help you are looking for here? You changed the hash and equality implementations of some objects, and now unit tests that rely on equality-testing those objects are failing; have you compared the new and old implementations on those specific cases to see what changed?

found the issue.

few of ResourceRecord's subclasses call super._equals in their _equals (like PtrResourceRecord) but others don't (like IPAddressResourceRecord or TxtResourceRecord). this seems unexpected, but maybe i'm wrong. with my migration, == compares all fields.

i see @dnfield working on this from git history, could you confirm?

This pull request is not suitable for automatic merging in its current state.

• This pull request has changes requested by @stuartmorgan. Please resolve those before re-applying the label.
• The status or check suite publishable has failed. Please fix the issues identified (or deflake) before re-applying this label.

This pull request is not suitable for automatic merging in its current state.

• This pull request has changes requested by @stuartmorgan. Please resolve those before re-applying the label.