Repository navigation
[ci] Update repo for 3.50 stable release - #13628
Conversation
|
Not sure which issue I should link, so leave the checkbox unchecked. |
There was a problem hiding this comment.
Code Review
This pull request updates the minimum supported SDK version to Flutter 3.44 and Dart 3.12 across numerous packages in the repository. It updates the CI configuration, repository tool configuration, package pubspec files, and changelogs to reflect this change. Additionally, it updates the Dart-to-Flutter SDK version mapping in the repository tooling script. There are no review comments to address, and I have no feedback to provide.
Applies `dart fix --code=prefer_initializing_formals`: with the language version now 3.12, the lint suggests private named parameters (new in Dart 3.12). Callers keep using the same argument names, and doc comments keep referring to the public names.
The generated files in platform_tests/shared_test_plugin_code/lib/src/generated/ can't be edited by hand, and they trigger the lint at language version 3.12+. Adds a local analysis_options.yaml for that package, allowed via ci_config.yaml.
Legacy analysis removes dev dependencies, so cupertino_ui's @DocImport of package:material_ui (a dev dependency) can't be resolved. N-1 is now 3.47.9, so cupertino_ui (which requires 3.47) is analyzed there for the first time.
The ignores work around flutter/flutter#196406 (legacy analysis can't resolve @docImports of dev dependencies).
|
|
|
Fixed conflict in |
These 22 packages only had example (or other unpublished sub-package) pubspec.yaml changes, so their own minimum SDK didn't change in this PR: 16 were already on Flutter 3.44 and 6 are on Flutter 3.47. Also removes the stale 3.41 NEXT entry in webview_flutter_android, which already released its 3.44 minimum in 4.12.1.
|
Noticed a changelog issue... Pushed ca3e06c to remove redundant CHANGELOG entries. |
Does the flutter/core-packages steps of [Updating-Packages-repo-for-a-stable-release.md](https://github.com/flutter/flutter/blob/main/docs/ecosystem/release/Updating-Packages-repo-for-a-stable-release.md#fluttercore-packages) for the 3.50 stable release. This repo wasn't updated for 3.47, so this also catches up on that release: - Updates the multi-version analysis and test matrix to the Dart versions of flutter/packages' stable, N-1, and N-2 Flutter versions: 3.14.0 (Flutter 3.50.0), 3.13.7 (Flutter 3.47.9), and 3.12.2 (Flutter 3.44.9), plus `main`. The matrix previously covered only N-1 and stable; this adds N-2 as the doc describes. - Updates the Windows unit tests and the release action to Dart 3.14.0. - Raises `min_dart` to 3.12.0 (the Dart version of Flutter 3.44.0, flutter/packages' new minimum), and updates all packages with `update-min-sdk --flutter-min=3.44.0`, run with the repo tooling from flutter/packages#13628, which has the updated version mapping. - Adds `NEXT` CHANGELOG entries with `update-release-info --version=next` (no version bumps, per repo policy). Additional adjustments needed for CI with the updated versions: - Applies `dart fix --code=prefer_initializing_formals` in `multicast_dns` and `mustache_template`, whose language version moved to Dart 3.12, adopting private named parameters (`this._foo`; call-site argument names are unchanged). - Also removes the outdated "we aren't actually testing N-1 or N-2" note from the `min_dart` comment in `.repo_tool_config.yaml`, since the matrix now covers N-1 and N-2. Companion to flutter/packages#13628. There's no tracking issue for this routine post-release update. ## Pre-Review Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [Flutter style guide] and ran [the auto-formatter]. - [x] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[vector_math]` - [ ] I [linked to at least one issue that this PR fixes] in the description above. - [x] I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1]. - [x] I updated/added any relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. <!-- Links --> [Contributor Guide]: https://github.com/flutter/core-packages/blob/main/CONTRIBUTING.md [AI contribution guidelines]: https://github.com/flutter/flutter/blob/master/CONTRIBUTING.ai.md#pull-requests [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [Flutter style guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md [the auto-formatter]: https://github.com/flutter/packages/blob/main/script/tool/README.md#format-code [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [the version and CHANGELOG instructions]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version-and-changelog-updates [semantic versioning]: https://dart.dev/tools/pub/versioning#semantic-versions [repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [test exemption]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
…r#196450) flutter/packages@653628e...14f9933 2026-11-12 [email protected] [material_ui] Fix SnackBarThemeData.lerp dropping showCloseIcon (flutter/packages#13449) 2026-11-11 [email protected] [ci] Update repo for 3.50 stable release (flutter/packages#13628) 2026-11-11 [email protected] [vector_graphics] Use font-family lists as a family with fallbacks (flutter/packages#13552) 2026-11-11 [email protected] Roll Flutter (stable) from c197ca5 to ab29120 (1647 revisions) (flutter/packages#13625) 2026-11-11 [email protected] [shared_prferences] Adopts mockito-kotlin in tests (flutter/packages#13624) 2026-11-11 [email protected] [cupertino_ui] Dim disabled CupertinoSlider controls (flutter/packages#13419) 2026-11-11 [email protected] [flutter_svg] Invalidate pending cache entries on clear and evict (flutter/packages#13595) 2026-11-11 [email protected] [cupertino_ui] Fix the tinted button's fill opacity (flutter/packages#13436) 2026-11-11 [email protected] [various] Support SVG filters (blur, offset, feMerge) (flutter/packages#11909) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Does the steps for Updating-Packages-repo-for-a-stable-release.md for the 3.50 stable release:
update-min-sdk --flutter-min=3.44.0.NEXTCHANGELOG entries withupdate-release-info --version=next(no version bumps, per repo policy), but only to packages whose own minimum SDK changed; packages where only an example or another unpublished pubspec changed get no entry. Packages that haven't released since the 3.47 update already had a 3.41 SDK-bump line inNEXT; that line is removed so each section has only one.webview_flutter_android'sNEXTsection had only a stale 3.41 line (it has required 3.44 since 4.12.1), so that section is removed.Additional adjustments needed for CI with the updated versions:
dart fix --code=prefer_initializing_formalsacross packages whose language version moved to Dart 3.12, adopting private named parameters (this._foo; call-site argument names and doc comment references are unchanged).prefer_initializing_formalsvia a localanalysis_options.yamlinpackages/pigeon/platform_tests/shared_test_plugin_code(opted in viapackages/pigeon/ci_config.yaml), since its Pigeon-generated files underlib/src/generated/trigger the lint at language version 3.12+ and cannot be edited by hand.// ignore/// ignore_for_file: uri_does_not_exist_in_doc_importcomments (tracked in [flutter_plugin_tools] Legacy analysis fails on @docImports of dev dependencies flutter#196406) to 20 files incupertino_ui: with N-1 now at 3.47.9,cupertino_uiruns in legacy analysis for the first time, whereremove-dev-dependenciesstripsmaterial_uiand leaves its@docImports unresolved. Usesoverride: no changelog neededsincecupertino_uionly receives comment changes.The stable pin (
.ci/flutter_stable.version) is updated separately by the autoroller in #13625.There's no tracking issue for this routine post-release update.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2