Repository navigation
[pointer_interceptor] Use dart.library.js_interop in example export - #13558
Conversation
Replace `if (dart.library.html)` with `if (dart.library.js_interop)` in `packages/pointer_interceptor/pointer_interceptor/example/lib/native_widget.dart` so the example app passes the upcoming `deprecated_web_configuration` analyzer warning (dart-lang/sdk#61875).
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If both you and the PR author believe this PR qualifies for a test exemption, escalate to the tech lead for the changed area to review and apply the |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the conditional export in native_widget.dart to use dart.library.js_interop instead of dart.library.html for exporting the web platform implementation. There are no review comments, and I have no feedback to provide.
kevmoo
added
override: no changelog needed
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/packages/13558, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/packages@670b30e...0478162 2026-11-05 [email protected] [material_ui] Document RefreshIndicator mouse behavior on desktop and web (flutter/packages#13286) 2026-11-05 [email protected] [material_ui] Make SearchAnchor.bar respect SearchBarThemeData padding (flutter/packages#13360) 2026-11-04 [email protected] [pointer_interceptor] Use dart.library.js_interop in example export (flutter/packages#13558) 2026-11-04 [email protected] [in_app_purchase_storekit] Use purchase(confirmIn:) for StoreKit 2 purchases (flutter/packages#13410) 2026-11-04 [email protected] [material_ui] Fix dismissal near minimum extent when shouldCloseOnMinExtent (flutter/packages#12545) 2026-11-04 [email protected] [material_ui] Add Material 3 Expressive `ElevatedButton` (flutter/packages#13084) 2026-11-04 [email protected] [go_router] Stop inactive StatefulShellRoute branches from vetoing pops (flutter/packages#12972) 2026-11-04 [email protected] Manual roll Flutter (stable) from abaf9c5 to c197ca5 (14 revisions) (flutter/packages#13542) 2026-11-04 [email protected] [in_app_purchase] Convert example app to Swift (flutter/packages#13556) 2026-11-04 [email protected] Sync release-go_router-18.1.3 to main (flutter/packages#13559) 2026-11-04 [email protected] Sync release-material_ui-1.10.0 to main (flutter/packages#13546) 2026-11-04 [email protected] [camera_android_camerax] Add magic number guideline to `TESTING.md` (flutter/packages#13081) 2026-11-04 [email protected] Sync release-cupertino_ui-1.1.6 to main (flutter/packages#13547) 2026-11-04 [email protected] [file_selector] Convert unit tests to Kotlin (flutter/packages#13102) 2026-11-04 [email protected] Roll Flutter from 9347202 to 3623d2d (25 revisions) (flutter/packages#13555) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Replace
if (dart.library.html)withif (dart.library.js_interop)inpackages/pointer_interceptor/pointer_interceptor/example/lib/native_widget.dart(native_widget_web.dartalready usespackage:web/web.dart).This resolves the last legacy
dart.library.htmlconditional directive influtter/packagesso the upcomingdeprecated_web_configurationanalyzer warning (dart-lang/sdk#61875) passesflutter-analyze.Related issue:
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2