Repository navigation
[tool] Regenerate MockGitDir for package:git 2.5.0 - #13544
Merged
auto-submit[bot] merged 2 commits intoNov 4, 2026
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the git dependency in script/tool/pubspec.yaml from ^2.0.0 to ^2.5.0. It also updates the generated mock file script/tool/test/common/package_command_test.mocks.dart to include new mocked methods and imports from the updated git package. No review comments were provided.
Contributor
Author
|
Re: missing tests, the regenerated mocks are part of the tests. :) |
elliette
approved these changes
Nov 3, 2026
Piinks
changed the title
package:git to ^2.5.0 and regenerate MockGitDirMockGitDir for package:git 2.5.0
auto-submit
Bot
removed
the
autosubmit
Piinks
added
the
emergency
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
jpohhhh
pushed a commit
to Telosnex/flutter
that referenced
this pull request
Nov 4, 2026
flutter/packages@1df8447...670b30e 2026-11-04 [email protected] [material_ui] Inherit `IconButtonThemeData.variant` from enclosing themes (flutter/packages#13263) 2026-11-04 [email protected] [tool] Regenerate `MockGitDir` for `package:git` 2.5.0 (flutter/packages#13544) 2026-11-03 [email protected] [material_ui] Fix discrete Slider selecting the neighboring tick near the track ends (flutter/packages#12927) 2026-11-03 [email protected] [material_ui] Migrate M3 Time Picker template to use new gen_defaults (flutter/packages#13164) 2026-11-03 [email protected] [camera_android_camerax] Update skills_lint to 0.5.3 (flutter/packages#13530) 2026-11-03 [email protected] Roll Flutter from fcfb4f2 to 9347202 (38 revisions) (flutter/packages#13540) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks done
Merged
11 tasks done
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package:git2.4.0and2.5.0were recently published to pub.dev and added an optional named parameter ({bool includeUntracked = true}) toGitDir.isWorkingTreeClean, along with several new methods onGitDir.Because
script/tooldoes not check in apubspec.lock,dart pub getin CI (Linux repo_checks->tool unit tests) now resolvesgit 2.5.0, causingpackage_command_test.dartto fail compilation against the checked-inMockGitDir:This PR:
script/tool/test/common/package_command_test.mocks.dartwithbuild_runneragainstpackage:git2.5.0.git: ^2.0.0inscript/tool/pubspec.yamlso thatLinux analyze_legacy N-2(which runs on Flutter3.41.9/ Dart3.11.5, whereasgit >=2.4.0requires Dart>=3.12.0) can still resolvegit 2.3.2when bootstrappingscript/toolinprepare_tool.sh.Part of flutter/flutter#195938
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2