Repository navigation
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If both you and the PR author believe this PR qualifies for a test exemption, escalate to the tech lead for the changed area to review and apply the |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the remaining unused dart:mirrors usage from the Pigeon package. Specifically, it removes the dart:mirrors imports, the isVoid helper function, and the _executeConfigurePigeon method. Additionally, it updates the package version to 29.1.1 in pubspec.yaml, generator_tools.dart, and CHANGELOG.md, and updates the documentation in CONTRIBUTING.md accordingly. There are no review comments, and I have no feedback to provide.
|
@gaaclarke @tarrinneal — this is the standalone upstream PR matching cl/1007219791 (removing the unused |
|
test exempt: just deleting code, no new logic |
gaaclarke
added
the
test-exempt
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
I'm going to defer to @tarrinneal here, I did mark it text exempt though.
tarrinneal
added
the
autosubmit
|
auto label is removed for flutter/packages/13524, Failed to merge flutter/packages/13524 with FormatException: Unexpected end of input (at character 1) ^ |
auto-submit
Bot
removed
the
autosubmit
Removes the remaining unused
dart:mirrorsimports and dead code frompigeon:isVoid(TypeMirror)andimport 'dart:mirrors';fromlib/src/generator_tools.dart._executeConfigurePigeonandimport 'dart:mirrors';fromlib/src/pigeon_lib.dart(legacy pre-0.3.0 reflection-based configuration, superseded by@ConfigurePigeonAST parsing).PigeonIsolate/dart:mirrorssection fromCONTRIBUTING.md.Split out from #13253.
Fixes flutter/flutter#190228
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2