Repository navigation
[material_ui] Fix InputDecorator intrinsic height when isDense or isC… - #13522
Merged
auto-submit[bot] merged 1 commit intoNov 5, 2026
Conversation
…ollapsed is true Aligns the minimum container height in computeMinIntrinsicHeight with the one used during layout, so the intrinsic height matches the laid out height for dense and collapsed decorations, including with compact visual density. Fixes flutter/flutter#190536
github-actions
Bot
added
p: material_ui
triage-design
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the minimum intrinsic height calculation in InputDecorator to match its laid out height when isDense or isCollapsed is true, and adds corresponding regression tests. The review feedback recommends replacing the null-assertion operator on decoration.isDense! with decoration.isDense == true to avoid potential runtime exceptions.
flutter-zl
pushed a commit
to NemesisDevX/flutter
that referenced
this pull request
Nov 6, 2026
flutter/packages@0478162...63881f9 2026-11-06 [email protected] [material_ui] Paint Dialog.fullscreen background color behind the keyboard (flutter/packages#13244) 2026-11-05 [email protected] [material_ui] Add tabBar/tab roles and expanded state semantics (flutter/packages#13176) 2026-11-05 [email protected] [material_ui] Disable the DropdownButtonFormField decoration when the field is disabled (flutter/packages#13473) 2026-11-05 [email protected] [material_ui] Fix Switch throwing when first painted mid-animation (flutter/packages#13496) 2026-11-05 [email protected] [various] Add engineIdentifier to fake plugin registrars (flutter/packages#13574) 2026-11-05 [email protected] [google_sign_in] Allow GoogleSignIn-iOS 10 (flutter/packages#13306) 2026-11-05 [email protected] [material_ui] Hit test the floating label of InputDecorator at its painted position (flutter/packages#13326) 2026-11-05 [email protected] [material_ui] Fix InputDecorator intrinsic height when isDense or isC… (flutter/packages#13522) 2026-11-05 [email protected] [material_ui] Paint Scaffold persistent bottom sheet background color behind the keyboard (flutter/packages#13242) 2026-11-05 [email protected] [image_picker_ios] PR 5/5 Switch Pigeon to Swift and finish the Objective-C to Swift migration. (flutter/packages#13493) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_RenderDecoration.computeMinIntrinsicHeightcomputed the minimum container height differently from_layout:_layoutisDense || isCollapsed || expandsinputHeightcomputeMinIntrinsicHeight(before)isDense || expands0.0This caused two mismatches between the intrinsic height and the laid out height:
isDense: truewith compact visual density (the default on desktop and web): the density offset (-8) shrinks the content height below the input height. Layout clamps it back up toinputHeight, but the intrinsic path clamped to0.0, so the intrinsic height was 8px too short. InsideIntrinsicHeight, this produced theA RenderFlex overflowed by 8.0 pixelserror reported in the issue.isCollapsed: truewithoutisDense(includingInputDecoration.collapsed): the intrinsic path still applied thekMinInteractiveDimension(48px) floor, while layout usedinputHeight, so the intrinsic height was too tall.This PR aligns
computeMinIntrinsicHeightwith_layout.isDense+isCollapsed, zero paddingisDense, zero paddingisCollapsedInputDecoration.collapsedFixes flutter/flutter#190536
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2