Repository navigation
[material_ui] Fix Switch throwing when first painted mid-animation - #13496
Merged
auto-submit[bot] merged 1 commit intoNov 5, 2026
Merged
Conversation
_SwitchPainter only initializes its pressed-state fields inside paint(). If the painter's first paint happens while the press reaction is reversing, or (for the Cupertino adaptive look) in the middle of the toggle animation, those fields are read before they are written. This throws a LateInitializationError for `_pressedThumbExtension` on the Material path, and a null check error for `_pressedInactiveThumbRadius!` on iOS and macOS. Default `_pressedThumbExtension` to 0 and fall back to the unpressed thumb radii in the Cupertino branch, as the Material branch already does. Fixes flutter/flutter#179532
Contributor
There was a problem hiding this comment.
Code Review
This pull request resolves an issue where Switch and Switch.adaptive could throw a LateInitializationError or a null check error when first painted during a press or toggle animation. The fix initializes _pressedThumbExtension to 0 and introduces local variables effectivePressedInactiveThumbRadius and effectivePressedActiveThumbRadius to safely handle null values, removing force-unwraps. Additionally, corresponding regression tests and a changelog entry have been added. There are no review comments, and no further feedback is provided.
flutter-zl
pushed a commit
to NemesisDevX/flutter
that referenced
this pull request
Nov 6, 2026
flutter/packages@0478162...63881f9 2026-11-06 [email protected] [material_ui] Paint Dialog.fullscreen background color behind the keyboard (flutter/packages#13244) 2026-11-05 [email protected] [material_ui] Add tabBar/tab roles and expanded state semantics (flutter/packages#13176) 2026-11-05 [email protected] [material_ui] Disable the DropdownButtonFormField decoration when the field is disabled (flutter/packages#13473) 2026-11-05 [email protected] [material_ui] Fix Switch throwing when first painted mid-animation (flutter/packages#13496) 2026-11-05 [email protected] [various] Add engineIdentifier to fake plugin registrars (flutter/packages#13574) 2026-11-05 [email protected] [google_sign_in] Allow GoogleSignIn-iOS 10 (flutter/packages#13306) 2026-11-05 [email protected] [material_ui] Hit test the floating label of InputDecorator at its painted position (flutter/packages#13326) 2026-11-05 [email protected] [material_ui] Fix InputDecorator intrinsic height when isDense or isC… (flutter/packages#13522) 2026-11-05 [email protected] [material_ui] Paint Scaffold persistent bottom sheet background color behind the keyboard (flutter/packages#13242) 2026-11-05 [email protected] [image_picker_ios] PR 5/5 Switch Pigeon to Swift and finish the Objective-C to Swift migration. (flutter/packages#13493) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_SwitchPainteronly initializes its pressed-state fields insidepaint(). If the painter's first paint happens in an unusual animation state, those fields are read before they are ever written:Switch/Switch.adaptiveon Android, Fuchsia, Linux, WindowsSwitch.adaptiveon iOS, macOSLateInitializationError(_pressedThumbExtension)Null check operator used on a null value(_pressedInactiveThumbRadius!)Null check operator used on a null value(_pressedInactiveThumbRadius!)This can happen, for example, when a
Switch.adaptivein aListView's cache extent (laid out but not painted) changes value and is scrolled into view during its toggle animation, or when a switch underOpacity(0)is long-pressed and becomes visible inonChanged.This PR defaults
_pressedThumbExtensionto0and falls back to the unpressed thumb radii in the Cupertino branch, as the Material branch already does. Initializing_pressedThumbExtensionalone (as suggested in the issue) is not enough, because the iOS/macOS null check error comes from_pressedInactiveThumbRadius!.Two regression tests cover both triggers on all platforms (
TargetPlatformVariant.all()). Without the fix, 8 of the 12 variants fail.Fixes flutter/flutter#179532
%23%23 Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the %23hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2