Repository navigation
[tool] Fix package matching logic for --package-tags filter - #13472
Merged
auto-submit[bot] merged 3 commits intoOct 28, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the dart-test command to identify packages by their relative path from the packages directory rather than their display name, fixing a bug where package tag matching fails when the repository is checked out in a directory named "packages". The review feedback suggests filtering out null values when resolving package tag keys to ensure the candidates set is typed as Set<String> instead of Set<String?> for better type safety.
elliette
added
the
autosubmit
Rheoz
pushed a commit
to Rheoz/flutter
that referenced
this pull request
Oct 29, 2026
flutter/packages@13d38e0...0b72e92 2026-10-29 [email protected] [material_ui] Mirror the GappedSliderTrackShape secondary track correctly in RTL (flutter/packages#13226) 2026-10-29 [email protected] [pigeon] update jni dependency to ^1.1.1 and remove workaround proguard rules (flutter/packages#13464) 2026-10-28 [email protected] [cupertino_ui] Document translucent default background of CupertinoSlidingSegmentedControl (flutter/packages#13178) 2026-10-28 [email protected] [flutter_svg] Throw on non-2xx responses in SvgNetworkLoader (flutter/packages#13403) 2026-10-28 [email protected] [tool] Fix package matching logic for `--package-tags` filter (flutter/packages#13472) 2026-10-28 [email protected] Roll Flutter from d4c8577 to 0c2473c (21 revisions) (flutter/packages#13470) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12763 introduced a new
--package-tagsflag that can be used to specify which flags to filter a package's tests with. After some investigation, I realized it wasn't working on CI.This is because we were trying to match the package key set in the YAML file (in this case
material_ui) toRepositoryPackage.displayNamewhich removes everything in the path up to the first path component namedpackages. On CI, the repository is checked out into a directory named packages, soRepositoryPackage.displayNamereturned the package's path with a leadingpackages/(e.g.packages/material_ui). As a result, it never matched in CI. Tag lookup now uses_packageTagKey, which returns the package's path relative to thepackages/directory that contains it (e.g.material_ui), regardless of where the repository is checked out.Work towards flutter/flutter#192308
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2