Repository navigation
manually roll flutter and fix flaky video player test that is preventing roll from landing - #13465
Merged
auto-submit[bot] merged 1 commit intoOct 27, 2026
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the integration tests in video_player_test.dart by adding calls to await tester.pumpAndSettle(_playDuration) after playing and pausing the video player controller. There are no review comments, so no feedback is provided.
flutter-zl
pushed a commit
to flutter-zl/flutter
that referenced
this pull request
Oct 28, 2026
flutter/packages@a8549ae...13d38e0 2026-10-28 [email protected] [material_ui] Unskip long press drag test on web (flutter/packages#13358) 2026-10-28 [email protected] [google_maps_flutter_ios, pigeon, webview_flutter_wkwebview] Migrate remaining example apps to uiscene (flutter/packages#13280) 2026-10-27 [email protected] manually roll flutter and fix flaky video player test that is preventing roll from landing (flutter/packages#13465) 2026-10-27 [email protected] [material_ui] Unskip web tests that pass on CanvasKit and Skwasm: data_table_test, floating_action_button_test, text_field_cursor_test (flutter/packages#13460) 2026-10-27 [email protected] [material_ui] Decouple disabled CheckboxListTile state in a11y_assessments (flutter/packages#13177) 2026-10-27 [email protected] [camera_web] Skip video input devices that cannot be started in availableCameras (flutter/packages#13196) 2026-10-27 [email protected] [camera] Add support for zero-shutter-lag capture (flutter/packages#12374) 2026-10-27 [email protected] [in_app_purchase_storekit} Fix more test flakes (flutter/packages#13279) 2026-10-27 [email protected] [material_ui] Refactor `typography.dart` and `text_theme.dart` in preparation for M3E (flutter/packages#13371) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
flutter/packages@a8549ae...13d38e0 2026-10-28 [email protected] [material_ui] Unskip long press drag test on web (flutter/packages#13358) 2026-10-28 [email protected] [google_maps_flutter_ios, pigeon, webview_flutter_wkwebview] Migrate remaining example apps to uiscene (flutter/packages#13280) 2026-10-27 [email protected] manually roll flutter and fix flaky video player test that is preventing roll from landing (flutter/packages#13465) 2026-10-27 [email protected] [material_ui] Unskip web tests that pass on CanvasKit and Skwasm: data_table_test, floating_action_button_test, text_field_cursor_test (flutter/packages#13460) 2026-10-27 [email protected] [material_ui] Decouple disabled CheckboxListTile state in a11y_assessments (flutter/packages#13177) 2026-10-27 [email protected] [camera_web] Skip video input devices that cannot be started in availableCameras (flutter/packages#13196) 2026-10-27 [email protected] [camera] Add support for zero-shutter-lag capture (flutter/packages#12374) 2026-10-27 [email protected] [in_app_purchase_storekit} Fix more test flakes (flutter/packages#13279) 2026-10-27 [email protected] [material_ui] Refactor `typography.dart` and `text_theme.dart` in preparation for M3E (flutter/packages#13371) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
roll flutter and fix flake!