Repository navigation
[go_router_builder] Allow build 5 - #13455
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the go_router_builder package to version 4.5.3, expanding the build dependency constraint in pubspec.yaml to allow version 5 (updating the range to "<6.0.0") and updating the CHANGELOG.md accordingly. There are no review comments, and I have no feedback to provide.
Piinks
left a comment
There was a problem hiding this comment.
Thanks for this! Just a nit to make sure the changelog is clear.
Co-authored-by: Kate Lovett <[email protected]>
It is done and thanks! |
|
Thank you everyone :) |
flutter/packages@3742a4e...3f34a6f 2026-11-01 [email protected] Roll Flutter from ee8b482 to fcfb4f2 (3 revisions) (flutter/packages#13520) 2026-10-31 [email protected] Roll Flutter from 5e805bf to ee8b482 (17 revisions) (flutter/packages#13512) 2026-10-30 [email protected] [VPAT] Describe the a11y_assessments dialog for screen readers (flutter/packages#13462) 2026-10-30 [email protected] [go_router_builder] Allow `build` 5 (flutter/packages#13455) 2026-10-30 [email protected] [go_router] Support nested parentheses, groups, and lookaround assertions in path parameters (flutter/packages#12571) 2026-10-30 [email protected] [in_app_purchase_storekit] Add SK2Transaction.currentEntitlements() (flutter/packages#13373) 2026-10-30 [email protected] [all] Remove broken .claude/skills symlink (flutter/packages#13492) 2026-10-30 [email protected] Roll Flutter from c091098 to 5e805bf (15 revisions) (flutter/packages#13504) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@3742a4e...3f34a6f 2026-11-01 [email protected] Roll Flutter from ee8b482 to fcfb4f2 (3 revisions) (flutter/packages#13520) 2026-10-31 [email protected] Roll Flutter from 5e805bf to ee8b482 (17 revisions) (flutter/packages#13512) 2026-10-30 [email protected] [VPAT] Describe the a11y_assessments dialog for screen readers (flutter/packages#13462) 2026-10-30 [email protected] [go_router_builder] Allow `build` 5 (flutter/packages#13455) 2026-10-30 [email protected] [go_router] Support nested parentheses, groups, and lookaround assertions in path parameters (flutter/packages#12571) 2026-10-30 [email protected] [in_app_purchase_storekit] Add SK2Transaction.currentEntitlements() (flutter/packages#13373) 2026-10-30 [email protected] [all] Remove broken .claude/skills symlink (flutter/packages#13492) 2026-10-30 [email protected] Roll Flutter from c091098 to 5e805bf (15 revisions) (flutter/packages#13504) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Widens the
buildconstraint to">=3.0.0 <6.0.0"so apps can usebuild_runner2.17.1, which requiresbuild5.build5.0.0 republishes the retracted 4.1.0 as a major version. Its only breaking change is the newBuildStep.librarySourceSinkmember, which breaks packages that implementBuildStep.go_router_builderonly receives aBuildStepinGoRouterGenerator.generateand does not implement it, so no code changes are needed.This also removes the
TODO(piinks): Pin version once new stable rolls.above the constraint. It was added in #10078 because the Flutter stable of the time pinned atestversion that could not resolvebuild4, so the range had to includebuild3; the plan was to switch to^4.0.0once a newer stable shipped. The range is now meant to spanbuild4 and 5, and pinning to^5.0.0would forcebuild_runner2.17.1 andanalyzer14.3 on every user, so the TODO no longer applies. Happy to restore it if you'd rather keep it.Tested locally on Flutter 3.47.8 (Dart 3.13.7), which resolves
build5.0.0,build_test3.5.23,build_runner2.17.1,source_gen4.3.1 andanalyzer14.6.0:custom-test --packages=go_router_builder(thetool/run_tests.dartbuilder golden tests): all 56 pass.dart-test --packages=go_router_builder --platform=vm: all pass (10 in the package, 19 in the example). On stable the example still resolvesbuild4.0.11 andbuild_runner2.16.1, because thetest_apipinned byflutter_testcapsanalyzerbelow 14.analyze --packages=go_router_builder: no issues.analyze --downgraderesolvesbuild4.0.4 and also reports no issues.Test exemption: this is a manual dependency roll that only widens a constraint. The existing builder tests cover generation with
build5 resolved.Fixes flutter/flutter#194542
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2