Repository navigation
[shared_preferences_foundation] Fix web compilation of apps that import the package - #13447
Merged
auto-submit[bot] merged 2 commits intoOct 27, 2026
Conversation
…onditional exports
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the package to support compilation on platforms without FFI, such as the web, by introducing conditional exports and stub implementations. The options class is moved to a separate file, and stub classes are exported when FFI is unavailable. Feedback points out that instantiating the options class on the web will cause a runtime crash due to the unguarded use of Platform.isIOS, and suggests guarding it with !kIsWeb.
tarrinneal
force-pushed
the
shared-preferences-foundation-web-fix
branch
from
October 27, 2026 01:55
e38c3c6 to
bdc680d
Compare
tarrinneal
added
the
emergency
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
tarrinneal
added
autosubmit
tarrinneal
added
autosubmit
This was referenced Oct 27, 2026
GhagSagar23
pushed a commit
to Kryonex-Labs/flutter
that referenced
this pull request
Oct 27, 2026
flutter/packages@23a05b6...a8549ae 2026-10-27 [email protected] [material_ui] Deprecate the black/white parameters in `Typography.material2021` (flutter/packages#13443) 2026-10-27 [email protected] [shared_preferences] Defer SharedPreferences fetch in `LegacySharedPreferencesPlugin` until first use on Android (flutter/packages#13431) 2026-10-27 [email protected] [material_ui] Fix MenuAnchor non-Unicode shortcut labels on JS web (flutter/packages#13370) 2026-10-27 [email protected] [material_ui] Add Checkbox.markInsets (flutter/packages#12690) 2026-10-27 [email protected] [vector_graphics_compiler] Handle coordinate lists on text and tspan (flutter/packages#13287) 2026-10-27 [email protected] [cupertino_ui] Unskip web tests that pass on CanvasKit and Skwasm: nav_bar_transition_test, refresh_test, route_test, text_field_cursor_test (flutter/packages#13439) 2026-10-27 [email protected] [material_ui] Fix `TextTheme` and `Typography` `debugFillProperties` defaults (flutter/packages#13374) 2026-10-27 [email protected] [material_ui] Update out-of-date typography documentation (flutter/packages#13372) 2026-10-27 [email protected] [shared_preferences_foundation] Fix web compilation of apps that import the package (flutter/packages#13447) 2026-10-26 [email protected] Fix AI guidelines link in PR template (flutter/packages#13411) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
flutter/packages@23a05b6...a8549ae 2026-10-27 [email protected] [material_ui] Deprecate the black/white parameters in `Typography.material2021` (flutter/packages#13443) 2026-10-27 [email protected] [shared_preferences] Defer SharedPreferences fetch in `LegacySharedPreferencesPlugin` until first use on Android (flutter/packages#13431) 2026-10-27 [email protected] [material_ui] Fix MenuAnchor non-Unicode shortcut labels on JS web (flutter/packages#13370) 2026-10-27 [email protected] [material_ui] Add Checkbox.markInsets (flutter/packages#12690) 2026-10-27 [email protected] [vector_graphics_compiler] Handle coordinate lists on text and tspan (flutter/packages#13287) 2026-10-27 [email protected] [cupertino_ui] Unskip web tests that pass on CanvasKit and Skwasm: nav_bar_transition_test, refresh_test, route_test, text_field_cursor_test (flutter/packages#13439) 2026-10-27 [email protected] [material_ui] Fix `TextTheme` and `Typography` `debugFillProperties` defaults (flutter/packages#13374) 2026-10-27 [email protected] [material_ui] Update out-of-date typography documentation (flutter/packages#13372) 2026-10-27 [email protected] [shared_preferences_foundation] Fix web compilation of apps that import the package (flutter/packages#13447) 2026-10-26 [email protected] Fix AI guidelines link in PR template (flutter/packages#13411) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 2.6.0 (#12329),
package:shared_preferences_foundation/shared_preferences_foundation.darttransitively importsdart:ffiandpackage:objective_c, causing multi-platform apps that import it (for example to useSharedPreferencesAsyncFoundationOptions) to fail compilation on web. This currently breaksshared_preferences/exampleweb drive tests in CI.Following the same approach as
shared_preferences_androidin #13380, this conditionally exports a stub of the plugin classes whendart.library.ffiis unavailable and movesSharedPreferencesAsyncFoundationOptionsinto its own FFI-free file.