Repository navigation
[cupertino_ui] Fix the tinted button's fill opacity - #13436
Merged
auto-submit[bot] merged 3 commits intoNov 11, 2026
Merged
auto-submit[bot] merged 3 commits into
auto-submit[bot] merged 3 commits into
Conversation
github-actions
Bot
added
p: cupertino_ui
triage-design
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the kCupertinoButtonTintedOpacityLight constant from 0.12 to 0.18 to align with iOS design guidelines, along with updating related tests and adding a changelog entry. Feedback on the changes suggests splitting the multi-variable declaration in constants.dart into separate lines to adhere to the Effective Dart style guide.
LahaLuhem
force-pushed
the
bugfix/#195265-tinted-button-opacity
branch
2 times, most recently
from
October 27, 2026 07:55
25a00a9 to
8adc479
Compare
LahaLuhem
force-pushed
the
bugfix/#195265-tinted-button-opacity
branch
2 times, most recently
from
November 7, 2026 10:58
88927f7 to
1d4aa01
Compare
LahaLuhem
force-pushed
the
bugfix/#195265-tinted-button-opacity
branch
from
November 8, 2026 10:06
1d4aa01 to
3c40a47
Compare
Contributor
Author
All on iPhone 16 Pro, iOS 18.5. |
Contributor
Author
|
Looking at the screenshots, I also noticed the sizes discrepency. I've filed #196373 |
pjkammer
approved these changes
Nov 11, 2026
pjkammer
added
the
autosubmit
b-luk
pushed a commit
to b-luk/flutter
that referenced
this pull request
Nov 12, 2026
…r#196450) flutter/packages@653628e...14f9933 2026-11-12 [email protected] [material_ui] Fix SnackBarThemeData.lerp dropping showCloseIcon (flutter/packages#13449) 2026-11-11 [email protected] [ci] Update repo for 3.50 stable release (flutter/packages#13628) 2026-11-11 [email protected] [vector_graphics] Use font-family lists as a family with fallbacks (flutter/packages#13552) 2026-11-11 [email protected] Roll Flutter (stable) from c197ca5 to ab29120 (1647 revisions) (flutter/packages#13625) 2026-11-11 [email protected] [shared_prferences] Adopts mockito-kotlin in tests (flutter/packages#13624) 2026-11-11 [email protected] [cupertino_ui] Dim disabled CupertinoSlider controls (flutter/packages#13419) 2026-11-11 [email protected] [flutter_svg] Invalidate pending cache entries on clear and evict (flutter/packages#13595) 2026-11-11 [email protected] [cupertino_ui] Fix the tinted button's fill opacity (flutter/packages#13436) 2026-11-11 [email protected] [various] Support SVG filters (blur, offset, feMerge) (flutter/packages#11909) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CupertinoButton.tintedfills with 12% of the accent where UIKit uses 18%. On white that is#e0efffagainst UIKit's#d1e7ff. Dark mode already matched at 26%.Fixes flutter/flutter#195265
The constant has a second reader
kCupertinoButtonTintedOpacityLightalso paintsCupertinoActionSheetAction's focus highlight, so that changes as well.That reuse was deliberate. The focus support PR (flutter/flutter#167119) took the colour from
CupertinoButtonon purpose, and iOS has no fixed number of its own here, because the focus colour is a system setting the user can change. Splitting the constant would pin the highlight to a value, whose only source was the button's.Tests
button_test.dartalready pinned the light fill with a literal, so it just moves to 18%.action_sheet_test.dart's light focus case computed its expected colour from the constant, so it could never fail on a value change and now carries the literal too. The dark cases still read the constant, which is correct, nothing here moves them.Not touched
The same line sits in
packages/flutter/lib/src/cupertino/constants.dartwith the same two readers, soCupertinoButton.tintedin the SDK keeps the old value.Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2