Repository navigation
[material_ui] Migrate M3 BottomAppBar template to use new gen_defaults - #13385
Merged
auto-submit[bot] merged 2 commits intoOct 23, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the generation of Material 3 BottomAppBar defaults to the token-based generator. It removes the hardcoded _BottomAppBarDefaultsM3 class from bottom_app_bar.dart and replaces it with a generated part file. Additionally, it introduces the BottomAppBarTemplateM3 template, enables its generation in gen_defaults.dart, and adds a test case in gen_defaults_test.dart to verify the generated output. There are no review comments, and I have no feedback to provide.
github-actions
Bot
added
p: material_ui
triage-design
elliette
added
override: no versioning needed
QuncCccccc
approved these changes
Oct 23, 2026
QuncCccccc
left a comment
QuncCccccc
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you! We are almost done!!
elliette
added
the
autosubmit
reginaldalfret
pushed a commit
to reginaldalfret/flutter
that referenced
this pull request
Oct 26, 2026
flutter/packages@108dad0...23a05b6 2026-10-23 [email protected] [video_player] Fix crash regression with async calls on iOS/macOS (flutter/packages#13383) 2026-10-23 [email protected] [material_ui] Migrate M3 SegmentedButton template to use new gen_defaults (flutter/packages#13227) 2026-10-23 [email protected] [material_ui] Migrate M3 Slider template to use new gen_defaults (flutter/packages#13195) 2026-10-23 [email protected] [material_ui] Migrate M3 BottomAppBar template to use new gen_defaults (flutter/packages#13385) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
flutter/packages@108dad0...23a05b6 2026-10-23 [email protected] [video_player] Fix crash regression with async calls on iOS/macOS (flutter/packages#13383) 2026-10-23 [email protected] [material_ui] Migrate M3 SegmentedButton template to use new gen_defaults (flutter/packages#13227) 2026-10-23 [email protected] [material_ui] Migrate M3 Slider template to use new gen_defaults (flutter/packages#13195) 2026-10-23 [email protected] [material_ui] Migrate M3 BottomAppBar template to use new gen_defaults (flutter/packages#13385) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work toward flutter/flutter#187899
Fixes flutter/flutter#188403
This PR migrates the M3 BottomAppBar defaults template to use the new gen_defaults in material_ui.
Pre-Review Checklist
[shared_preferences]///).Changelog/version exemption: No-op, pure migration.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2