Repository navigation
[material_ui] Unskip long press drag test on web - #13358
Merged
auto-submit[bot] merged 1 commit intoOct 28, 2026
Merged
auto-submit[bot] merged 1 commit into
auto-submit[bot] merged 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies packages/material_ui/test/text_field_test.dart to replace relative gesture movements (moveBy) with absolute movements (moveTo) targeting specific text offsets. It also replaces the skip parameter with a tags: 'reduced-web-test-set' parameter in a test configuration. There are no review comments, and I have no feedback to provide.
mdebbar
requested review from
Renzo-Olivares
and removed request for
harryterkelsen
October 20, 2026 22:39
github-actions
Bot
added
p: material_ui
triage-design
flutter-zl
pushed a commit
to bardiakz/flutter
that referenced
this pull request
Oct 21, 2026
Most entries in `kWebTestFileKnownFailures` (framework test files
excluded from the web shards) have been passing on the web for a while:
`performance_overlay_test.dart`, `html_element_view_test.dart`,
`cupertino/scaffold_test.dart`, and `rendering/platform_view_test.dart`
pass on both JS and wasm and are removed from the list.
The two "not compilable" entries stay (`Int64List`, relative import
outside the package). `@TestOn('!chrome')` can't replace them because
`flutter test --platform=chrome` compiles all test files into a single
entrypoint before the test runner evaluates the annotation. The JS and
wasm lists are now identical, so the map is collapsed into one list.
`test/material/text_field_test.dart` still has 3 failing cases on the
web, but that file is under the Material code freeze
(flutter#188444), so it stays in the
list with a TODO. The web fix for that test lives in `material_ui`:
flutter/packages#13358
LongCatIsLooong
pushed a commit
to LongCatIsLooong/flutter
that referenced
this pull request
Oct 22, 2026
Most entries in `kWebTestFileKnownFailures` (framework test files
excluded from the web shards) have been passing on the web for a while:
`performance_overlay_test.dart`, `html_element_view_test.dart`,
`cupertino/scaffold_test.dart`, and `rendering/platform_view_test.dart`
pass on both JS and wasm and are removed from the list.
The two "not compilable" entries stay (`Int64List`, relative import
outside the package). `@TestOn('!chrome')` can't replace them because
`flutter test --platform=chrome` compiles all test files into a single
entrypoint before the test runner evaluates the annotation. The JS and
wasm lists are now identical, so the map is collapsed into one list.
`test/material/text_field_test.dart` still has 3 failing cases on the
web, but that file is under the Material code freeze
(flutter#188444), so it stays in the
list with a TODO. The web fix for that test lives in `material_ui`:
flutter/packages#13358
mdebbar
added
the
autosubmit
flutter-zl
pushed a commit
to flutter-zl/flutter
that referenced
this pull request
Oct 28, 2026
flutter/packages@a8549ae...13d38e0 2026-10-28 [email protected] [material_ui] Unskip long press drag test on web (flutter/packages#13358) 2026-10-28 [email protected] [google_maps_flutter_ios, pigeon, webview_flutter_wkwebview] Migrate remaining example apps to uiscene (flutter/packages#13280) 2026-10-27 [email protected] manually roll flutter and fix flaky video player test that is preventing roll from landing (flutter/packages#13465) 2026-10-27 [email protected] [material_ui] Unskip web tests that pass on CanvasKit and Skwasm: data_table_test, floating_action_button_test, text_field_cursor_test (flutter/packages#13460) 2026-10-27 [email protected] [material_ui] Decouple disabled CheckboxListTile state in a11y_assessments (flutter/packages#13177) 2026-10-27 [email protected] [camera_web] Skip video input devices that cannot be started in availableCameras (flutter/packages#13196) 2026-10-27 [email protected] [camera] Add support for zero-shutter-lag capture (flutter/packages#12374) 2026-10-27 [email protected] [in_app_purchase_storekit} Fix more test flakes (flutter/packages#13279) 2026-10-27 [email protected] [material_ui] Refactor `typography.dart` and `text_theme.dart` in preparation for M3E (flutter/packages#13371) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
Most entries in `kWebTestFileKnownFailures` (framework test files
excluded from the web shards) have been passing on the web for a while:
`performance_overlay_test.dart`, `html_element_view_test.dart`,
`cupertino/scaffold_test.dart`, and `rendering/platform_view_test.dart`
pass on both JS and wasm and are removed from the list.
The two "not compilable" entries stay (`Int64List`, relative import
outside the package). `@TestOn('!chrome')` can't replace them because
`flutter test --platform=chrome` compiles all test files into a single
entrypoint before the test runner evaluates the annotation. The JS and
wasm lists are now identical, so the map is collapsed into one list.
`test/material/text_field_test.dart` still has 3 failing cases on the
web, but that file is under the Material code freeze
(flutter#188444), so it stays in the
list with a TODO. The web fix for that test lives in `material_ui`:
flutter/packages#13358
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
flutter/packages@a8549ae...13d38e0 2026-10-28 [email protected] [material_ui] Unskip long press drag test on web (flutter/packages#13358) 2026-10-28 [email protected] [google_maps_flutter_ios, pigeon, webview_flutter_wkwebview] Migrate remaining example apps to uiscene (flutter/packages#13280) 2026-10-27 [email protected] manually roll flutter and fix flaky video player test that is preventing roll from landing (flutter/packages#13465) 2026-10-27 [email protected] [material_ui] Unskip web tests that pass on CanvasKit and Skwasm: data_table_test, floating_action_button_test, text_field_cursor_test (flutter/packages#13460) 2026-10-27 [email protected] [material_ui] Decouple disabled CheckboxListTile state in a11y_assessments (flutter/packages#13177) 2026-10-27 [email protected] [camera_web] Skip video input devices that cannot be started in availableCameras (flutter/packages#13196) 2026-10-27 [email protected] [camera] Add support for zero-shutter-lag capture (flutter/packages#12374) 2026-10-27 [email protected] [in_app_purchase_storekit} Fix more test flakes (flutter/packages#13279) 2026-10-27 [email protected] [material_ui] Refactor `typography.dart` and `text_theme.dart` in preparation for M3E (flutter/packages#13371) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to flutter/flutter#194877.
long press drag extends the selection to the word under the drag and shows toolbar on lift on non-Apple platformsis skipped on the web, but the only thing that actually breaks there is the drag geometry:textOffsetToPositionnudges the position by 1px on web, somoveBy(const Offset(-200, 0))lands exactly on the glyph boundary betweenPeeland the following space, andgetWordAtOffsetresolves to the whitespace instead of the word._expectMaterialToolbarForPartialSelection()already handlesisContextMenuProvidedByPlatform, so the skip is not needed once the drag targets are fixed.This PR drags to the middle of each target word instead of relative offsets, drops the skip, and tags the test with
reduced-web-test-setso it runs on the web shards. Verified withflutter test,flutter test --platform chrome, andflutter test --platform chrome --wasm.Test-only change, so no version bump or CHANGELOG entry is needed.