Repository navigation
[google_sign_in] Allow GoogleSignIn-iOS 10 - #13306
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If both you and the PR author believe this PR qualifies for a test exemption, escalate to the tech lead for the changed area to review and apply the |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the minimum supported platform versions for the google_sign_in_ios package to iOS 15 and macOS 12 across the package configuration, podspec, Swift Package Manager configuration, and example projects. It also updates the package's Flutter and Dart SDK constraints to Flutter 3.47 and Dart 3.13, expands the GoogleSignIn-iOS dependency range to support version 10.x, and updates the documentation and changelogs accordingly. There are no review comments, and I have no feedback to provide.
|
Pushed be523b8 to fix The remaining failure is the version check on |
|
override: no versioning needed: the google_sign_in change is README‑only |
jmagman
added
the
override: no versioning needed
|
Merged main to resolve the CHANGELOG/pubspec conflict with 6.3.9. I also widened the podspec to GoogleSignIn-iOS 10.1.0 has since been released with google/GoogleSignIn-iOS#626 (App Check 12), so apps on firebase-ios-sdk 13 can resolve it with this range. The description is updated to match. Could a maintainer re-add |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Hitting this with firebase_core 5.1.0 / firebase_remote_config 7.0.1 / firebase_messaging 17.0.1 and google_sign_in_ios 6.3.8 on SwiftPM (Flutter , Xcode ). flutter build ios fails at package resolution: firebase-ios-sdk 13.1.1 needs gtm-session-fetcher 4.0–6.0, GoogleSignIn-iOS 9.x needs 3.3–4.0. We've parked our iOS release until a google_sign_in_ios version with this change ships. Is there anything we can do to help get this reviewed, such as testing a branch? |
Widens the
GoogleSignIn-iOSrequirement from9.0.0..<10.0.0to9.0.0..<11.0.0in both the Swift package and the podspec (~> 9.0to>= 9.0, < 11.0), so apps can resolve GoogleSignIn 10, which allowsgtm-session-fetcher4.x and 5.x.GoogleSignIn 10 requires iOS 15 and macOS 12, and SwiftPM rejects a package whose dependency needs a higher platform than the package declares. This raises the plugin minimums to iOS 15 / macOS 12 (matching Flutter 3.47), updates the macOS example deployment targets, and updates the
google_sign_inREADME support table, following #13292.Apps that also use firebase-ios-sdk 13 (no longer published to CocoaPods) need GoogleSignIn-iOS 10.1.0 or later, which includes google/GoogleSignIn-iOS#626 and widens App Check from 11.x to
11.0.0..<13.0.0. The range here admits 10.1.0.Fixes flutter/flutter#194435
Pre-Review Checklist
[shared_preferences]///).Versioning:
google_sign_inonly changes its README (support table) and macOS example, so it's listed under NEXT without a version bump, as in #13292.Test exemption: manual dependency update with no plugin code changes. The existing native and integration tests run against GoogleSignIn 10 once SwiftPM or CocoaPods resolves it.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2