Skip to content

[camera_avfoundation] Fixes sendability mismatch in completion handler - #13298

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
jmagman:camera-send
Oct 16, 2026
Merged

auto-submit[bot] merged 1 commit into
flutter:mainfrom
jmagman:camera-send

Conversation

@jmagman

@jmagman jmagman commented Oct 16, 2026

Copy link
Copy Markdown
Member

This wasn't showing up in CI due to flutter/flutter#194517.

Fixes flutter/flutter#194599

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@jmagman jmagman added the CICD Run CI/CD label Oct 16, 2026
@jmagman
jmagman marked this pull request as ready for review October 16, 2026 22:26

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CaptureDevice protocol and its mock implementation in camera_avfoundation to include the @Sendable attribute on the completion handler of setExposureTargetBias. Additionally, the package version is bumped to 0.11.0+4 in pubspec.yaml and the CHANGELOG.md is updated. There are no review comments, and I have no feedback to provide.

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 16, 2026
@auto-submit
auto-submit Bot merged commit d73117f into flutter:main Oct 16, 2026
13 checks passed
@jmagman
jmagman deleted the camera-send branch October 16, 2026 23:50
opensource-fork-sync Bot pushed a commit to cla7aye15I4nd/opensource-flutter__flutter that referenced this pull request Oct 19, 2026
flutter/packages@93eede7...10a178c

2026-10-19 [email protected] [material_ui]
Fixes SearchAnchor and SearchBar semantics (flutter/packages#12680)
2026-10-17 [email protected] [shared_preferences] switch to ffi/jni
pigeon (flutter/packages#12329)
2026-10-17 [email protected]
[in_app_purchase_storekit] Add show manage subscriptions path
(flutter/packages#12454)
2026-10-17 [email protected] [material_ui] Fix installing command
material UI (flutter/packages#13135)
2026-10-16 [email protected] [file_selector_ios] Drop deprecated
UIDocumentPickerMode code path (flutter/packages#13292)
2026-10-16 [email protected] [camera_avfoundation] Fixes sendability
mismatch in completion handler (flutter/packages#13298)
2026-10-16 [email protected] [local_auth_darwin] Fix Swift 6 concurrency
analyzer errors from lifecycle delegate methods (flutter/packages#13296)
2026-10-16 [email protected] [pointer_interceptor_ios] Use 'let' for
unmutated var (flutter/packages#13297)
2026-10-16 [email protected] [image_picker_ios] Fix Swift warnings in
ImagePickerPluginTests (flutter/packages#13299)
2026-10-16 [email protected] [camera]delete
fake bitrate/fps integration tests (flutter/packages#13291)
2026-10-16 [email protected] [google_maps_flutter_ios] Use 'let' for
unmutated var (flutter/packages#13300)
2026-10-16 [email protected] [VPAT] Declare input purpose on
a11y_assessments text fields (flutter/packages#13243)
2026-10-16 [email protected] [cupertino_ui]
Fix CupertinoMagnifier focalPointOffset animation scaling
(flutter/packages#13118)
2026-10-16 [email protected] [tool] Exempt `test_apps/` from version
and changelog checks (flutter/packages#13255)
2026-10-16 [email protected] [material_ui] Fallback theme
follows platform cherry pick (flutter/packages#13278)
2026-10-16 [email protected] Roll Flutter from
5c7e45a to a3d71d8 (26 revisions) (flutter/packages#13290)
2026-10-16 [email protected] [camera]do not
sleep to avoid hang due to merged thread (flutter/packages#13289)
2026-10-16 [email protected] [camera]fix
camera failure due to wrong jpg extension (flutter/packages#13285)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
suryaKommana2662 pushed a commit to suryaKommana2662/flutter that referenced this pull request Oct 29, 2026
flutter/packages@93eede7...10a178c

2026-10-19 [email protected] [material_ui]
Fixes SearchAnchor and SearchBar semantics (flutter/packages#12680)
2026-10-17 [email protected] [shared_preferences] switch to ffi/jni
pigeon (flutter/packages#12329)
2026-10-17 [email protected]
[in_app_purchase_storekit] Add show manage subscriptions path
(flutter/packages#12454)
2026-10-17 [email protected] [material_ui] Fix installing command
material UI (flutter/packages#13135)
2026-10-16 [email protected] [file_selector_ios] Drop deprecated
UIDocumentPickerMode code path (flutter/packages#13292)
2026-10-16 [email protected] [camera_avfoundation] Fixes sendability
mismatch in completion handler (flutter/packages#13298)
2026-10-16 [email protected] [local_auth_darwin] Fix Swift 6 concurrency
analyzer errors from lifecycle delegate methods (flutter/packages#13296)
2026-10-16 [email protected] [pointer_interceptor_ios] Use 'let' for
unmutated var (flutter/packages#13297)
2026-10-16 [email protected] [image_picker_ios] Fix Swift warnings in
ImagePickerPluginTests (flutter/packages#13299)
2026-10-16 [email protected] [camera]delete
fake bitrate/fps integration tests (flutter/packages#13291)
2026-10-16 [email protected] [google_maps_flutter_ios] Use 'let' for
unmutated var (flutter/packages#13300)
2026-10-16 [email protected] [VPAT] Declare input purpose on
a11y_assessments text fields (flutter/packages#13243)
2026-10-16 [email protected] [cupertino_ui]
Fix CupertinoMagnifier focalPointOffset animation scaling
(flutter/packages#13118)
2026-10-16 [email protected] [tool] Exempt `test_apps/` from version
and changelog checks (flutter/packages#13255)
2026-10-16 [email protected] [material_ui] Fallback theme
follows platform cherry pick (flutter/packages#13278)
2026-10-16 [email protected] Roll Flutter from
5c7e45a to a3d71d8 (26 revisions) (flutter/packages#13290)
2026-10-16 [email protected] [camera]do not
sleep to avoid hang due to merged thread (flutter/packages#13289)
2026-10-16 [email protected] [camera]fix
camera failure due to wrong jpg extension (flutter/packages#13285)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: camera platform-ios platform-macos

Projects

None yet

2 participants