Repository navigation
[tool] Include Swift in warning-as-error modes - #13284
Draft
stuartmorgan wants to merge 8 commits into
Draft
stuartmorgan wants to merge 8 commits into
stuartmorgan wants to merge 8 commits into
Conversation
jmagman
reviewed
Oct 16, 2026
| extraFlags: <String>[ | ||
| ...extraFlags, | ||
| 'GCC_TREAT_WARNINGS_AS_ERRORS=YES', | ||
| 'SWIFT_TREAT_WARNINGS_AS_ERRORS=YES', |
Member
There was a problem hiding this comment.
This not is wacky, but I think it'll work...
r'SWIFT_TREAT_WARNINGS_AS_ERRORS=$(SWIFT_SUPPRESS_WARNINGS:not)',
Member
There was a problem hiding this comment.
Took the liberty of pushing a commit, let's see what happens.
Member
There was a problem hiding this comment.
Yup, it worked. Now there's a pile of Swift analyzer warnings.
10 of 11 tasks
Testing addition of `SWIFT_TREAT_WARNINGS_AS_ERRORS`.
jmagman
force-pushed
the
swift-warnings-as-errors
branch
from
October 19, 2026 23:18
af771cc to
4778091
Compare
jmagman
force-pushed
the
swift-warnings-as-errors
branch
from
October 19, 2026 23:38
4dd02c2 to
9893147
Compare
auto-submit Bot
pushed a commit
that referenced
this pull request
Oct 20, 2026
I don't know why these analyzer issues are being reported one-at-a-time in CI on #13284 instead of all at once, but #13332 was only one of a few analyzer issues: ``` darwin/Tests/CameraSessionPresetsTests.swift:28:9: error: variable 'currentFormat' was never mutated; consider changing to 'let' constant var currentFormat: CaptureDeviceFormat = captureFormatMock ~~~ ^ let darwin/Tests/CameraInitRaceConditionsTests.swift:62:24: warning: immutable value '_captureSessionQueue' was never used; consider replacing with '_' or removing it [#NoUsage] 60 | 61 | func testFlutterChannelInitializedWhenStartingImageStream() { 62 | let (cameraPlugin, _captureSessionQueue) = createCameraPlugin() darwin/Tests/AvailableCamerasTests.swift:49:11: warning: variable 'requiredTypes' was never mutated; consider changing to 'let' constant [#VariableNeverMutated] 47 | telephotoCamera.position = .back 48 | 49 | var requiredTypes: [AVCaptureDevice.DeviceType] = [ darwin/Tests/AvailableCamerasTests.swift:52:11: warning: variable 'cameras' was never mutated; consider changing to 'let' constant [#VariableNeverMutated] 50 | .builtInWideAngleCamera, .builtInTelephotoCamera, .builtInUltraWideCamera, 51 | ] 52 | var cameras = [wideAngleCamera, frontFacingCamera, telephotoCamera, ultraWideCamera] darwin/Tests/AvailableCamerasTests.swift:86:11: warning: variable 'requiredTypes' was never mutated; consider changing to 'let' constant [#VariableNeverMutated] 84 | frontFacingCamera.position = .front 85 | 86 | var requiredTypes: [AVCaptureDevice.DeviceType] = [ darwin/Tests/AvailableCamerasTests.swift:118:11: warning: variable 'requiredTypes' was never mutated; consider changing to 'let' constant [#VariableNeverMutated] 116 | unspecifiedCamera.position = .unspecified 117 | 118 | var requiredTypes: [AVCaptureDevice.DeviceType] = [ darwin/Tests/CameraOrientationTests.swift:120:14: warning: weak variable 'weakDevice' was never mutated; consider changing to 'let' constant [#VariableNeverMutated::WeakMutability] 118 | let captureSessionQueue = DispatchQueue(label: "capture_session_queue") 119 | weak var weakPlugin: CameraPlugin? 120 | weak var weakDevice = mockDevice darwin/Tests/CameraOrientationTests.swift:157:14: warning: weak variable 'weakEventAPI' was never mutated; consider changing to 'let' constant [#VariableNeverMutated::WeakMutability] 155 | } 156 | 157 | weak var weakEventAPI = mockEventAPI ``` This wasn't showing up in CI due to flutter/flutter#194517. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Contributor
Author
|
I think once the last image_picker Swift PR lands it'll just be the IAP deprecation warnings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing addition of
SWIFT_TREAT_WARNINGS_AS_ERRORS.See flutter/flutter#194517