Skip to content

[google_maps_flutter_ios, pigeon, webview_flutter_wkwebview] Migrate remaining example apps to uiscene - #13280

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
LouiseHsu:migrate-remaining-ios-examples-uiscene
Oct 28, 2026
Merged

[google_maps_flutter_ios, pigeon, webview_flutter_wkwebview] Migrate remaining example apps to uiscene#13280
auto-submit[bot] merged 2 commits into
flutter:mainfrom
LouiseHsu:migrate-remaining-ios-examples-uiscene

Conversation

@LouiseHsu

@LouiseHsu LouiseHsu commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes flutter/flutter#194284 (+ a bonus extra special migration for pigeon/example/native_interop_app!! Wow!)

These four example apps got missed out in the original round of migrations.

  • webview_flutter_wkwebview/example
    • In the initial example migration sweep, webview_flutter/webview_flutter/example was migrated while webview_flutter_wkwebview/example was missed which is understandable
  • google_maps_flutter_ios_sdk9/example & google_maps_flutter_ios_sdk10/example
    • when I migrated AppDelegate.swift in google_maps_flutter_ios_shared_code, the sync script copied AppDelegate.swift into sdk9 and sdk10. But Info.plist isn't in shared_code, so the script didn't copy Info.plist
  • pigeon/example/native_interop_app
    • This was landed post the round of example migrations. Its AppDelegate.swift already adopts FlutterImplicitEngineDelegate, so it only needed UIApplicationSceneManifest in Info.plist.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • [] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboard

flutter-dashboard Bot commented Oct 15, 2026

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If both you and the PR author believe this PR qualifies for a test exemption, escalate to the tech lead for the changed area to review and apply the test-exempt label. All reviewers should feel empowered to ask for tests before escalating.

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Oct 15, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several iOS example applications to support multi-scene configurations by adding the 'UIApplicationSceneManifest' key and specifying 'FlutterSceneDelegate' in their 'Info.plist' files. Additionally, the 'webview_flutter_wkwebview' example is updated to conform to 'FlutterImplicitEngineDelegate', moving plugin registration from 'didFinishLaunchingWithOptions:' to 'didInitializeImplicitFlutterEngine:'. There are no review comments, and I have no feedback to provide.

@LouiseHsu
LouiseHsu requested a review from tarrinneal October 15, 2026 23:29
@LouiseHsu LouiseHsu changed the title [google_maps_flutter_ios, pigeon, webview_flutter_wkwebview] Migrate … [google_maps_flutter_ios, pigeon, webview_flutter_wkwebview] Migrate remaining example apps to uiscene Oct 15, 2026
@LouiseHsu LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 27, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 27, 2026
@auto-submit

auto-submit Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/13280, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit

auto-submit Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/13280, because - This pull request has the missing-tests label and does not have the test-exempt label. Please add tests or obtain a test exemption from a tech lead before re-applying the autosubmit label.

@vashworth

vashworth commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Test exempt: This PR only changes test files

@vashworth vashworth added the test-exempt Exempt from tests. Overrides `missing-tests` label label Oct 27, 2026
@LouiseHsu LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 27, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 27, 2026
@auto-submit

auto-submit Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/13280, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@LouiseHsu LouiseHsu added override: no changelog needed Override the check requiring CHANGELOG updates for most changes autosubmit Merge PR when tree becomes green via auto submit App labels Oct 27, 2026
@auto-submit
auto-submit Bot merged commit 8cdc6e5 into flutter:main Oct 28, 2026
13 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 28, 2026
Merged
flutter-zl pushed a commit to flutter-zl/flutter that referenced this pull request Oct 28, 2026
@engine-flutter-autoroll
Roll Packages from a8549ae to 13d38e0 (9 revisions) (flutter#195488)
0c2473c 
flutter/packages@a8549ae...13d38e0

2026-10-28 [email protected] [material_ui] Unskip long press drag test
on web (flutter/packages#13358)
2026-10-28 [email protected] [google_maps_flutter_ios, pigeon,
webview_flutter_wkwebview] Migrate remaining example apps to uiscene
(flutter/packages#13280)
2026-10-27 [email protected] manually roll flutter and fix flaky
video player test that is preventing roll from landing
(flutter/packages#13465)
2026-10-27 [email protected] [material_ui]
Unskip web tests that pass on CanvasKit and Skwasm: data_table_test,
floating_action_button_test, text_field_cursor_test
(flutter/packages#13460)
2026-10-27 [email protected] [material_ui] Decouple
disabled CheckboxListTile state in a11y_assessments
(flutter/packages#13177)
2026-10-27 [email protected] [camera_web] Skip video input
devices that cannot be started in availableCameras
(flutter/packages#13196)
2026-10-27 [email protected] [camera] Add support for
zero-shutter-lag capture (flutter/packages#12374)
2026-10-27 [email protected] [in_app_purchase_storekit} Fix more test
flakes (flutter/packages#13279)
2026-10-27 [email protected] [material_ui]
Refactor `typography.dart` and `text_theme.dart` in preparation for M3E
(flutter/packages#13371)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
suryaKommana2662 pushed a commit to suryaKommana2662/flutter that referenced this pull request Oct 29, 2026
@engine-flutter-autoroll @suryaKommana2662
Roll Packages from a8549ae to 13d38e0 (9 revisions) (flutter#195488)
0842dfd 
flutter/packages@a8549ae...13d38e0

2026-10-28 [email protected] [material_ui] Unskip long press drag test
on web (flutter/packages#13358)
2026-10-28 [email protected] [google_maps_flutter_ios, pigeon,
webview_flutter_wkwebview] Migrate remaining example apps to uiscene
(flutter/packages#13280)
2026-10-27 [email protected] manually roll flutter and fix flaky
video player test that is preventing roll from landing
(flutter/packages#13465)
2026-10-27 [email protected] [material_ui]
Unskip web tests that pass on CanvasKit and Skwasm: data_table_test,
floating_action_button_test, text_field_cursor_test
(flutter/packages#13460)
2026-10-27 [email protected] [material_ui] Decouple
disabled CheckboxListTile state in a11y_assessments
(flutter/packages#13177)
2026-10-27 [email protected] [camera_web] Skip video input
devices that cannot be started in availableCameras
(flutter/packages#13196)
2026-10-27 [email protected] [camera] Add support for
zero-shutter-lag capture (flutter/packages#12374)
2026-10-27 [email protected] [in_app_purchase_storekit} Fix more test
flakes (flutter/packages#13279)
2026-10-27 [email protected] [material_ui]
Refactor `typography.dart` and `text_theme.dart` in preparation for M3E
(flutter/packages#13371)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hellohuanlin hellohuanlin hellohuanlin approved these changes
@tarrinneal tarrinneal Awaiting requested review from tarrinneal
@LongCatIsLooong LongCatIsLooong Awaiting requested review from LongCatIsLooong
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD missing-tests override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: google_maps_flutter p: pigeon p: webview_flutter platform-ios test-exempt Exempt from tests. Overrides `missing-tests` label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Xcode 27] google_maps_flutter_ios_sdk9/sdk10 and webview_flutter_wkwebview example apps fail to launch on iOS 27 (UIScene life cycle required)

3 participants

@LouiseHsu @vashworth @hellohuanlin