Repository navigation
[google_sign_in] Remove the public iOS handleOpen helper - #13273
Merged
auto-submit[bot] merged 1 commit intoOct 15, 2026
Merged
auto-submit[bot] merged 1 commit into
auto-submit[bot] merged 1 commit into
Conversation
On macOS handleOpen stays public as the FlutterAppLifecycleDelegate witness.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request restricts the visibility of the handleOpen helper method on iOS by renaming it to the internal handleOpenURLs method and updating corresponding tests and call sites. On macOS, handleOpen remains public under a conditional compilation block to implement FlutterAppLifecycleDelegate. There are no review comments, so no feedback is provided.
hellohuanlin
approved these changes
Oct 15, 2026
victogomez-cs
added
the
autosubmit
gmackall
pushed a commit
to gmackall/flutter
that referenced
this pull request
Oct 16, 2026
flutter/packages@da40eaf...93eede7 2026-10-16 [email protected] [camera]fix a crash when switching camera while recording due to disconnected capturePhotoOputput (flutter/packages#13248) 2026-10-16 [email protected] [various] Update iOS example apps to the 15.0 deployment target (flutter/packages#13223) 2026-10-16 [email protected] [material_ui] Add M3E `IconButton` example (flutter/packages#13085) 2026-10-15 [email protected] [ci] Increase deprecation check minimum to iOS 16 (flutter/packages#13211) 2026-10-15 [email protected] [google_sign_in] Remove the public iOS handleOpen helper (flutter/packages#13273) 2026-10-15 [email protected] [google_fonts] Make the pendingFonts test deterministic (flutter/packages#13262) 2026-10-15 [email protected] [vector_graphics_compiler] Fix tspan transform applied twice (flutter/packages#13129) 2026-10-15 [email protected] Roll Flutter from 426be96 to 5c7e45a (21 revisions) (flutter/packages#13270) 2026-10-15 [email protected] [flutter_svg] Add golden widget tests for SVG alpha masks (flutter/packages#13245) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
flutter/packages@da40eaf...93eede7 2026-10-16 [email protected] [camera]fix a crash when switching camera while recording due to disconnected capturePhotoOputput (flutter/packages#13248) 2026-10-16 [email protected] [various] Update iOS example apps to the 15.0 deployment target (flutter/packages#13223) 2026-10-16 [email protected] [material_ui] Add M3E `IconButton` example (flutter/packages#13085) 2026-10-15 [email protected] [ci] Increase deprecation check minimum to iOS 16 (flutter/packages#13211) 2026-10-15 [email protected] [google_sign_in] Remove the public iOS handleOpen helper (flutter/packages#13273) 2026-10-15 [email protected] [google_fonts] Make the pendingFonts test deterministic (flutter/packages#13262) 2026-10-15 [email protected] [vector_graphics_compiler] Fix tspan transform applied twice (flutter/packages#13129) 2026-10-15 [email protected] Roll Flutter from 426be96 to 5c7e45a (21 revisions) (flutter/packages#13270) 2026-10-15 [email protected] [flutter_svg] Add golden widget tests for SVG alpha masks (flutter/packages#13245) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
handleOpena macOS-onlyFlutterAppLifecycleDelegatewitness and moves shared GID URL forwarding into an internal helper. On iOS, scene URL handling and tests call that helper directly, sohandleOpenis no longer part of the plugin's public API.The original Obj-C plugin did not expose this helper on iOS; it was added during the Swift migration.
Fixes flutter/flutter#194462
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, you can wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2