[google_sign_in] Convert the iOS example app and UI tests to Swift by victogomez-cs · Pull Request #13271 · flutter/packages

victogomez-cs · 2026-10-15T18:30:46Z

Converts the google_sign_in_ios iOS example runner and XCUITests from Objective-C to Swift. The plugin itself was already Swift-only after the earlier migration PRs.

GID URL schemes, Info.plist keys, and the existing RunnerTests target (shared darwin/Tests) are unchanged. Runner-Bridging-Header.h is required so the Swift AppDelegate can import Flutter's generated Objective-C GeneratedPluginRegistrant, matching url_launcher_ios and the app-facing google_sign_in example.

Bumps google_sign_in_ios to 6.3.8.

This is leftover example/UI-test work from the Obj-C → Swift migration. Completes flutter/flutter#119103 for the iOS example app.

Existing XCUITests were ported from Objective-C to Swift; no new behavior.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

gemini-code-assist

Code Review

This pull request migrates the iOS example app and UI tests for the google_sign_in plugin from Objective-C to Swift, including necessary updates to the project configuration and build settings. A review comment was provided identifying a potential runtime crash in the new Swift UI test code when checking for permission alert buttons, with a suggestion to use a guard statement for safer execution.

gemini-code-assist · 2026-10-15T18:33:00Z

+      if buttonCount == 0 {
+        XCTFail("Sign In permission alert has no buttons")
+      }
+      alertButtons.element(boundBy: buttonCount - 1).tap()


If buttonCount is 0, the test will call XCTFail, but execution will continue to the next line. Calling alertButtons.element(boundBy: buttonCount - 1) with an index of -1 will cause a runtime crash (index out of bounds) which can terminate the test runner process abruptly instead of cleanly reporting the failure.

Using a guard statement to return early prevents this crash.

Suggested change

if buttonCount == 0 {

XCTFail("Sign In permission alert has no buttons")

}

alertButtons.element(boundBy: buttonCount - 1).tap()

guard buttonCount > 0 else {

XCTFail("Sign In permission alert has no buttons")

return

}

alertButtons.element(boundBy: buttonCount - 1).tap()

Done. That XCTFail without return was a straight port of the Obj-C test. In Swift count is Int, so the next line would use index -1

…t before proceeding with tests

hellohuanlin · 2026-10-21T22:17:11Z

+  }
+
+  func testSignInPopUp() {
+    let app = self.app!


nit: you can do XCTUnwrap

Done. testSignInPopUp now uses try XCTUnwrap(self.app)

…ng test reliability.

flutter/packages@93baed9...108dad0 2026-10-22 [email protected] [material_ui] Migrate M3 IconButton template to use new gen_defaults (flutter/packages#12922) 2026-10-22 [email protected] [material_ui] Migrate M3 NavigationBar template to use new gen_defaults (flutter/packages#13067) 2026-10-22 [email protected] [material_ui] Remove obsolete `SurfaceTint` defaults template (flutter/packages#13276) 2026-10-22 [email protected] [material_ui] Migrate M3 Radio template to use new gen_defaults (flutter/packages#13210) 2026-10-22 [email protected] [material_ui] Migrate M3 NavigationDrawer template to use new gen_defaults (flutter/packages#13068) 2026-10-22 [email protected] [image_picker_ios] PR 3/5 Split SPM packaging and migrate the plugin class to Swift (flutter/packages#13235) 2026-10-22 [email protected] [ci] Increase check-discovery timeout in release workflows (flutter/packages#13392) 2026-10-22 [email protected] [material_ui] Migrate M3 `Switch` template to use new gen_defaults (flutter/packages#13274) 2026-10-22 [email protected] [material_ui] Migrate M3 PopupMenu template to use new gen_defaults (flutter/packages#13209) 2026-10-22 [email protected] [material_ui] Add day and weekday builders to CalendarDatePicker and showDatePicker (flutter/packages#12587) 2026-10-22 [email protected] [material_ui] Migrate M3 `SearchView` template to use new gen_defaults (flutter/packages#13272) 2026-10-22 [email protected] [material_ui] Migrate M3 `TextField` template to use new gen_defaults (flutter/packages#13275) 2026-10-22 [email protected] [material_ui] Migrate M3 RangeSlider template to use new gen_defaults (flutter/packages#13215) 2026-10-22 [email protected] [go_router] Keep web autocomplete focused in shell routes (flutter/packages#13348) 2026-10-22 [email protected] [shared_preferences_android] Fix web compilation of apps that import the package (flutter/packages#13380) 2026-10-22 [email protected] [material_ui] Migrate M3 NavigationRail template to use new gen_defaults (flutter/packages#13069) 2026-10-22 [email protected] [material_ui] Migrate M3 SearchBar template to use new gen_defaults (flutter/packages#13216) 2026-10-22 [email protected] [material_ui] Fix for time picker error in locales that do not use Latin digits (flutter/packages#13035) 2026-10-22 [email protected] [material_ui] Fix MenuAnchor scrollbar safe-area padding (flutter/packages#12470) 2026-10-22 [email protected] [material_ui] Document Material 3 fallback for Divider.color and VerticalDivider.color (flutter/packages#12967) 2026-10-22 [email protected] [material_ui] Migrate M3 tabs template to use new gen_defaults (flutter/packages#13139) 2026-10-22 [email protected] [material_ui] Migrate M3 progress indicator defaults to new gen_defaults (flutter/packages#13026) 2026-10-22 [email protected] [google_sign_in] Convert the iOS example app and UI tests to Swift (flutter/packages#13271) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter-dashboard Bot added the CICD Run CI/CD label Oct 15, 2026

github-actions Bot added p: google_sign_in platform-ios labels Oct 15, 2026

gemini-code-assist Bot reviewed Oct 15, 2026

View reviewed changes

victogomez-cs added the triage-ios Should be looked at in iOS triage label Oct 15, 2026

victogomez-cs added 2 commits October 15, 2026 15:26

[google_sign_in] Convert the iOS example app and UI tests to Swift.

7bd0693

Fix GoogleSignInUITests to ensure permission alert buttons are presen…

c3b33fc

…t before proceeding with tests

victogomez-cs force-pushed the google_sign_in_ios_swift_example branch from de9ff68 to c3b33fc Compare October 15, 2026 21:26

Piinks requested a review from elliette October 20, 2026 20:59

jmagman requested a review from hellohuanlin October 21, 2026 21:58

hellohuanlin approved these changes Oct 21, 2026

View reviewed changes

Update GoogleSignInUITests to use XCTUnwrap for app instance, enhanci…

4e71a87

…ng test reliability.

victogomez-cs added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 22, 2026

auto-submit Bot merged commit a64e51a into flutter:main Oct 22, 2026
13 checks passed

victogomez-cs deleted the google_sign_in_ios_swift_example branch October 22, 2026 21:28

engine-flutter-autoroll mentioned this pull request Oct 23, 2026

Roll Packages from 93baed9106f6 to 108dad0d562e (23 revisions) flutter/flutter#195161

Merged

Navigation Menu

Repository navigation

[google_sign_in] Convert the iOS example app and UI tests to Swift - #13271

[google_sign_in] Convert the iOS example app and UI tests to Swift#13271
auto-submit[bot] merged 3 commits into
flutter:mainfrom
victogomez-cs:google_sign_in_ios_swift_example

victogomez-cs commented Oct 15, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Oct 15, 2026

Uh oh!

victogomez-cs Oct 15, 2026

Uh oh!

hellohuanlin Oct 21, 2026

Uh oh!

victogomez-cs Oct 21, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

victogomez-cs commented Oct 15, 2026

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

victogomez-cs Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

hellohuanlin Oct 21, 2026

Choose a reason for hiding this comment

Uh oh!

victogomez-cs Oct 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants