Repository navigation
[camera_avfoundation] remove host app from iOS unit tests - #13246
LongCatIsLooong wants to merge 1 commit into
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the iOS test configuration for the camera_avfoundation example app. In project.pbxproj, it links FlutterGeneratedPluginSwiftPackage to the RunnerTests target, removes the target dependency on Runner, and updates build configurations to use standard .xcconfig files while removing BUNDLE_LOADER and TEST_HOST settings. It also disables building for testing in the Runner scheme and removes a conditional check in AppDelegate.swift that previously skipped plugin registration during unit tests. There are no review comments to address, and no further feedback is provided.
| LD_RUNPATH_SEARCH_PATHS = ( | ||
| "$(inherited)", | ||
| "$(LD_RUNPATH_SEARCH_PATHS_SHALLOW_BUNDLE_$(SHALLOW_BUNDLE))", | ||
| "@loader_path/..", |
There was a problem hiding this comment.
This is new since RunnerTests now has to load flutter.framework itself, instead of via the host application.
Remove the
Runnerdependency fromRunnerTestsand makeRunnerTestsa standalone test bundle.This allow us to remove the following code in the host app, since unit tests aren't dependent on the host app.
Also the tests should run faster since you don't have to boot up the host application to run them.
This does not touch the actual plugin code so I don't think this requires a version bump / changelog entry.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2