Repository navigation
[flutter_svg] Add golden widget tests for SVG alpha masks - #13245
Merged
auto-submit[bot] merged 2 commits intoOct 15, 2026
Merged
Conversation
edwin-hollen
force-pushed
the
upstream-svg-alpha-mask-goldens
branch
from
October 13, 2026 21:43
021aa09 to
7f2d556
Compare
edwin-hollen
marked this pull request as ready for review
October 13, 2026 21:43
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for SVG alpha masks (mask-type="alpha") to the flutter_svg package. It updates the package version to 2.3.1 and the vector_graphics_compiler dependency to ^1.3.1. Additionally, it includes new widget tests to verify the alpha mask functionality, covering opaque, semi-transparent, group opacity, and gradient scenarios. I have no feedback to provide.
Contributor
Author
|
@gaaclarke for visibility. Follow-up to #13025 with the |
gaaclarke
self-requested a review
October 13, 2026 21:47
github-actions
Bot
added
p: flutter_svg
triage-engine
gaaclarke
reviewed
Oct 14, 2026
gaaclarke
left a comment
gaaclarke
left a comment
Member
There was a problem hiding this comment.
wasn't there some images that need to be checked in too?
Contributor
Author
|
Hi Greg, I checked these in with #13025 under |
gaaclarke
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/packages/13245, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
b-luk
approved these changes
Oct 15, 2026
gmackall
pushed a commit
to gmackall/flutter
that referenced
this pull request
Oct 16, 2026
flutter/packages@da40eaf...93eede7 2026-10-16 [email protected] [camera]fix a crash when switching camera while recording due to disconnected capturePhotoOputput (flutter/packages#13248) 2026-10-16 [email protected] [various] Update iOS example apps to the 15.0 deployment target (flutter/packages#13223) 2026-10-16 [email protected] [material_ui] Add M3E `IconButton` example (flutter/packages#13085) 2026-10-15 [email protected] [ci] Increase deprecation check minimum to iOS 16 (flutter/packages#13211) 2026-10-15 [email protected] [google_sign_in] Remove the public iOS handleOpen helper (flutter/packages#13273) 2026-10-15 [email protected] [google_fonts] Make the pendingFonts test deterministic (flutter/packages#13262) 2026-10-15 [email protected] [vector_graphics_compiler] Fix tspan transform applied twice (flutter/packages#13129) 2026-10-15 [email protected] Roll Flutter from 426be96 to 5c7e45a (21 revisions) (flutter/packages#13270) 2026-10-15 [email protected] [flutter_svg] Add golden widget tests for SVG alpha masks (flutter/packages#13245) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
flutter/packages@da40eaf...93eede7 2026-10-16 [email protected] [camera]fix a crash when switching camera while recording due to disconnected capturePhotoOputput (flutter/packages#13248) 2026-10-16 [email protected] [various] Update iOS example apps to the 15.0 deployment target (flutter/packages#13223) 2026-10-16 [email protected] [material_ui] Add M3E `IconButton` example (flutter/packages#13085) 2026-10-15 [email protected] [ci] Increase deprecation check minimum to iOS 16 (flutter/packages#13211) 2026-10-15 [email protected] [google_sign_in] Remove the public iOS handleOpen helper (flutter/packages#13273) 2026-10-15 [email protected] [google_fonts] Make the pendingFonts test deterministic (flutter/packages#13262) 2026-10-15 [email protected] [vector_graphics_compiler] Fix tspan transform applied twice (flutter/packages#13129) 2026-10-15 [email protected] Roll Flutter from 426be96 to 5c7e45a (21 revisions) (flutter/packages#13270) 2026-10-15 [email protected] [flutter_svg] Add golden widget tests for SVG alpha masks (flutter/packages#13245) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds golden widget tests in
flutter_svgfor SVG alpha masks (mask-type="alpha"andstyle="mask-type:alpha") and bumps thevector_graphics_compilerdependency constraint to^1.3.1.Follow-up to #13025
Part of flutter/flutter#158734
Added Golden Tests
alpha_mask.opaque_style.png: Opaque#000000mask using inline CSSstyle="mask-type:alpha".alpha_mask.fill_opacity.png: Semi-transparent mask usingmask-type="alpha"andfill-opacity="0.5".alpha_mask.group_opacity.png: Group opacity inside an alpha mask (<mask mask-type="alpha"><g opacity="0.5">...</g></mask>).alpha_mask.gradient.png: Linear gradient alpha mask fadingstop-opacityfrom1to0.Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under[^1].CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under[^1].///).If you need help, consider asking for advice on the #hackers-new channel on Discord.