Repository navigation
[material_ui] Migrate M3 SegmentedButton template to use new gen_defaults - #13227
Merged
auto-submit[bot] merged 9 commits intoOct 23, 2026
Merged
auto-submit[bot] merged 9 commits into
auto-submit[bot] merged 9 commits into
Conversation
github-actions
Bot
added
p: material_ui
triage-design
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the generated Material 3 defaults for SegmentedButton to use the new SegmentedButtonTemplateM3 generator. It removes the inline _SegmentedButtonDefaultsM3 class from segmented_button.dart and references it as a part file generated by the tool. Additionally, it uncomments and implements the corresponding generator tests. Feedback suggests utilizing the already defined _theme field instead of calling Theme.of(context) again in the generated template, and updating the tests accordingly.
Contributor
|
Thank you for your contribution! Because of the volume of PRs we receive, we require that new contributors use our checklist to guide them through critical steps in creating a Flutter PR, and complete all of the items in the PR checklist above. Once all items have been checked, we will move forward on PR review. Thanks again. |
QuncCccccc
added
override: no versioning needed
Contributor
Author
|
hi! i updated the checklist, and everything is following the rules stablished such as styles, linter, ai, testing and changeling :) @QuncCccccc |
github-actions
Bot
removed
the
waiting for response
QuncCccccc
self-requested a review
October 15, 2026 23:24
QuncCccccc
reviewed
Oct 21, 2026
QuncCccccc
left a comment
QuncCccccc
left a comment
Contributor
There was a problem hiding this comment.
Looks really great with just one nit. Thanks so much for your contribution!
Crdzbird
force-pushed
the
material_ui-segmented-button-gen-defaults
branch
from
October 22, 2026 07:47
947e6ae to
3134ae9
Compare
QuncCccccc
added
CICD
elliette
approved these changes
Oct 22, 2026
elliette
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/packages/13227, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
…ed-button-gen-defaults
QuncCccccc
added
CICD
reginaldalfret
pushed a commit
to reginaldalfret/flutter
that referenced
this pull request
Oct 26, 2026
flutter/packages@108dad0...23a05b6 2026-10-23 [email protected] [video_player] Fix crash regression with async calls on iOS/macOS (flutter/packages#13383) 2026-10-23 [email protected] [material_ui] Migrate M3 SegmentedButton template to use new gen_defaults (flutter/packages#13227) 2026-10-23 [email protected] [material_ui] Migrate M3 Slider template to use new gen_defaults (flutter/packages#13195) 2026-10-23 [email protected] [material_ui] Migrate M3 BottomAppBar template to use new gen_defaults (flutter/packages#13385) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
flutter/packages@108dad0...23a05b6 2026-10-23 [email protected] [video_player] Fix crash regression with async calls on iOS/macOS (flutter/packages#13383) 2026-10-23 [email protected] [material_ui] Migrate M3 SegmentedButton template to use new gen_defaults (flutter/packages#13227) 2026-10-23 [email protected] [material_ui] Migrate M3 Slider template to use new gen_defaults (flutter/packages#13195) 2026-10-23 [email protected] [material_ui] Migrate M3 BottomAppBar template to use new gen_defaults (flutter/packages#13385) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work toward flutter/flutter#187899
Fixes flutter/flutter#188432
Migrates the M3 SegmentedButton template to the new
gen_defaults. The generated defaults are unchanged. The first commit only moves the files out oftemporarily_excluded/.The opacities in
resolveStateColornow come from the state layer tokens instead of being hard-coded, the values are the same.No version bump or changelog since there's no change for users, same as the other template migrations.
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2