Skip to content

[ci] Increase deprecation check minimum to macOS 26 - #13212

Draft
jmagman wants to merge 1 commit into
flutter:mainfrom
jmagman:mac-dep-26
Draft

jmagman wants to merge 1 commit into
flutter:mainfrom
jmagman:mac-dep-26

Conversation

@jmagman

@jmagman jmagman commented Oct 12, 2026

Copy link
Copy Markdown
Member

As of flutter/flutter#187762 the minimum is macOS 12, and this check is already higher. Increase to macOS 26 to see what's failing.

See previous bump at #7431

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@jmagman jmagman added the CICD Run CI/CD label Oct 12, 2026
@jmagman

jmagman commented Oct 12, 2026

Copy link
Copy Markdown
Member Author

The only failure is video_player_avfoundation
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8668113396588552241/+/u/Run_package_tests/xcode_analyze_deprecation/stdout

/Volumes/Work/s/w/ir/x/w/packages/packages/video_player/video_player_avfoundation/darwin/video_player_avfoundation/Sources/video_player_avfoundation_objc/FVPVideoPlayer.m:624:14: error: 'mediaSelectionGroupForMediaCharacteristic:' is deprecated: first deprecated in macOS 15.0 - Use loadMediaSelectionGroupForMediaCharacteristic:completionHandler: instead [-Werror,-Wdeprecated-declarations]
  624 |       [asset mediaSelectionGroupForMediaCharacteristic:AVMediaCharacteristicAudible];
      |              ^
In module 'AVFoundation' imported from /Volumes/Work/s/w/ir/x/w/packages/packages/video_player/video_player_avfoundation/darwin/video_player_avfoundation/Sources/video_player_avfoundation_objc/./include/video_player_avfoundation_objc/FVPVideoPlayer.h:5:
/Volumes/Work/s/w/ir/cache/osx_sdk/xcode_17c52/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX26.2.sdk/System/Library/Frameworks/AVFoundation.framework/Headers/AVAsset.h:389:1: note: 'mediaSelectionGroupForMediaCharacteristic:' has been explicitly marked deprecated here
  389 | - (nullable AVMediaSelectionGroup *)mediaSelectionGroupForMediaCharacteristic:(AVMediaCharacteristic)mediaCharacteristic
      | ^
/Volumes/Work/s/w/ir/x/w/packages/packages/video_player/video_player_avfoundation/darwin/video_player_avfoundation/Sources/video_player_avfoundation_objc/FVPVideoPlayer.m:672:14: error: 'mediaSelectionGroupForMediaCharacteristic:' is deprecated: first deprecated in macOS 15.0 - Use loadMediaSelectionGroupForMediaCharacteristic:completionHandler: instead [-Werror,-Wdeprecated-declarations]
  672 |       [asset mediaSelectionGroupForMediaCharacteristic:AVMediaCharacteristicAudible];
      |              ^
In module 'AVFoundation' imported from /Volumes/Work/s/w/ir/x/w/packages/packages/video_player/video_player_avfoundation/darwin/video_player_avfoundation/Sources/video_player_avfoundation_objc/./include/video_player_avfoundation_objc/FVPVideoPlayer.h:5:
/Volumes/Work/s/w/ir/cache/osx_sdk/xcode_17c52/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX26.2.sdk/System/Library/Frameworks/AVFoundation.framework/Headers/AVAsset.h:389:1: note: 'mediaSelectionGroupForMediaCharacteristic:' has been explicitly marked deprecated here
  389 | - (nullable AVMediaSelectionGroup *)mediaSelectionGroupForMediaCharacteristic:(AVMediaCharacteristic)mediaCharacteristic
      | ^

Which is about to be migrated to Swift: #13197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant