Skip to content

[ci] Increase deprecation check minimum to iOS 16 - #13211

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
jmagman:ios-dep
Oct 15, 2026
Merged

auto-submit[bot] merged 2 commits into
flutter:mainfrom
jmagman:ios-dep

Conversation

@jmagman

@jmagman jmagman commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

As of flutter/flutter#187741 the minimum is iOS 15. Check deprecation warnings for higher versions. Start with 16.

#13224 and #13222 have landed.

See previous bump at #7431
Fixes flutter/flutter#194245

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Oct 12, 2026
@jmagman
jmagman marked this pull request as draft October 12, 2026 20:49

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum iOS version from 14.0 to 16.0 in the arguments for the Xcode deprecation analysis task within the iOS platform tests configuration. There are no review comments, and I have no feedback to provide.

@jmagman jmagman changed the title Increase deprecation check minimum to iOS 16 [ci] Increase deprecation check minimum to iOS 16 Oct 12, 2026
@stuartmorgan

Copy link
Copy Markdown
Contributor

@jmagman

jmagman commented Oct 12, 2026

Copy link
Copy Markdown
Member Author

You'll hit https://github.com/flutter/packages/pull/13197/changes#diff-8e7e5c0acbc2629f7f4522d8409a01a45bb481a0dfc6cb79592f067b3cb00e29 from going past 15.

@stuartmorgan I know that one is about to be migrated to Swift through the next few PRs in this stack: #13079

And I didn't see flutter/flutter#105490 because of the exclusion

@jmagman

jmagman commented Oct 13, 2026

Copy link
Copy Markdown
Member Author

#13224

@jmagman
jmagman marked this pull request as ready for review October 14, 2026 21:45

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum iOS version from 14.0 to 16.0 in the arguments for the Xcode deprecation analysis task within the iOS platform tests configuration. There are no review comments, and I have no feedback to provide.

@jmagman

jmagman commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

I'll see how high I can get this (maybe 18?) but we can land it incrementally since it's passing in CI.

@stuartmorgan stuartmorgan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I would definitely vote for the incremental landing (but maybe that's just because it lets me pull the repo-level change out of #13197 so it won't run so many tests)

I'm confused though; why aren't all the iOS 16 deprecations you flagged in #13197 blocking going to 16 here?

@jmagman

jmagman commented Oct 15, 2026 •

Copy link
Copy Markdown
Member Author

I'm confused though; why aren't all the iOS 16 deprecations you flagged in #13197 blocking going to 16 here?

Seems like they aren't deprecated in Obj-C, just Swift:

@property (nonatomic, readonly) NSArray<AVAssetVariant *> *variants
#if __swift__
API_DEPRECATED("Use load(.variants) instead", macos(10.12, 13.0), ios(15.0, 16.0), tvos(15.0, 16.0), watchos(8.0, 9.0)) API_UNAVAILABLE(visionos);
#else
API_AVAILABLE(macos(12.0), ios(15.0), tvos(15.0), watchos(8.0), visionos(1.0));
#endif
- (AVKeyValueStatus)statusOfValueForKey:(NSString *)key error:(NSError * _Nullable * _Nullable)outError
#if __swift__
API_DEPRECATED("Use status(of:) instead", macos(10.7, 13.0), ios(4.2, 16.0), tvos(9.0, 16.0), watchos(1.0, 9.0)) API_UNAVAILABLE(visionos);
#else
API_AVAILABLE(macos(10.7), ios(4.2), tvos(9.0), watchos(1.0), visionos(1.0));
#endif

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 15, 2026
@auto-submit
auto-submit Bot merged commit 916d4c9 into flutter:main Oct 15, 2026
13 checks passed
@jmagman
jmagman deleted the ios-dep branch October 15, 2026 21:16
auto-submit Bot pushed a commit that referenced this pull request Oct 16, 2026
Checks in the iOS 15.0 deployment target for the example apps, so the tree matches what CI actually builds.

Xcode 27 only accepts iOS deployment targets of 15.0 and up. The CI side of that — the `--ios-min-version` flag on the `xcode analyze deprecation` step, which was the actual failure in the issue — has already landed in #13211 (it went to 16.0), so that file is no longer part of this PR.

What's left here is the example projects: 44 `example/ios/Runner.xcodeproj/project.pbxproj` files and the three remaining Podfiles still said 13.0 or 14.0. `flutter build ios` already rewrites these to 15.0 in place during `build examples` (the migration logs `Updating minimum iOS deployment target to 15.0.`), so CI was never building at 13.0; checking in the migrated values stops the files showing up as modified after a local build and makes the checked-in projects match Flutter's minimum. The stale "only supports back to iOS 14" comment in the google_maps_flutter example Podfile is replaced with the template's standard line.

Plugin minimums (podspec / `Package.swift`) are not changed here; that is a per-package decision like #13224 made for image_picker_ios.

Verified on Xcode 27 before #13211 landed, with this branch plus the Xcode 27 CI experiment config: shard 1 https://ci.chromium.org/b/8668096608488894433 and shards 2–5 https://ci.chromium.org/b/8668086846834062161, https://ci.chromium.org/b/8668086845504323249, https://ci.chromium.org/b/8668086844011129681, https://ci.chromium.org/b/8668086842838050321 — `build examples` no longer prints any migration lines and the analyze steps pass; the remaining `native test` failures in three of those are unrelated Xcode 27 issues (flutter/flutter#194284, flutter/flutter#194285).

Part of flutter/flutter#194019

## Pre-Review Checklist

Version/CHANGELOG: CI configuration and unpublished example project files only; no package code or published files change, so no version bumps (same as #11227).

Tests: CI config and project-file change only; no testable code.

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
gmackall pushed a commit to gmackall/flutter that referenced this pull request Oct 16, 2026
flutter/packages@da40eaf...93eede7

2026-10-16 [email protected] [camera]fix a
crash when switching camera while recording due to disconnected
capturePhotoOputput (flutter/packages#13248)
2026-10-16 [email protected] [various] Update iOS example apps to
the 15.0 deployment target (flutter/packages#13223)
2026-10-16 [email protected] [material_ui]
Add M3E `IconButton` example (flutter/packages#13085)
2026-10-15 [email protected] [ci] Increase deprecation check minimum to
iOS 16 (flutter/packages#13211)
2026-10-15 [email protected] [google_sign_in] Remove the
public iOS handleOpen helper (flutter/packages#13273)
2026-10-15 [email protected] [google_fonts] Make the pendingFonts
test deterministic (flutter/packages#13262)
2026-10-15 [email protected]
[vector_graphics_compiler] Fix tspan transform applied twice
(flutter/packages#13129)
2026-10-15 [email protected] Roll Flutter from
426be96 to 5c7e45a (21 revisions) (flutter/packages#13270)
2026-10-15 [email protected] [flutter_svg]
Add golden widget tests for SVG alpha masks (flutter/packages#13245)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
suryaKommana2662 pushed a commit to suryaKommana2662/flutter that referenced this pull request Oct 29, 2026
flutter/packages@da40eaf...93eede7

2026-10-16 [email protected] [camera]fix a
crash when switching camera while recording due to disconnected
capturePhotoOputput (flutter/packages#13248)
2026-10-16 [email protected] [various] Update iOS example apps to
the 15.0 deployment target (flutter/packages#13223)
2026-10-16 [email protected] [material_ui]
Add M3E `IconButton` example (flutter/packages#13085)
2026-10-15 [email protected] [ci] Increase deprecation check minimum to
iOS 16 (flutter/packages#13211)
2026-10-15 [email protected] [google_sign_in] Remove the
public iOS handleOpen helper (flutter/packages#13273)
2026-10-15 [email protected] [google_fonts] Make the pendingFonts
test deterministic (flutter/packages#13262)
2026-10-15 [email protected]
[vector_graphics_compiler] Fix tspan transform applied twice
(flutter/packages#13129)
2026-10-15 [email protected] Roll Flutter from
426be96 to 5c7e45a (21 revisions) (flutter/packages#13270)
2026-10-15 [email protected] [flutter_svg]
Add golden widget tests for SVG alpha masks (flutter/packages#13245)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[packages] Raise iOS min version for deprecation checks

2 participants