Repository navigation
[cupertino_ui] Document translucent default background of CupertinoSlidingSegmentedControl - #13178
Conversation
…idingSegmentedControl Ports flutter/flutter#186645.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
Bot
added
p: cupertino_ui
triage-design
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for CupertinoSlidingSegmentedControl to clarify that its default background color, CupertinoColors.tertiarySystemFill, is translucent to match the native iOS behavior. It also adds a corresponding changelog entry noting this documentation update. There are no review comments, and I have no feedback to provide.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If both you and the PR author believe this PR qualifies for a test exemption, escalate to the tech lead for the changed area to review and apply the |
| @@ -0,0 +1,2 @@ | |||
| changelog: Documents that the default background of CupertinoSlidingSegmentedControl is translucent. | |||
There was a problem hiding this comment.
I think this should probably follow the template format, even for a single item, so that it's formatted correctly and not merged with another item. That is...
changelog: |
- Documents that the default background of `CupertinoSlidingSegmentedControl` is translucent.
pjkammer
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/packages/13178, because - This pull request has the |
pjkammer
added
autosubmit
flutter/packages@13d38e0...0b72e92 2026-10-29 [email protected] [material_ui] Mirror the GappedSliderTrackShape secondary track correctly in RTL (flutter/packages#13226) 2026-10-29 [email protected] [pigeon] update jni dependency to ^1.1.1 and remove workaround proguard rules (flutter/packages#13464) 2026-10-28 [email protected] [cupertino_ui] Document translucent default background of CupertinoSlidingSegmentedControl (flutter/packages#13178) 2026-10-28 [email protected] [flutter_svg] Throw on non-2xx responses in SvgNetworkLoader (flutter/packages#13403) 2026-10-28 [email protected] [tool] Fix package matching logic for `--package-tags` filter (flutter/packages#13472) 2026-10-28 [email protected] Roll Flutter from d4c8577 to 0c2473c (21 revisions) (flutter/packages#13470) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fixes flutter/flutter#164073
Ports flutter/flutter#186645. Part of flutter/flutter#188444.
Documents that the default background of CupertinoSlidingSegmentedControl is translucent, so content behind unselected segments shows through unless an opaque color is passed. The original issue is flutter/flutter#164073. Tracking issue: flutter/flutter#188444.
cc @NadeemIqbal
Docs-only change, so this is test-exempt. I used AI assistance to port the approved documentation.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2