Repository navigation
[material_ui] Migrate M3 Time Picker template to use new gen_defaults - #13164
Merged
auto-submit[bot] merged 7 commits intoNov 3, 2026
Conversation
github-actions
Bot
added
p: material_ui
triage-design
Contributor
Author
|
Like the other PRs migrating to use the new gen_defaults, this doesn't require a version and changelog |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the Material 3 TimePicker defaults generation to the token-based template system. It extracts the _TimePickerDefaultsM3 class from time_picker.dart into a generated file, updates time_picker_template.dart to utilize TokenTimePicker tokens, enables the generator script, and adds corresponding tests. There are no review comments, so I have no feedback to provide.
ValentinVignal
force-pushed
the
material-ui/Move-time-picker-template-out-of-temporarily-excluded
branch
from
October 14, 2026 08:25
f8d3ee6 to
d4a7d48
Compare
QuncCccccc
reviewed
Oct 15, 2026
QuncCccccc
added
override: no versioning needed
QuncCccccc
force-pushed
the
material-ui/Move-time-picker-template-out-of-temporarily-excluded
branch
from
October 15, 2026 22:37
d4a7d48 to
03cef86
Compare
ValentinVignal
force-pushed
the
material-ui/Move-time-picker-template-out-of-temporarily-excluded
branch
from
October 21, 2026 18:22
03cef86 to
0c2d00e
Compare
QuncCccccc
self-requested a review
October 21, 2026 19:15
QuncCccccc
reviewed
Oct 22, 2026
Comment on lines
10
to
15
| @@ -20,10 +15,16 @@ class TimePickerTemplate extends TokenTemplate { | |||
| static const String variant = ''; | |||
Contributor
There was a problem hiding this comment.
These are unused anymore. Let's remove them.
Comment on lines
+54
to
+55
| // import '../templates/time_picker_template.dart'; | ||
| import '../templates/time_picker_template.dart'; |
Contributor
There was a problem hiding this comment.
These 2 lines are duplicated. Please remove one.
Contributor
Author
There was a problem hiding this comment.
Oops, sorry about that, fixed in Remove commented duplicated import
ValentinVignal
force-pushed
the
material-ui/Move-time-picker-template-out-of-temporarily-excluded
branch
from
October 28, 2026 07:03
0c2d00e to
c9c06f2
Compare
QuncCccccc
approved these changes
Nov 3, 2026
QuncCccccc
left a comment
QuncCccccc
left a comment
Contributor
There was a problem hiding this comment.
LGTM with just one more comment! Thanks a lot!
| @override | ||
| double get elevation { | ||
| return ${elevation("$tokenGroup.container")}; | ||
| return ${number(TokenTimePicker.containerElevation)}; |
Contributor
There was a problem hiding this comment.
No need to wrap numeric tokens in number(...) — interpolating ${TokenTimePicker.containerElevation} directly produces the exact same output and can make code simpler and cleaner (same for the other number(...) calls in this file).
Contributor
Author
There was a problem hiding this comment.
Sure! I removed it in Remove usages or number
# Conflicts: # packages/material_ui/tool/gen_defaults/bin/gen_defaults.dart
ValentinVignal
force-pushed
the
material-ui/Move-time-picker-template-out-of-temporarily-excluded
branch
from
November 3, 2026 08:11
c9c06f2 to
aacbfe0
Compare
elliette
approved these changes
Nov 3, 2026
elliette
added
the
autosubmit
jpohhhh
pushed a commit
to Telosnex/flutter
that referenced
this pull request
Nov 4, 2026
flutter/packages@1df8447...670b30e 2026-11-04 [email protected] [material_ui] Inherit `IconButtonThemeData.variant` from enclosing themes (flutter/packages#13263) 2026-11-04 [email protected] [tool] Regenerate `MockGitDir` for `package:git` 2.5.0 (flutter/packages#13544) 2026-11-03 [email protected] [material_ui] Fix discrete Slider selecting the neighboring tick near the track ends (flutter/packages#12927) 2026-11-03 [email protected] [material_ui] Migrate M3 Time Picker template to use new gen_defaults (flutter/packages#13164) 2026-11-03 [email protected] [camera_android_camerax] Update skills_lint to 0.5.3 (flutter/packages#13530) 2026-11-03 [email protected] Roll Flutter from fcfb4f2 to 9347202 (38 revisions) (flutter/packages#13540) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work toward flutter/flutter#187899.
Fixes flutter/flutter#188439
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2