Repository navigation
[material_ui] Fix installing command material UI - #13135
Merged
auto-submit[bot] merged 1 commit intoOct 17, 2026
Merged
auto-submit[bot] merged 1 commit into
auto-submit[bot] merged 1 commit into
Conversation
ahmedsameha1
force-pushed
the
fix_installing_command_material_ui
branch
from
October 5, 2026 18:11
58f85f9 to
ea999e0
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the installation command in the README to use flutter pub add and adds widget tests to verify that various Material UI components (ButtonBar, FilterChip, MaterialButton, MergeableMaterial, and RawMaterialButton) do not crash when rendered with zero area. There are no review comments, so I have no feedback to provide.
github-actions
Bot
added
p: material_ui
triage-design
QuncCccccc
changed the title
QuncCccccc
reviewed
Oct 9, 2026
QuncCccccc
left a comment
QuncCccccc
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot for the fix! Could you add a CHANGELOG entry for this change:)?
ahmedsameha1
force-pushed
the
fix_installing_command_material_ui
branch
from
October 10, 2026 13:54
ea999e0 to
1a85cd8
Compare
QuncCccccc
reviewed
Oct 14, 2026
| - Introduces labelTextDirection property to InputDecoration. | ||
| - Adds support for standard, medium, and high contrast Material 3 color scheme baselines. | ||
| - Fixes LocalHistoryEntry leak when double tapping Drawer scrim | ||
| - Fixes the installation command in README.md |
Contributor
There was a problem hiding this comment.
material_ui and cupertino_ui use batch release, so each PR should have a pending_changelog entry and every release will batch the pending entries together. So we should not directly edit CHANGELOG.md.
Please follow the "The flutter/packages changelog file" section in flutter/flutter#188444 to add an entry for this PR:)
ahmedsameha1
force-pushed
the
fix_installing_command_material_ui
branch
from
October 15, 2026 11:07
1a85cd8 to
f952234
Compare
QuncCccccc
reviewed
Oct 15, 2026
| @@ -0,0 +1,3 @@ | |||
| changelog: | | |||
| - Fixes the installation command in README.md | |||
| version: <1.5.0> | |||
Contributor
There was a problem hiding this comment.
Here should be "patch". Please see the template here
justinmc
reviewed
Oct 15, 2026
justinmc
left a comment
justinmc
left a comment
Contributor
There was a problem hiding this comment.
Good catch! +1 to Qun's comment about the yaml format.
ahmedsameha1
force-pushed
the
fix_installing_command_material_ui
branch
from
October 16, 2026 04:18
f952234 to
0ebe0a1
Compare
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If both you and the PR author believe this PR qualifies for a test exemption, escalate to the tech lead for the changed area to review and apply the |
QuncCccccc
approved these changes
Oct 16, 2026
QuncCccccc
left a comment
QuncCccccc
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you for the fix!
Contributor
|
Requested test-exemption https://discord.com/channels/608014603317936148/608018585025118217/1560733533159424111. Once we get it, we are good to land. |
8 tasks done
Contributor
|
We do not need test-exempt for this kind of changes. Discussion is in the discord thread above. So I'm submitting this PR. |
QuncCccccc
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/packages/13135, because - This pull request has the |
QuncCccccc
added
autosubmit
opensource-fork-sync Bot
pushed a commit
to cla7aye15I4nd/opensource-flutter__flutter
that referenced
this pull request
Oct 19, 2026
flutter/packages@93eede7...10a178c 2026-10-19 [email protected] [material_ui] Fixes SearchAnchor and SearchBar semantics (flutter/packages#12680) 2026-10-17 [email protected] [shared_preferences] switch to ffi/jni pigeon (flutter/packages#12329) 2026-10-17 [email protected] [in_app_purchase_storekit] Add show manage subscriptions path (flutter/packages#12454) 2026-10-17 [email protected] [material_ui] Fix installing command material UI (flutter/packages#13135) 2026-10-16 [email protected] [file_selector_ios] Drop deprecated UIDocumentPickerMode code path (flutter/packages#13292) 2026-10-16 [email protected] [camera_avfoundation] Fixes sendability mismatch in completion handler (flutter/packages#13298) 2026-10-16 [email protected] [local_auth_darwin] Fix Swift 6 concurrency analyzer errors from lifecycle delegate methods (flutter/packages#13296) 2026-10-16 [email protected] [pointer_interceptor_ios] Use 'let' for unmutated var (flutter/packages#13297) 2026-10-16 [email protected] [image_picker_ios] Fix Swift warnings in ImagePickerPluginTests (flutter/packages#13299) 2026-10-16 [email protected] [camera]delete fake bitrate/fps integration tests (flutter/packages#13291) 2026-10-16 [email protected] [google_maps_flutter_ios] Use 'let' for unmutated var (flutter/packages#13300) 2026-10-16 [email protected] [VPAT] Declare input purpose on a11y_assessments text fields (flutter/packages#13243) 2026-10-16 [email protected] [cupertino_ui] Fix CupertinoMagnifier focalPointOffset animation scaling (flutter/packages#13118) 2026-10-16 [email protected] [tool] Exempt `test_apps/` from version and changelog checks (flutter/packages#13255) 2026-10-16 [email protected] [material_ui] Fallback theme follows platform cherry pick (flutter/packages#13278) 2026-10-16 [email protected] Roll Flutter from 5c7e45a to a3d71d8 (26 revisions) (flutter/packages#13290) 2026-10-16 [email protected] [camera]do not sleep to avoid hang due to merged thread (flutter/packages#13289) 2026-10-16 [email protected] [camera]fix camera failure due to wrong jpg extension (flutter/packages#13285) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
flutter/packages@93eede7...10a178c 2026-10-19 [email protected] [material_ui] Fixes SearchAnchor and SearchBar semantics (flutter/packages#12680) 2026-10-17 [email protected] [shared_preferences] switch to ffi/jni pigeon (flutter/packages#12329) 2026-10-17 [email protected] [in_app_purchase_storekit] Add show manage subscriptions path (flutter/packages#12454) 2026-10-17 [email protected] [material_ui] Fix installing command material UI (flutter/packages#13135) 2026-10-16 [email protected] [file_selector_ios] Drop deprecated UIDocumentPickerMode code path (flutter/packages#13292) 2026-10-16 [email protected] [camera_avfoundation] Fixes sendability mismatch in completion handler (flutter/packages#13298) 2026-10-16 [email protected] [local_auth_darwin] Fix Swift 6 concurrency analyzer errors from lifecycle delegate methods (flutter/packages#13296) 2026-10-16 [email protected] [pointer_interceptor_ios] Use 'let' for unmutated var (flutter/packages#13297) 2026-10-16 [email protected] [image_picker_ios] Fix Swift warnings in ImagePickerPluginTests (flutter/packages#13299) 2026-10-16 [email protected] [camera]delete fake bitrate/fps integration tests (flutter/packages#13291) 2026-10-16 [email protected] [google_maps_flutter_ios] Use 'let' for unmutated var (flutter/packages#13300) 2026-10-16 [email protected] [VPAT] Declare input purpose on a11y_assessments text fields (flutter/packages#13243) 2026-10-16 [email protected] [cupertino_ui] Fix CupertinoMagnifier focalPointOffset animation scaling (flutter/packages#13118) 2026-10-16 [email protected] [tool] Exempt `test_apps/` from version and changelog checks (flutter/packages#13255) 2026-10-16 [email protected] [material_ui] Fallback theme follows platform cherry pick (flutter/packages#13278) 2026-10-16 [email protected] Roll Flutter from 5c7e45a to a3d71d8 (26 revisions) (flutter/packages#13290) 2026-10-16 [email protected] [camera]do not sleep to avoid hang due to merged thread (flutter/packages#13289) 2026-10-16 [email protected] [camera]fix camera failure due to wrong jpg extension (flutter/packages#13285) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit Bot
pushed a commit
to flutter/cocoon
that referenced
this pull request
Nov 4, 2026
…5167) Batch release packages in flutter/packages add changelog entries as YAML files under `<package>/pending_changelogs/` instead of editing `CHANGELOG.md`. Like all `.md` files, `CHANGELOG.md` is already exempt from the test requirement, but pending changelog entries weren't. So PRs that wouldn't otherwise need tests, such as README-only or comment-only changes, got the `missing-tests` label and needed a manual test exemption. For example, flutter/packages#13135 only changes a README and adds a pending changelog entry. This skips files under `pending_changelogs/` in the flutter/packages test check, the same way `.ci/` files are already skipped. Fixes flutter/flutter#191744
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#193843.