Repository navigation
[cupertino_ui] Fix CupertinoMagnifier focalPointOffset animation scaling - #13118
Merged
auto-submit[bot] merged 5 commits intoOct 16, 2026
Merged
auto-submit[bot] merged 5 commits into
auto-submit[bot] merged 5 commits into
Conversation
github-actions
Bot
added
p: cupertino_ui
triage-design
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the focal point offset calculation in CupertinoMagnifier to correctly scale with the animation value, adds a widget test to verify this behavior, and includes a changelog entry. Review feedback suggests optimizing the offset calculation by constructing the final Offset directly to avoid intermediate object allocations.
dkwingsmt
reviewed
Oct 12, 2026
dkwingsmt
added
the
autosubmit
opensource-fork-sync Bot
pushed a commit
to cla7aye15I4nd/opensource-flutter__flutter
that referenced
this pull request
Oct 19, 2026
flutter/packages@93eede7...10a178c 2026-10-19 [email protected] [material_ui] Fixes SearchAnchor and SearchBar semantics (flutter/packages#12680) 2026-10-17 [email protected] [shared_preferences] switch to ffi/jni pigeon (flutter/packages#12329) 2026-10-17 [email protected] [in_app_purchase_storekit] Add show manage subscriptions path (flutter/packages#12454) 2026-10-17 [email protected] [material_ui] Fix installing command material UI (flutter/packages#13135) 2026-10-16 [email protected] [file_selector_ios] Drop deprecated UIDocumentPickerMode code path (flutter/packages#13292) 2026-10-16 [email protected] [camera_avfoundation] Fixes sendability mismatch in completion handler (flutter/packages#13298) 2026-10-16 [email protected] [local_auth_darwin] Fix Swift 6 concurrency analyzer errors from lifecycle delegate methods (flutter/packages#13296) 2026-10-16 [email protected] [pointer_interceptor_ios] Use 'let' for unmutated var (flutter/packages#13297) 2026-10-16 [email protected] [image_picker_ios] Fix Swift warnings in ImagePickerPluginTests (flutter/packages#13299) 2026-10-16 [email protected] [camera]delete fake bitrate/fps integration tests (flutter/packages#13291) 2026-10-16 [email protected] [google_maps_flutter_ios] Use 'let' for unmutated var (flutter/packages#13300) 2026-10-16 [email protected] [VPAT] Declare input purpose on a11y_assessments text fields (flutter/packages#13243) 2026-10-16 [email protected] [cupertino_ui] Fix CupertinoMagnifier focalPointOffset animation scaling (flutter/packages#13118) 2026-10-16 [email protected] [tool] Exempt `test_apps/` from version and changelog checks (flutter/packages#13255) 2026-10-16 [email protected] [material_ui] Fallback theme follows platform cherry pick (flutter/packages#13278) 2026-10-16 [email protected] Roll Flutter from 5c7e45a to a3d71d8 (26 revisions) (flutter/packages#13290) 2026-10-16 [email protected] [camera]do not sleep to avoid hang due to merged thread (flutter/packages#13289) 2026-10-16 [email protected] [camera]fix camera failure due to wrong jpg extension (flutter/packages#13285) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
flutter/packages@93eede7...10a178c 2026-10-19 [email protected] [material_ui] Fixes SearchAnchor and SearchBar semantics (flutter/packages#12680) 2026-10-17 [email protected] [shared_preferences] switch to ffi/jni pigeon (flutter/packages#12329) 2026-10-17 [email protected] [in_app_purchase_storekit] Add show manage subscriptions path (flutter/packages#12454) 2026-10-17 [email protected] [material_ui] Fix installing command material UI (flutter/packages#13135) 2026-10-16 [email protected] [file_selector_ios] Drop deprecated UIDocumentPickerMode code path (flutter/packages#13292) 2026-10-16 [email protected] [camera_avfoundation] Fixes sendability mismatch in completion handler (flutter/packages#13298) 2026-10-16 [email protected] [local_auth_darwin] Fix Swift 6 concurrency analyzer errors from lifecycle delegate methods (flutter/packages#13296) 2026-10-16 [email protected] [pointer_interceptor_ios] Use 'let' for unmutated var (flutter/packages#13297) 2026-10-16 [email protected] [image_picker_ios] Fix Swift warnings in ImagePickerPluginTests (flutter/packages#13299) 2026-10-16 [email protected] [camera]delete fake bitrate/fps integration tests (flutter/packages#13291) 2026-10-16 [email protected] [google_maps_flutter_ios] Use 'let' for unmutated var (flutter/packages#13300) 2026-10-16 [email protected] [VPAT] Declare input purpose on a11y_assessments text fields (flutter/packages#13243) 2026-10-16 [email protected] [cupertino_ui] Fix CupertinoMagnifier focalPointOffset animation scaling (flutter/packages#13118) 2026-10-16 [email protected] [tool] Exempt `test_apps/` from version and changelog checks (flutter/packages#13255) 2026-10-16 [email protected] [material_ui] Fallback theme follows platform cherry pick (flutter/packages#13278) 2026-10-16 [email protected] Roll Flutter from 5c7e45a to a3d71d8 (26 revisions) (flutter/packages#13290) 2026-10-16 [email protected] [camera]do not sleep to avoid hang due to merged thread (flutter/packages#13289) 2026-10-16 [email protected] [camera]fix camera failure due to wrong jpg extension (flutter/packages#13285) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#193767
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2