[material_ui] Migrate M3 progress indicator defaults to new gen_defaults by fkrhzbllh · Pull Request #13026 · flutter/packages

fkrhzbllh · 2026-09-26T08:38:47Z

Pre-Review Checklist

fluttergithubbot · 2026-09-27T06:33:20Z

An existing Git SHA, ee3f6b8b2d423e8e1c75ed11e193a4744ab95612, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

QuncCccccc · 2026-10-05T20:17:15Z

Hi! Thanks a lot for your contribution! I noticed this draft PR when I'm working on flutter/flutter#187899. Just wanted to ask whether this is ready to review:)?

gemini-code-assist

Code Review

This pull request refactors the Material 3 progress indicator defaults generation by splitting the single generated file into separate circular and linear progress indicator defaults, updating the generation template, and adding corresponding tests. Feedback suggests deleting the now-unused progress_indicator_defaults_m3.g.dart file to prevent orphaned files, and performing division calculations at generation time within the template rather than emitting division expressions in the generated code, along with updating the tests to match.

gemini-code-assist · 2026-10-06T02:22:38Z

+  double get linearMinHeight => ${number(TokenProgressIndicatorLinear.trackThickness)};
+
+  @override
+  BorderRadius get borderRadius => const BorderRadius.all(Radius.circular(${number(TokenProgressIndicatorLinear.trackThickness)} / 2));


We can perform the division by 2 at generation time instead of generating the division expression 4.0 / 2 in the output file. This keeps the generated code cleaner and avoids unnecessary compile-time/runtime division.

Suggested change

BorderRadius get borderRadius => const BorderRadius.all(Radius.circular(${number(TokenProgressIndicatorLinear.trackThickness)} / 2));

BorderRadius get borderRadius => const BorderRadius.all(Radius.circular(${number(TokenProgressIndicatorLinear.trackThickness) / 2}));

fkrhzbllh · 2026-10-06T02:32:57Z

Yes, please. Thanks!

QuncCccccc · 2026-10-06T03:21:13Z

I think we should add part of '../progress_indicator.dart'; in this file and remove the new packages/material_ui/lib/src/generated/linear_progress_indicator_defaults_m3.g.dart and packages/material_ui/lib/src/generated/circular_progress_indicator_defaults_m3.g.dart. Right now we will have duplicated _LinearProgressIndicatorDefaultsM3 and _CircularProgressIndicatorDefaultsM3 but we should only keep one for each.

Something like this:

Ah, thanks for the review. I'll fix that

QuncCccccc

LGTM! Thank you for the migration.

QuncCccccc · 2026-10-07T21:59:33Z

+  Color? get circularTrackColor => indeterminate ? null : ${color(TokenProgressIndicator.trackColor)};
+
+  @override
+  double get strokeWidth => ${number(TokenProgressIndicatorCircular.trackThickness)};


nit: ${number(x)} and ${x} produces the same result. So we can remove number to make code simpler. Here and everywhere.

auto-submit · 2026-10-08T05:56:54Z

autosubmit label was removed for flutter/packages/13026, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

flutter/packages@93baed9...108dad0 2026-10-22 [email protected] [material_ui] Migrate M3 IconButton template to use new gen_defaults (flutter/packages#12922) 2026-10-22 [email protected] [material_ui] Migrate M3 NavigationBar template to use new gen_defaults (flutter/packages#13067) 2026-10-22 [email protected] [material_ui] Remove obsolete `SurfaceTint` defaults template (flutter/packages#13276) 2026-10-22 [email protected] [material_ui] Migrate M3 Radio template to use new gen_defaults (flutter/packages#13210) 2026-10-22 [email protected] [material_ui] Migrate M3 NavigationDrawer template to use new gen_defaults (flutter/packages#13068) 2026-10-22 [email protected] [image_picker_ios] PR 3/5 Split SPM packaging and migrate the plugin class to Swift (flutter/packages#13235) 2026-10-22 [email protected] [ci] Increase check-discovery timeout in release workflows (flutter/packages#13392) 2026-10-22 [email protected] [material_ui] Migrate M3 `Switch` template to use new gen_defaults (flutter/packages#13274) 2026-10-22 [email protected] [material_ui] Migrate M3 PopupMenu template to use new gen_defaults (flutter/packages#13209) 2026-10-22 [email protected] [material_ui] Add day and weekday builders to CalendarDatePicker and showDatePicker (flutter/packages#12587) 2026-10-22 [email protected] [material_ui] Migrate M3 `SearchView` template to use new gen_defaults (flutter/packages#13272) 2026-10-22 [email protected] [material_ui] Migrate M3 `TextField` template to use new gen_defaults (flutter/packages#13275) 2026-10-22 [email protected] [material_ui] Migrate M3 RangeSlider template to use new gen_defaults (flutter/packages#13215) 2026-10-22 [email protected] [go_router] Keep web autocomplete focused in shell routes (flutter/packages#13348) 2026-10-22 [email protected] [shared_preferences_android] Fix web compilation of apps that import the package (flutter/packages#13380) 2026-10-22 [email protected] [material_ui] Migrate M3 NavigationRail template to use new gen_defaults (flutter/packages#13069) 2026-10-22 [email protected] [material_ui] Migrate M3 SearchBar template to use new gen_defaults (flutter/packages#13216) 2026-10-22 [email protected] [material_ui] Fix for time picker error in locales that do not use Latin digits (flutter/packages#13035) 2026-10-22 [email protected] [material_ui] Fix MenuAnchor scrollbar safe-area padding (flutter/packages#12470) 2026-10-22 [email protected] [material_ui] Document Material 3 fallback for Divider.color and VerticalDivider.color (flutter/packages#12967) 2026-10-22 [email protected] [material_ui] Migrate M3 tabs template to use new gen_defaults (flutter/packages#13139) 2026-10-22 [email protected] [material_ui] Migrate M3 progress indicator defaults to new gen_defaults (flutter/packages#13026) 2026-10-22 [email protected] [google_sign_in] Convert the iOS example app and UI tests to Swift (flutter/packages#13271) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fkrhzbllh added 2 commits September 25, 2026 16:22

Move template/generated code out of temporarily_excluded directory

9e7b0b8

Migrate M3 progress indicator defaults to new gen_defaults

ee3f6b8

github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Sep 26, 2026

fkrhzbllh force-pushed the migrate-progress-indicator branch from 1c4ad93 to ee3f6b8 Compare September 27, 2026 06:28

fkrhzbllh closed this Sep 27, 2026

fkrhzbllh deleted the migrate-progress-indicator branch September 27, 2026 06:29

fkrhzbllh restored the migrate-progress-indicator branch September 27, 2026 06:31

fkrhzbllh reopened this Sep 27, 2026

Merge branch 'main' into migrate-progress-indicator

846970f

QuncCccccc added the CICD Run CI/CD label Sep 30, 2026

Merge branch 'main' into migrate-progress-indicator

6abdebe

flutter-dashboard Bot removed the CICD Run CI/CD label Oct 6, 2026

fkrhzbllh marked this pull request as ready for review October 6, 2026 02:20

gemini-code-assist Bot reviewed Oct 6, 2026

View reviewed changes

QuncCccccc added the CICD Run CI/CD label Oct 6, 2026

QuncCccccc reviewed Oct 6, 2026

View reviewed changes

Address feedback

66b4acd

flutter-dashboard Bot removed the CICD Run CI/CD label Oct 6, 2026

QuncCccccc self-requested a review October 6, 2026 21:16

QuncCccccc added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Oct 7, 2026

QuncCccccc approved these changes Oct 7, 2026

View reviewed changes

QuncCccccc added the CICD Run CI/CD label Oct 7, 2026

Merge branch 'flutter:main' into migrate-progress-indicator

a4c7084

flutter-dashboard Bot removed the CICD Run CI/CD label Oct 8, 2026

Address feedback

9d8c4eb

QuncCccccc added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Oct 8, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2026

QuncCccccc requested a review from elliette October 15, 2026 22:28

elliette approved these changes Oct 22, 2026

View reviewed changes

elliette added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 22, 2026

auto-submit Bot merged commit 9e9e3e9 into flutter:main Oct 22, 2026
14 checks passed

fkrhzbllh deleted the migrate-progress-indicator branch October 23, 2026 06:58

engine-flutter-autoroll mentioned this pull request Oct 23, 2026

Roll Packages from 93baed9106f6 to 108dad0d562e (23 revisions) flutter/flutter#195161

Merged

	BorderRadius get borderRadius => const BorderRadius.all(Radius.circular(${number(TokenProgressIndicatorLinear.trackThickness)} / 2));
	BorderRadius get borderRadius => const BorderRadius.all(Radius.circular(${number(TokenProgressIndicatorLinear.trackThickness) / 2}));

Conversation

fkrhzbllh commented Sep 26, 2026

Pre-Review Checklist

Uh oh!

fluttergithubbot commented Sep 27, 2026

Uh oh!

QuncCccccc commented Oct 5, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist Bot Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fkrhzbllh commented Oct 6, 2026

Uh oh!

QuncCccccc Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

fkrhzbllh Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

fkrhzbllh Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Oct 8, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants