Skip to content

[google_maps_flutter_platform_interface] Add map background color configuration - #13014

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
RyanHolanda:codex/google-maps-background-color-interface
Oct 8, 2026
Merged

auto-submit[bot] merged 1 commit into
flutter:mainfrom
RyanHolanda:codex/google-maps-background-color-interface

Conversation

@RyanHolanda

Copy link
Copy Markdown
Contributor

First landing PR for the background-color feature reviewed in #12357. This PR contains only the google_maps_flutter_platform_interface changes, as requested in the combined PR discussion.

Adds nullable MapConfiguration.backgroundColor, includes it in configuration diffing, equality, hashing, and legacy serialization, and adds tests for those contracts. Bumps the package to 2.18.0 and folds the existing NEXT minimum-SDK entry into that release.

The implementation and app-facing changes remain in #12357 and will be split into follow-up PRs after this package lands and is published. This is part of flutter/flutter#142520; the issue should remain open until the full feature lands.

Validation: repository formatter, analysis, Dart tests, validation, publish dry-run (zero warnings), and license check all pass.

Pre-Review Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the AI contribution guidelines and understand my responsibilities.
  • I read the Tree Hygiene page.
  • I ran the repository formatter and followed the relevant style guides.
  • I signed the CLA.
  • The title starts with the package name in brackets.
  • I linked the tracking issue above.
  • I updated the package version and CHANGELOG.
  • I added API documentation and tests.
  • All platform-interface tests pass.

@RyanHolanda

Copy link
Copy Markdown
Contributor Author

@stuartmorgan-g I opened the interface-only sub-PR from #12357 as you suggested. Could you review this first landing step when you have a chance?

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for configuring the background color displayed behind unloaded map tiles by introducing a backgroundColor property to MapConfiguration. It updates the serialization logic to include this property and adds corresponding unit tests to verify its behavior. There are no review comments, and I have no feedback to provide.

@stuartmorgan-g stuartmorgan-g added the CICD Run CI/CD label Sep 25, 2026

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarrinneal or @bparrishMines for secondary review

@bparrishMines bparrishMines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2026
@auto-submit
auto-submit Bot merged commit cedf32b into flutter:main Oct 8, 2026
13 checks passed
jmagman pushed a commit to jmagman/flutter that referenced this pull request Oct 9, 2026
flutter/packages@54706bd...d8d9e97

2026-10-09 [email protected] [pigeon] Reject unsupported native
interop features and fix generated code that doesn't compile
(flutter/packages#13153)
2026-10-09 [email protected] [material_ui] Fix
ExpansionTile WidgetSpan semantics assertion (flutter/packages#12765)
2026-10-08 [email protected] [in_app_purchase_storekit] Complete
StoreKit 2 `finish` when the transaction is not found
(flutter/packages#13037)
2026-10-08 [email protected] [video_player] Fix crash when
videoTrack has zero-duration minFrameDuration (flutter/packages#12796)
2026-10-08 [email protected]
[google_maps_flutter_platform_interface] Add map background color
configuration (flutter/packages#13014)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
suryaKommana2662 pushed a commit to suryaKommana2662/flutter that referenced this pull request Oct 29, 2026
flutter/packages@54706bd...d8d9e97

2026-10-09 [email protected] [pigeon] Reject unsupported native
interop features and fix generated code that doesn't compile
(flutter/packages#13153)
2026-10-09 [email protected] [material_ui] Fix
ExpansionTile WidgetSpan semantics assertion (flutter/packages#12765)
2026-10-08 [email protected] [in_app_purchase_storekit] Complete
StoreKit 2 `finish` when the transaction is not found
(flutter/packages#13037)
2026-10-08 [email protected] [video_player] Fix crash when
videoTrack has zero-duration minFrameDuration (flutter/packages#12796)
2026-10-08 [email protected]
[google_maps_flutter_platform_interface] Add map background color
configuration (flutter/packages#13014)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: google_maps_flutter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants