Repository navigation
[cupertino_ui] Remove useInheritedMediaQuery flag in CupertinoApp - #12970
AbdeMohlbi wants to merge 3 commits into
Conversation
github-actions
Bot
added
p: cupertino_ui
triage-design
…ion guide (#13916) This change adds `useInheritedMediaQuery` removal breaking change entry and migration guide. unblocks : - flutter/packages#12970 - flutter/packages#12969 - flutter/flutter#193146 _PRs or commits this PR depends on (if any):_ ## Presubmit checklist - [x] If you are unwilling, or unable, to sign the CLA, even for a _tiny_, one-word PR, please file an issue instead of a PR. - [x] If this PR is not meant to land until a future stable release, mark it as draft with an explanation. - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style)—for example, it doesn't use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first-person pronouns). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated useInheritedMediaQuery parameter and field from CupertinoApp, along with its associated tests, and adds a pending changelog entry. Feedback indicates that removing this public parameter is a breaking change, which requires updating the changelog version bump from minor to major.
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
LGTM once the changelog is fixed.
Updated version from minor to major due to removal of deprecated flag.
|
I'd like confirm with other team members how we process major version releases (since it's the first time we do it in design packages as far as I can remember) and I'll touch back about middle of next week. |
|
@AbdeMohlbi Are we not removing this property now? I was right in discussion of how to make major releases for this PR (and the material_ui one). |
Yes, even the website change |
blocked on:
useInheritedMediaQueryremoval breaking change entry and migration guide website#13916Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2