[material_ui] Migrate M3 IconButton template to use new gen_defaults by QuncCccccc · Pull Request #12922 · flutter/packages

QuncCccccc · 2026-09-18T02:13:54Z

Work toward flutter/flutter#187899.
Fixes flutter/flutter#188417.

This PR migrates the M3 IconButton defaults templates to use the new gen_defaults in material_ui.

The IconButton, IconButton.filled, IconButton.filledTonal, and IconButton.outlined defaults are generated into separate files. The generated defaults remain unchanged.

Pre-Review Checklist

…ults_migration # Conflicts: # packages/material_ui/lib/src/icon_button.dart # packages/material_ui/tool/gen_defaults/bin/gen_defaults.dart # packages/material_ui/tool/gen_defaults/templates/icon_button_template.dart # packages/material_ui/tool/gen_defaults/test/gen_defaults_test.dart

gemini-code-assist

Code Review

This pull request migrates the Material 3 icon button defaults to be generated from the token database using a new IconButtonTemplateM3 template, replacing the inline implementations in icon_button.dart with generated part files and adding corresponding tests. Feedback on the changes highlights a potential inconsistency in the outlined icon button's overlay color configuration, where the focused state blocks use hoveredStateLayerOpacity instead of focusedStateLayerOpacity, and suggests either correcting this or adding a comment if it was an intentional legacy workaround.

gemini-code-assist · 2026-10-02T23:30:14Z

+    if (states.contains(WidgetState.focused)) {
+      return ${colorWithOpacity(TokenIconButtonOutlined.selectedFocusedStateLayerColor, TokenIconButtonOutlined.hoveredStateLayerOpacity)};
+    }
+  }
+  if (states.contains(WidgetState.pressed)) {
+    return ${colorWithOpacity(TokenColorRole.onSurface, TokenIconButtonOutlined.pressedStateLayerOpacity)};
+  }
+  if (states.contains(WidgetState.hovered)) {
+    return ${colorWithOpacity(TokenIconButtonOutlined.unselectedHoveredStateLayerColor, TokenIconButtonOutlined.hoveredStateLayerOpacity)};
+  }
+  if (states.contains(WidgetState.focused)) {
+    return ${colorWithOpacity(TokenIconButtonOutlined.unselectedFocusedStateLayerColor, TokenIconButtonOutlined.hoveredStateLayerOpacity)};
+  }


In the _IconButtonVariant.outlined overlay color configuration, both focused state blocks (lines 257 and 267) are using TokenIconButtonOutlined.hoveredStateLayerOpacity instead of TokenIconButtonOutlined.focusedStateLayerOpacity.\n\nIf this was done intentionally to preserve the legacy 0.08 opacity (since standard focus opacity is typically 0.12), please add a comment explaining this workaround (similar to _legacyDisabledContainerOpacity). Otherwise, if TokenIconButtonOutlined.focusedStateLayerOpacity is available and correct, please use it here to maintain consistency with the other icon button variants.

Adding a documentation comment seems like a valid suggestion, wdyt?

Ah thanks for catching this! I should not use the hovered-state token for other states.

The current opacity tokens are out-of-date. I added a TODO to update the token value once we finished template migration!

elliette

LGTM!

elliette · 2026-10-22T00:01:58Z

+    if (states.contains(WidgetState.focused)) {
+      return ${colorWithOpacity(TokenIconButtonOutlined.selectedFocusedStateLayerColor, TokenIconButtonOutlined.hoveredStateLayerOpacity)};
+    }
+  }
+  if (states.contains(WidgetState.pressed)) {
+    return ${colorWithOpacity(TokenColorRole.onSurface, TokenIconButtonOutlined.pressedStateLayerOpacity)};
+  }
+  if (states.contains(WidgetState.hovered)) {
+    return ${colorWithOpacity(TokenIconButtonOutlined.unselectedHoveredStateLayerColor, TokenIconButtonOutlined.hoveredStateLayerOpacity)};
+  }
+  if (states.contains(WidgetState.focused)) {
+    return ${colorWithOpacity(TokenIconButtonOutlined.unselectedFocusedStateLayerColor, TokenIconButtonOutlined.hoveredStateLayerOpacity)};
+  }


Adding a documentation comment seems like a valid suggestion, wdyt?

flutter/packages@93baed9...108dad0 2026-10-22 [email protected] [material_ui] Migrate M3 IconButton template to use new gen_defaults (flutter/packages#12922) 2026-10-22 [email protected] [material_ui] Migrate M3 NavigationBar template to use new gen_defaults (flutter/packages#13067) 2026-10-22 [email protected] [material_ui] Remove obsolete `SurfaceTint` defaults template (flutter/packages#13276) 2026-10-22 [email protected] [material_ui] Migrate M3 Radio template to use new gen_defaults (flutter/packages#13210) 2026-10-22 [email protected] [material_ui] Migrate M3 NavigationDrawer template to use new gen_defaults (flutter/packages#13068) 2026-10-22 [email protected] [image_picker_ios] PR 3/5 Split SPM packaging and migrate the plugin class to Swift (flutter/packages#13235) 2026-10-22 [email protected] [ci] Increase check-discovery timeout in release workflows (flutter/packages#13392) 2026-10-22 [email protected] [material_ui] Migrate M3 `Switch` template to use new gen_defaults (flutter/packages#13274) 2026-10-22 [email protected] [material_ui] Migrate M3 PopupMenu template to use new gen_defaults (flutter/packages#13209) 2026-10-22 [email protected] [material_ui] Add day and weekday builders to CalendarDatePicker and showDatePicker (flutter/packages#12587) 2026-10-22 [email protected] [material_ui] Migrate M3 `SearchView` template to use new gen_defaults (flutter/packages#13272) 2026-10-22 [email protected] [material_ui] Migrate M3 `TextField` template to use new gen_defaults (flutter/packages#13275) 2026-10-22 [email protected] [material_ui] Migrate M3 RangeSlider template to use new gen_defaults (flutter/packages#13215) 2026-10-22 [email protected] [go_router] Keep web autocomplete focused in shell routes (flutter/packages#13348) 2026-10-22 [email protected] [shared_preferences_android] Fix web compilation of apps that import the package (flutter/packages#13380) 2026-10-22 [email protected] [material_ui] Migrate M3 NavigationRail template to use new gen_defaults (flutter/packages#13069) 2026-10-22 [email protected] [material_ui] Migrate M3 SearchBar template to use new gen_defaults (flutter/packages#13216) 2026-10-22 [email protected] [material_ui] Fix for time picker error in locales that do not use Latin digits (flutter/packages#13035) 2026-10-22 [email protected] [material_ui] Fix MenuAnchor scrollbar safe-area padding (flutter/packages#12470) 2026-10-22 [email protected] [material_ui] Document Material 3 fallback for Divider.color and VerticalDivider.color (flutter/packages#12967) 2026-10-22 [email protected] [material_ui] Migrate M3 tabs template to use new gen_defaults (flutter/packages#13139) 2026-10-22 [email protected] [material_ui] Migrate M3 progress indicator defaults to new gen_defaults (flutter/packages#13026) 2026-10-22 [email protected] [google_sign_in] Convert the iOS example app and UI tests to Swift (flutter/packages#13271) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

[material_ui] Migrate M3 IconButton template to use new gen_defaults

96d511f

github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Sep 18, 2026

QuncCccccc added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes CICD Run CI/CD labels Oct 2, 2026

QuncCccccc marked this pull request as ready for review October 2, 2026 23:28

gemini-code-assist Bot reviewed Oct 2, 2026

View reviewed changes

QuncCccccc requested a review from elliette October 6, 2026 21:27

SametDemirtas mentioned this pull request Oct 17, 2026

[material_ui] Add ThemeData.mouseCursor #13304

Open

11 tasks done

elliette approved these changes Oct 22, 2026

View reviewed changes

QuncCccccc added 2 commits October 22, 2026 21:17

address feedback

f15bfbc

address feedback

b3f8f99

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 22, 2026

auto-submit Bot merged commit 108dad0 into flutter:main Oct 22, 2026
13 checks passed

engine-flutter-autoroll mentioned this pull request Oct 23, 2026

Roll Packages from 93baed9106f6 to 108dad0d562e (23 revisions) flutter/flutter#195161

Merged

Navigation Menu

Repository navigation

[material_ui] Migrate M3 IconButton template to use new gen_defaults - #12922

[material_ui] Migrate M3 IconButton template to use new gen_defaults#12922
auto-submit[bot] merged 4 commits into
flutter:mainfrom
QuncCccccc:icon_button_m3_defaults_migration

QuncCccccc commented Sep 18, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Oct 2, 2026

Uh oh!

elliette Oct 22, 2026

Uh oh!

QuncCccccc Oct 22, 2026

Uh oh!

elliette left a comment

Uh oh!

elliette Oct 22, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

QuncCccccc commented Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Oct 2, 2026

Choose a reason for hiding this comment

Uh oh!

elliette Oct 22, 2026

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Oct 22, 2026

Choose a reason for hiding this comment

Uh oh!

elliette left a comment

Choose a reason for hiding this comment

Uh oh!

elliette Oct 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

QuncCccccc commented Sep 18, 2026 •

edited

Loading