Repository navigation
[image_picker] Remove unnecessary Material imports - #12803
ricardodalarme wants to merge 2 commits into
Conversation
e56f30e to
e449a0a
Compare
e449a0a to
97cb0c7
Compare
97cb0c7 to
0a153e2
Compare
|
@gaaclarke @walley892 essentially the same as the other one |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request decouples the image_picker_for_web package from Material and Cupertino imports, replacing them with standard widgets. However, it also replaces standard Flutter Material imports and dependencies with the third-party material_ui package across multiple example applications. The feedback requests reverting these changes to use the standard first-party Material library and removing the material_ui dependency.
0a153e2 to
bb19551
Compare
|
Hey @tarrinneal can I get your review pls? |
| ## NEXT | ||
|
|
||
| * Updates minimum supported SDK version to Flutter 3.41/Dart 3.11. | ||
| * Decouples from Material and Cupertino imports. |
There was a problem hiding this comment.
Nit: Since image_picker_for_web only had an unused material.dart import (no Cupertino imports), consider * Removes unnecessary Material imports. here to match #12798.
There was a problem hiding this comment.
This should probably be a major release. We have been bumping the major version for packages migrating over because they will no longer be backwards compatible if clients are still using Material and Cupertino from the SDK.
There was a problem hiding this comment.
I see... That is going to be a harsh transition for users. Makes me think we should do the whole repo at once
Removes unnecessary material imports from
image_pickerto decouple it from Material/Cupertino since they will eventually be removed from the core SDK. Also migrate the examples tomaterial_ui.Part of: flutter/flutter#191322
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2