[material_ui] Reduce the `material_ui` non-wasm web test suite by elliette · Pull Request #12763 · flutter/packages

elliette · 2026-09-04T21:36:14Z

Work towards flutter/flutter#192308

Introduce new --package-tags flag that can be used to specify which flags to filter a package's tests with. In the case of the web_dart_unit_tests, we specify that material_ui should filter on the new reduced_web_test_set tag.

Pre-Review Checklist

changelog exemption: only test/CI changes

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

gemini-code-assist

Code Review

This pull request adds support for a --package-tags option to the dart-test command in the repository tooling, enabling packages to run only tests matching a specified tag. The material_ui package is configured to run a reduced set of web tests using the reduced-web-test-set tag, and CI configurations are updated to utilize this new option. Feedback on the changes suggests handling cases where the package tags YAML file is empty or contains only comments to prevent a misleading error message when loadYaml returns null.

stuartmorgan-g

Overall, looks like a great feature!

stuartmorgan-g · 2026-09-08T19:56:08Z

 import 'common/repository_package.dart';

 const int _exitUnknownTestPlatform = 3;
+const int _exitNoTestsRan = 79;


Optional nit: We usually just increment these at a per-file level and don't worry about cross-file uniqueness. It doesn't really matter though.

This is actually here to match the exit code from test: https://github.com/dart-lang/test/blob/c80d53dbd489d61e0481fc484cd6f9a3b53603fb/pkgs/test_core/lib/src/util/exit_codes.dart#L58-L59

QuncCccccc

The tag coverage looks good! Thanks for the enhancement!

I randomly ran a test with the tag. The test can pass but has "Warning: A tag was used that wasn't specified in dart_test.yaml." Should we add this tag to a dart_test.yaml somewhere? I'm not super familiar with the .yaml file though.

…_ui: reduced-web-test-set)

QuncCccccc

LGTM. Thanks!

elliette · 2026-09-09T21:32:09Z

The tag coverage looks good! Thanks for the enhancement!

I randomly ran a test with the tag. The test can pass but has "Warning: A tag was used that wasn't specified in dart_test.yaml." Should we add this tag to a dart_test.yaml somewhere? I'm not super familiar with the .yaml file though.

I think the warning is benign but confusing. I've added the dart_test.yaml files so that we won't see it :)

@example

Roll Packages from c2b58e1 to 431ea69 (56 revisions) flutter/packages@c2b58e1...431ea69 2026-09-24 [email protected] [cross_file] Updates cross_file to a package separated federated plugin (flutter/packages#11010) 2026-09-23 [email protected] [material_ui] Remove static access of `copyWith` from `dart fix` golden tests for `ThemeData/TextTheme` (flutter/packages#12994) 2026-09-23 [email protected] [camera_avfoundation] Replace deprecated high-resolution capture APIs (flutter/packages#12372) 2026-09-23 [email protected] [pigeon] update nullish checks to use new isNullish method (flutter/packages#12985) 2026-09-23 [email protected] [ci] Assign batch release PR approver as reviewer on sync-back PR (flutter/packages#12976) 2026-09-23 [email protected] [image_picker] Fix scaling 10-bit images (flutter/packages#12557) 2026-09-23 [email protected] [material_ui] Improve Autocomplete, DrawerHeader, and Tooltip accessibility (flutter/packages#12918) 2026-09-23 [email protected] [google_fonts] Decouple GoogleFontsLite for full tree-shaking and add full feature parity (flutter/packages#12830) 2026-09-23 [email protected] [file_selector] Ignore flakey `file_selector_android` tests (flutter/packages#12992) 2026-09-23 [email protected] [CI] Remove bringup from `Mac_arm64 build_all_packages` targets (flutter/packages#12978) 2026-09-22 [email protected] [material_ui] Unskip 5 passing web tests in bottom_app_bar_test and text_field_test (flutter/packages#12983) 2026-09-22 [email protected] [cupertino_ui] Unskip 5 passing web tests in adaptive_text_selection_toolbar_test and text_field_test (flutter/packages#12984) 2026-09-22 [email protected] [go_router] Fix ShellRoute chrome dropped from semantics tree by ModalBarrier (flutter/packages#12353) 2026-09-22 [email protected] [material_ui] Add contrastLevel for M3 ColorScheme (flutter/packages#12743) 2026-09-22 [email protected] [go_router] Preserve nested pushes during config updates (flutter/packages#12611) 2026-09-22 [email protected] [material_ui] Migrate M3 Chip template to use new gen_defaults (flutter/packages#12847) 2026-09-22 [email protected] [material_ui] Fix LocalHistoryEntry leak when double tapping Drawer scrim (flutter/packages#12552) 2026-09-22 [email protected] Update suggested reviewers (flutter/packages#12974) 2026-09-22 [email protected] Sync release-material_ui-1.4.0 to main (flutter/packages#12966) 2026-09-22 [email protected] Sync release-cupertino_ui-1.1.1 to main (flutter/packages#12965) 2026-09-21 [email protected] [ci] Update repo for 3.47 stable release (flutter/packages#12959) 2026-09-21 [email protected] Manual roll Flutter from 27fec0e to 4fcd90b (1 revision) (flutter/packages#12904) 2026-09-21 [email protected] Revert "[go_router_builder] Migrate to material_ui" (flutter/packages#12962) 2026-09-21 [email protected] [material_ui] Update `material_ui` tests to prevent them from failing when framework `TextStyle` changes (flutter/packages#12728) 2026-09-21 [email protected] [go_router_builder] Migrate to material_ui (flutter/packages#12913) 2026-09-21 [email protected] [material_ui, cupertino_ui] Bump Flutter version from to 3.47 (flutter/packages#12944) 2026-09-21 [email protected] [cupertino_ui] Work around dart2wasm optional parameter inference bug in example checkbox tests (flutter/packages#12961) 2026-09-21 [email protected] [cupertino_ui] Work around dart2wasm optional parameter inference bug in checkbox_test.dart (flutter/packages#12956) 2026-09-21 [email protected] [google_sign_in] PR 3/4 Migrate ViewProvider and GID SDK wrappers from Objective-C to Swift (flutter/packages#12657) 2026-09-21 [email protected] [google_sign_in] PR 2/4 Migrate the plugin class from Objective-C to Swift. (flutter/packages#12655) 2026-09-20 [email protected] [cross_file_darwin] iOS/macOS implementation of `cross_file` (flutter/packages#12910) 2026-09-20 [email protected] [cross_file_web] Web implementation of `cross_file` (flutter/packages#12908) 2026-09-20 [email protected] [material_ui] Migrate M3 `InputChip` template to use new gen_defaults (flutter/packages#12850) 2026-09-20 [email protected] [material_ui] Migrate M3 Checkbox defaults to new gen_defaults (flutter/packages#12816) 2026-09-20 [email protected] [material_ui] Migrate M3 `FilterChip` template to use new gen_defaults (flutter/packages#12849) 2026-09-19 [email protected] [material_ui] Announce PopupMenuButton with a child as a button (flutter/packages#12585) 2026-09-19 [email protected] Roll Flutter (stable) from 9584c67 to 6a19cca (7 revisions) (flutter/packages#12950) 2026-09-18 [email protected] [material_ui] Reduce the `material_ui` non-wasm web test suite (flutter/packages#12763) 2026-09-18 [email protected] Replace `Mac_x64` builders with `Mac_arm64` ones (flutter/packages#12941) 2026-09-18 [email protected] [in_app_purchase_storekit] Use `_$SKPaymentDiscountWrapperToJson` (flutter/packages#12721) 2026-09-18 [email protected] [In_app _purchase] README excerpt examples and changelog (flutter/packages#12739) 2026-09-18 [email protected] [material_ui] Add alternative input method for `RangeSlider` in `NavigationMode.directional` (flutter/packages#12630) 2026-09-18 [email protected] [cross_file_android] Android implementation of `cross_file` (flutter/packages#12909) 2026-09-18 [email protected] [camera_platform_interface] Adds videoOutputPath support to startVideoRecording (flutter/packages#12667) 2026-09-17 [email protected] [cupertino_ui] Migrate a snippet in `CupertinoCheckbox`'s API doc to `{@example}` and add unit tests (flutter/packages#12180) 2026-09-17 [email protected] [material_ui] Default gen_defaults color helper prefix (flutter/packages#12848) ...

#12763 introduced a new `--package-tags` flag that can be used to specify which flags to filter a package's tests with. After some investigation, I realized it wasn't working on CI. This is because we were trying to match the package key set in the [YAML file](https://github.com/flutter/packages/blob/13d38e0d97a8e1227379f2887847bc178f22c73a/script/configs/web_dart_unit_test_tags.yaml#L5) (in this case `material_ui`) to [`RepositoryPackage.displayName`](https://github.com/flutter/packages/blob/9919dfd51491a82547033aa1a8aa9aa5a185c61c/script/tool/lib/src/common/repository_package.dart#L41) which removes everything in the path up to the first path component named `packages`. On CI, the repository is checked out into a directory named packages, so `RepositoryPackage.displayName` returned the package's path with a leading `packages/` (e.g. `packages/material_ui`). As a result, it never matched in CI. Tag lookup now uses `_packageTagKey`, which returns the package's path relative to the `packages/` directory that contains it (e.g. `material_ui`), regardless of where the repository is checked out. Work towards flutter/flutter#192308 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

elliette added the CICD Run CI/CD label Sep 4, 2026

github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Sep 4, 2026

elliette force-pushed the reduce-web-tests branch from cc973ff to f4fdda0 Compare September 4, 2026 22:45

elliette changed the title ~~[DRAFT] Reduce the material_ui web test suite~~ [material_ui] Reduce the material_ui web test suite Sep 4, 2026

elliette changed the title ~~[material_ui] Reduce the material_ui web test suite~~ [material_ui] Reduce the material_ui non-wasm web test suite Sep 4, 2026

elliette marked this pull request as ready for review September 4, 2026 23:11

gemini-code-assist Bot reviewed Sep 4, 2026

View reviewed changes

Comment thread script/tool/lib/src/dart_test_command.dart Resolved

stuartmorgan-g reviewed Sep 5, 2026

View reviewed changes

Comment thread script/tool/lib/src/dart_test_command.dart Resolved

stuartmorgan-g reviewed Sep 8, 2026

View reviewed changes

elliette requested a review from QuncCccccc September 8, 2026 20:09

QuncCccccc reviewed Sep 9, 2026

View reviewed changes

Comment thread packages/material_ui/test/icon_button_test.dart Resolved

Comment thread packages/material_ui/test/selection_area_test.dart Resolved

elliette added 5 commits September 9, 2026 13:59

Add package-tags flag to filter tests to specific flag (e.g. material…

163b30f

…_ui: reduced-web-test-set)

Tag material_ui web tests with reduce-web-test-set tag

e781101

Clean up

011d739

Respond to PR comments

91aeb26

Switch order of skip and tags

8fa3333

elliette force-pushed the reduce-web-tests branch from a6973ef to 8fa3333 Compare September 9, 2026 21:00

Add dart_test.yaml files

5cc6d83

QuncCccccc approved these changes Sep 9, 2026

View reviewed changes

elliette added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2026

auto-submit Bot merged commit 3fd2ab5 into flutter:main Sep 18, 2026
13 checks passed

engine-flutter-autoroll mentioned this pull request Sep 24, 2026

Roll Packages from c2b58e1a97fb to 431ea69a42e2 (56 revisions) flutter/flutter#193289

Merged

This was referenced Oct 28, 2026

[material_ui] Reduce web test suite flutter/flutter#192308

Open

[tool] Fix package matching logic for --package-tags filter #13472

Merged

elliette mentioned this pull request Oct 29, 2026

[material_ui] Update incorrect web test tags #13494

Open

11 tasks done

Navigation Menu

Repository navigation

[material_ui] Reduce the `material_ui` non-wasm web test suite - #12763

[material_ui] Reduce the `material_ui` non-wasm web test suite#12763
auto-submit[bot] merged 6 commits into
flutter:mainfrom
elliette:reduce-web-tests

elliette commented Sep 4, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Uh oh!

stuartmorgan-g Sep 8, 2026

Uh oh!

elliette Sep 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

QuncCccccc left a comment

Uh oh!

Uh oh!

Uh oh!

QuncCccccc left a comment

Uh oh!

elliette commented Sep 9, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

elliette commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

elliette Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

elliette commented Sep 9, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

elliette commented Sep 4, 2026 •

edited

Loading

elliette Sep 9, 2026 •

edited

Loading