[material_ui] Fix self-comparison and assert bugs in semantics_tester by Sanaullah49 · Pull Request #12722 · flutter/packages

Sanaullah49 · 2026-09-02T09:02:16Z

packages/material_ui/test/semantics_tester.dart carries four bugs that make parts of the helper silently ineffective:

controlsNodes != controlsNodes compares the field to itself, so the setEquals check is unreachable and the controlsNodes expectation never runs
the locale comparison reads second[i] on both sides instead of first[i], so mismatched locales compare equal
the minValue/maxValue checks sit in assert()'s message slot rather than its condition, so they gate nothing
attributedLabel, attributedValue, attributedHint and hint were missing from that assert's condition, so passing any one of them alone tripped it

Adds packages/material_ui/test/semantics_tester_test.dart covering each fix. There was no test file for this helper previously.

Context

Ported from flutter/flutter#192164, which cannot land there because packages/flutter/test/material is frozen (flutter/flutter#188444). The same four fixes landed for the widgets copy of this helper in flutter/flutter#191938.

Testing

flutter test test/semantics_tester_test.dart in packages/material_ui passes 4/4, and dart analyze is clean, against Flutter 3.47.2.

Changelog uses ## NEXT since this is test-only and does not affect the published package.

The test helper carried four bugs that made parts of it silently ineffective: - `controlsNodes != controlsNodes` compares the field to itself, so the setEquals check is unreachable and the expectation never runs - the locale comparison reads `second[i]` on both sides instead of `first[i]`, so mismatched locales compare equal - the `minValue`/`maxValue` checks sit in assert()'s message slot rather than its condition, so they gate nothing - `attributedLabel`, `attributedValue`, `attributedHint` and `hint` were missing from that assert's condition, so passing any one alone tripped it Adds a test file covering each fix. Ported from flutter/flutter#192164, which cannot land there because packages/flutter/test/material is frozen. The same fixes landed for the widgets copy in flutter/flutter#191938.

gemini-code-assist

Code Review

This pull request addresses several bugs in the semantics_tester test helper, correcting self-comparison logic for controlsNodes and LocaleStringAttribute.locale, and expanding the assertion in _IncludesNodeWith to check for newly supported fields. Feedback suggests also including textDirection in the _IncludesNodeWith assertion to prevent incorrect failures when it is the only parameter specified.

nodesWith filters on textDirection like any other field, so includesNodeWith(textDirection: ...) on its own is a valid single-property matcher, but the assert rejected it. Adds it to the condition and the message, with a regression test.

QuncCccccc · 2026-09-08T21:38:18Z

Hello, thanks a lot for your contribution! Could you help fixing the conflict. To update changelog entry, please check here flutter/flutter#188444:)!

Resolve CHANGELOG.md conflict by dropping the direct ## NEXT edit and adding a pending_changelogs entry instead.

Sanaullah49 · 2026-09-09T04:20:32Z

Thanks — resolved the conflict against main and moved the changelog entry to packages/material_ui/pending_changelogs/ (version: skip since this is a test-helper-only change).

QuncCccccc · 2026-09-10T22:12:47Z

Ah since this fix is only related to tests, so we don't need to add a changelog entry. Sorry for any confusion I caused!

QuncCccccc

Thanks a lot for your contribution! LGTM once we remove the changelog entry!

QuncCccccc · 2026-09-10T22:14:16Z

Added @chunhtai for a second review since this fix is mostly identical with flutter/flutter#191938:)

chunhtai

also LGTM when the change log entry is removed

Reviewers confirmed no changelog entry is needed since this change only affects the semantics_tester test helper.

Sanaullah49 · 2026-09-11T06:04:52Z

Removed the pending changelog entry.

QuncCccccc

There seems are some formatting issues that failed Dashboard Checks. Could you help fix them:)

Sanaullah49 · 2026-10-06T05:32:39Z

Fixed the formatting issue in semantics_tester_test.dart.

auto-submit · 2026-10-06T21:18:57Z

autosubmit label was removed for flutter/packages/12722, because - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2026-10-14T20:42:16Z

autosubmit label was removed for flutter/packages/12722, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

Roll Packages from a1ed23c to da40eaf (33 revisions) flutter/packages@a1ed23c...da40eaf 2026-10-15 [email protected] [pigeon]add support for sealed classes in native interop (flutter/packages#13175) 2026-10-15 [email protected] [pigeon] Replace full JNI bindings with stubs for API classes that aren't needed (flutter/packages#13173) 2026-10-14 [email protected] [material_ui] Fix self-comparison and assert bugs in semantics_tester (flutter/packages#12722) 2026-10-14 [email protected] [camera_avfoundation] Replace the deprecated 'videoOrientation' with 'videoRotationAngle' on iOS 17+ (flutter/packages#13247) 2026-10-14 [email protected] [material_ui] Fix GridTile crash when the incoming constraints are unbounded (flutter/packages#12586) 2026-10-14 [email protected] [in_app_purchase_storekit] Remove unused and deprecated "SKDownload" hosted content (flutter/packages#13222) 2026-10-14 [email protected] [material_ui] Add supportingTextPadding to InputDecorator (flutter/packages#12769) 2026-10-14 [email protected] [vector_graphics_codec] Add support for encoding and decoding paint blur commands (flutter/packages#13148) 2026-10-14 [email protected] [go_router] Fix redirect zone async error handling (flutter/packages#12836) 2026-10-14 [email protected] Sync release-go_router-18.1.0 to main (flutter/packages#13260) 2026-10-14 [email protected] Sync release-cupertino_ui-1.1.3 to main (flutter/packages#13258) 2026-10-14 [email protected] [material_ui] add enableInlinePrediction parameter to TextFormField (flutter/packages#12793) 2026-10-14 [email protected] Sync release-material_ui-1.7.0 to main (flutter/packages#13259) 2026-10-14 [email protected] [material_ui] Add the Material shapes. (flutter/packages#12771) 2026-10-14 [email protected] [material_ui] Add tertiary tap callbacks to InkResponse and InkWell (flutter/packages#12676) 2026-10-14 [email protected] Roll Flutter from 4249ccb to 426be96 (44 revisions) (flutter/packages#13256) 2026-10-14 [email protected] [material_ui] fixes expanded state in the a11y_assessment home page dropdown (flutter/packages#13219) 2026-10-14 [email protected] [VPAT] Fix semantics in a11y_assessments drawer, radio, and rail demos (flutter/packages#13159) 2026-10-14 [email protected] [google_maps_flutter] Add onPointOfInterestTap (flutter/packages#11872) 2026-10-14 [email protected] [go_router] Fix shell route key collisions and dynamic branch updates (flutter/packages#12549) 2026-10-14 [email protected] Manual roll Flutter from d03768e to 4249ccb (158 revisions) (flutter/packages#13220) 2026-10-14 [email protected] [image_picker_ios] Require Flutter 3.47 / iOS 15 and drop deprecated kUTType code paths (flutter/packages#13224) 2026-10-13 [email protected] [in_app_purchase_storekit] Fixes Storekit 2 flaky tests (flutter/packages#13213) 2026-10-13 [email protected] [local_auth] Convert Android to new Pigeon suspend support (flutter/packages#12894) 2026-10-13 [email protected] [material_ui] Add enabled parameter to DropdownButtonFormField (flutter/packages#12610) 2026-10-13 [email protected] [go_router] Link ShellRoute docs to StatefulShellRoute (flutter/packages#13120) 2026-10-13 [email protected] FadeForwards page transition performance (flutter/packages#13161) 2026-10-13 [email protected] [in_app_purchase_android] Guard async billing callbacks against duplicate listener responses (flutter/packages#12640) 2026-10-13 [email protected] [google_sign_in] Remove the Objective-C exception catcher (flutter/packages#13156) 2026-10-13 [email protected] [camera_avfoundation] Remove availability checks below the package minimum iOS 13 (flutter/packages#13214) 2026-10-13 [email protected] [google_maps_flutter_ios] Remove iOS 14 availability check from example UI tests (flutter/packages#13218) 2026-10-13 [email protected] [google_sign_in] Convert implementation to Kotlin (flutter/packages#13005) 2026-10-13 [email protected] [image_picker_ios] PR 2/5 Add a PHImageManager image-data seam and migrate plugin native tests to Swift Testing (flutter/packages#13079) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...

github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Sep 2, 2026

Sanaullah49 mentioned this pull request Sep 2, 2026

Apply TestSemantics fixes to the material copy of semantics_tester flutter/flutter#192164

Closed

gemini-code-assist Bot reviewed Sep 2, 2026

View reviewed changes

Comment thread packages/material_ui/test/semantics_tester.dart Resolved

Merge upstream/main; use pending changelog for semantics_tester fix

36773b8

Resolve CHANGELOG.md conflict by dropping the direct ## NEXT edit and adding a pending_changelogs entry instead.

QuncCccccc approved these changes Sep 10, 2026

View reviewed changes

QuncCccccc requested a review from chunhtai September 10, 2026 22:13

QuncCccccc added the CICD Run CI/CD label Sep 10, 2026

chunhtai approved these changes Sep 10, 2026

View reviewed changes

[material_ui] Remove pending changelog for test-only fix

9746125

Reviewers confirmed no changelog entry is needed since this change only affects the semantics_tester test helper.

flutter-dashboard Bot removed the CICD Run CI/CD label Sep 11, 2026

QuncCccccc added the CICD Run CI/CD label Sep 11, 2026

QuncCccccc reviewed Oct 2, 2026

View reviewed changes

[material_ui] Format semantics_tester_test.dart

7470ee4

flutter-dashboard Bot removed the CICD Run CI/CD label Oct 6, 2026

QuncCccccc added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Oct 6, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 6, 2026

Merge branch 'main' into material-ui-semantics-tester-fixes

76e068e

flutter-dashboard Bot removed the CICD Run CI/CD label Oct 14, 2026

QuncCccccc added the CICD Run CI/CD label Oct 14, 2026

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 14, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 14, 2026

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 14, 2026

auto-submit Bot merged commit 36d0427 into flutter:main Oct 14, 2026
13 checks passed

engine-flutter-autoroll mentioned this pull request Oct 15, 2026

Roll Packages from a1ed23c8f760 to da40eaf4548a (33 revisions) flutter/flutter#194459

Merged

Conversation

Sanaullah49 commented Sep 2, 2026

Context

Testing

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

QuncCccccc commented Sep 8, 2026

Uh oh!

Sanaullah49 commented Sep 9, 2026

Uh oh!

QuncCccccc commented Sep 10, 2026

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc commented Sep 10, 2026

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Sanaullah49 commented Sep 11, 2026

Uh oh!

QuncCccccc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sanaullah49 commented Oct 6, 2026

Uh oh!

auto-submit Bot commented Oct 6, 2026

Uh oh!

auto-submit Bot commented Oct 14, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

QuncCccccc left a comment •

edited

Loading