Repository navigation
Conversation
`ContentResolver#openInputStream()` returns null when the provider cannot serve the file (for example after the provider crashed). `FileSelectorApiImpl#toFileResponse` handed that null to `DataInputStream#readFully` on the activity-result callback, so the NullPointerException surfaced on the main thread and killed the app. Complete the callback with the existing "Failed to read file" error instead, and make `FileUtils.getPathFromCopyOfFileFromUri` report the same condition as the IOException its contract already declares.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
Closing: I can't complete the CLA at this time. The analysis stays in the linked issue for anyone who wants to pick this up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContentResolver#openInputStream()returns null when the provider cannot serve the selected file (for example after the provider process crashed).FileSelectorApiImpl#toFileResponseopens the stream in a try-with-resources (where a null resource is legal) and hands it toDataInputStream#readFully, which dereferences it; becausetoFileResponseruns inside theonActivityResultlistener, theNullPointerExceptionsurfaces on the main thread and kills the app.FileUtils.getPathFromCopyOfFileFromUrihas the same unguardedcopy(inputStream, …)one step later. This is thefile_selector_androidsibling of theimage_picker_androidnull-stream crash (flutter/flutter#191988); #159568 covered a copy failure in the same callback, but not a null stream.toFileResponsenow returnsnullfor a null stream, so the caller completes the callback with the existing"Failed to read file"error instead of crashing, andgetPathFromCopyOfFileFromUrireports the condition as theIOExceptionits contract already declares. Two unit tests in the shape of the existing #159568 regression tests, one of them also asserting the read is never attempted.Fixes flutter/flutter#191989
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2