Skip to content

[material_ui] Port routes_transition_test to material_ui - #12634

Merged
auto-submit[bot] merged 5 commits into
flutter:mainfrom
Wreos:fix/routes-transition-test-material-ui
Sep 1, 2026
Merged

auto-submit[bot] merged 5 commits into
flutter:mainfrom
Wreos:fix/routes-transition-test-material-ui

Conversation

@Wreos

@Wreos Wreos commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Ports routes_transition_test.dart from flutter/flutter to material_ui.
The original test is removed separately in flutter/flutter#186620 and added here to preserve its Material navigation transition coverage.

Part of flutter/flutter#177414.
Related to flutter/flutter#188444.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Aug 26, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request ports the Material route transition test suite from flutter/flutter by adding a new test file routes_transition_test.dart and a pending changelog entry. Feedback on the changes indicates that the TransitionDurationObserver class used in the test is missing from the file and needs to be defined locally to ensure the test compiles and runs successfully.

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for helping to port over the PR change in flutter/flutter.

Since this PR is only adding tests, we might not need a changelog entry:)

@QuncCccccc
QuncCccccc requested a review from elliette August 26, 2026 23:48
@Wreos

Wreos commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

LGTM. Thanks for helping to port over the PR change in flutter/flutter.

Since this PR is only adding tests, we might not need a changelog entry:)

good point, thanks :) removed for now

@QuncCccccc QuncCccccc added the CICD Run CI/CD label Aug 27, 2026

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Aug 28, 2026
@elliette elliette added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Sep 1, 2026
@auto-submit
auto-submit Bot merged commit 3f00bb1 into flutter:main Sep 1, 2026
14 checks passed
pull Bot pushed a commit to Mu-L/flutter that referenced this pull request Sep 2, 2026
flutter/packages@7a7912f...18fe786

2026-09-02 [email protected]
[path_parsing] Fix deprecation lints (flutter/packages#12704)
2026-09-02 [email protected] [material_ui] Use super parameters in
more places (flutter/packages#12460)
2026-09-02 [email protected] [material_ui] Add
a README and placeholders for migrating gen_defaults templates
(flutter/packages#12714)
2026-09-01 [email protected] [image_picker] Add native tests
for image, metadata, photo-asset, and PHPicker save utilities
(flutter/packages#12536)
2026-09-01 [email protected] [material_ui] Port routes_transition_test
to material_ui (flutter/packages#12634)
2026-09-01 [email protected] Roll Flutter from
c8c5e3b to 0cbd1a4 (23 revisions) (flutter/packages#12712)
2026-09-01 [email protected]
[material_ui] Remove !chrome in text_field_test.dart
(flutter/packages#12548)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
Ports routes_transition_test.dart from flutter/flutter to material_ui. 
The original test is removed separately in flutter/flutter#186620 and added here to preserve its Material navigation transition coverage.

Part of [flutter/flutter#177414.](flutter/flutter#188444)
Related to [flutter/flutter#188444.](flutter/flutter#186620)

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
Ports routes_transition_test.dart from flutter/flutter to material_ui. 
The original test is removed separately in flutter/flutter#186620 and added here to preserve its Material navigation transition coverage.

Part of [flutter/flutter#177414.](flutter/flutter#188444)
Related to [flutter/flutter#188444.](flutter/flutter#186620)

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
@Wreos
Wreos deleted the fix/routes-transition-test-material-ui branch October 11, 2026 09:47
Wreos added a commit to Wreos/flutter that referenced this pull request Nov 6, 2026
The test now lives in material_ui (flutter/packages#12634). Remove its obsolete cross-import exception as well.

Part of flutter#177414
QuncCccccc pushed a commit to Wreos/flutter that referenced this pull request Nov 12, 2026
The test now lives in material_ui (flutter/packages#12634). Remove its obsolete cross-import exception as well.

Part of flutter#177414
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Nov 13, 2026
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

Removes `routes_transition_test.dart` from `flutter/flutter`. The test
will be added to `material_ui` in `flutter/packages` in [this
pr](flutter/packages#12634)

Part of flutter#177414.
Related to flutter#188444.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants