Repository navigation
Conversation
|
@QuncCccccc would appreciate your review on this. Open questions before further work:
|
github-actions
Bot
added
p: material_ui
triage-design
QuncCccccc
left a comment
QuncCccccc
left a comment
There was a problem hiding this comment.
Thanks a lot for the help! I'll take another round of review tomorrow:)!
| ) | ||
| Color? dividerColor, | ||
| @Deprecated( | ||
| 'Use InputDecorationTheme.hintStyle.color or InputDecoration.hintStyle.color instead. ' |
There was a problem hiding this comment.
Or ColorScheme.onSurfaceVariant?
There was a problem hiding this comment.
Given how hintColor is used internally, this feels to me more like a theme property introduction and replacement, than a ColorScheme usage. Do you agree or what's the reasoning?
| ) | ||
| Color? primaryColor, | ||
| @Deprecated( | ||
| 'Consider using a ThemeExtension instead. This feature was deprecated after material_ui v1.1.0.', |
There was a problem hiding this comment.
Maybe we can also add "or use dark ColorScheme.primary"
There was a problem hiding this comment.
Since primaryColorDark and primaryColorLight were meant to be tonally darker and lighter versions of the primary color, I don't think there's a replacement in m3 world. Even a dark ColorScheme .primary wouldn't be equivalent. So I don't think there's a better suggestion
Deprecates another slate of
ThemeDataproperties we've been wanting to clean up for a while. Some are M1, others are no longer in spec, or others have more appropriate theme-based equivalent.Part of flutter/flutter#91772
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2