Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the bottom sheet dismissal logic in material_ui to trigger when the extent is within a floating-point precision tolerance of its minimum extent, accompanied by corresponding tests and a version bump to 0.0.4. The review feedback suggests that using the absolute difference may fail to trigger dismissal if a rapid drag or dropped frame causes the extent to jump past the minimum. It is recommended to check if the extent is less than or equal to the minimum extent plus the tolerance instead.
…uldCloseOnMinExtent
|
Hi @kirya355 thanks for contributing! This package is not accepting contributions yet, so I am going to close this PR. If you would like to open a PR against the material library in flutter/flutter, we will be letting folks know when we are ready for contributions there. Thanks! |
Fixes bottom sheet dismissal when a
DraggableScrollableNotificationextentis within floating-point precision of
minExtent, instead of requiring exactequality.
Updates both the modal
BottomSheetand standardScaffoldbottom sheethandlers. Adds regression tests for both paths using
extent: 0.20000000001and
minExtent: 0.2.Also bumps
material_uito0.0.4and updates its CHANGELOG.Pre-Review Checklist
[shared_preferences]///).