Skip to content

Add Material style variant enum - #12221

Merged
QuncCccccc merged 1 commit into
flutter:m3e_migrationfrom
QuncCccccc:style_variant_m3e
Jul 21, 2026
Merged

Add Material style variant enum#12221
QuncCccccc merged 1 commit into
flutter:m3e_migrationfrom
QuncCccccc:style_variant_m3e

Conversation

@QuncCccccc

@QuncCccccc QuncCccccc commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Related to Bring Material 3 Expressive to Flutter

This PR is just to add the StyleVariant enum so we can start migrating individual components.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 16, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Jul 16, 2026
@QuncCccccc

QuncCccccc commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Seems no need to add tests. I'll request test exemption when we merge changes to main (after v1.0.0).

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 16, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the StyleVariant enum to theme_data.dart, defining the material3 and material3Expressive style variants. The review feedback suggests renaming StyleVariant to MaterialStyleVariant to prevent namespace pollution and maintain consistency with other Material-specific enums, alongside a minor capitalization correction in the documentation.

Comment thread packages/material_ui/lib/src/theme_data.dart Resolved
dkwingsmt
dkwingsmt approved these changes Jul 16, 2026
View reviewed changes

@dkwingsmt dkwingsmt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkwingsmt

dkwingsmt commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Should we hold this PR to after the v1.0.0 release? I thought the v1.0.0 release was meant to be as close to flutter/material as possible.

@QuncCccccc

QuncCccccc commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Should we hold this PR to after the v1.0.0 release?

Yes, this PR will only be merged in m3e_migration feature branch. Once we have v1.0.0 release, we will move the commits in this feature branch to main:). So we will not have any expressive-related change before v1.0.0 in material_ui.

@dkwingsmt

dkwingsmt commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

That's awesome! Didn't notice it's targeting a new branch.

@QuncCccccc
QuncCccccc merged commit c097041 into flutter:m3e_migration Jul 21, 2026
3 of 5 checks passed
@elliette elliette mentioned this pull request Aug 13, 2026
Closed
@elliette elliette mentioned this pull request Sep 1, 2026
Merged
10 of 11 tasks
auto-submit Bot pushed a commit that referenced this pull request Sep 2, 2026
@elliette
Add Material style variant enum (#12221) (#12717)
203ddb4 
Work towards flutter/flutter#191088

**Ports over #12221 which landed on the `m3e_migration` feature branch.**

### Original PR description

Related to https://github.com/orgs/flutter/projects/250

This PR is just to add the StyleVariant enum so we can start migrating individual components.

## Pre-Review Checklist

**Text exemption:** Adds an enum, no change behavior.

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
@elliette @victorsanni
Add Material style variant enum (flutter#12221) (flutter#12717)
2021d0f 
Work towards flutter/flutter#191088

**Ports over flutter#12221 which landed on the `m3e_migration` feature branch.**

### Original PR description

Related to https://github.com/orgs/flutter/projects/250

This PR is just to add the StyleVariant enum so we can start migrating individual components.

## Pre-Review Checklist

**Text exemption:** Adds an enum, no change behavior.

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
@elliette @victorsanni
Add Material style variant enum (flutter#12221) (flutter#12717)
5c2a105 
Work towards flutter/flutter#191088

**Ports over flutter#12221 which landed on the `m3e_migration` feature branch.**

### Original PR description

Related to https://github.com/orgs/flutter/projects/250

This PR is just to add the StyleVariant enum so we can start migrating individual components.

## Pre-Review Checklist

**Text exemption:** Adds an enum, no change behavior.

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes
@elliette elliette elliette approved these changes
@justinmc justinmc Awaiting requested review from justinmc
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@QuncCccccc @dkwingsmt @elliette