[google_maps_flutter] Fix XCUITest on stable#12214
Conversation
flutter#12208 re-enabled these tests using new semantics types, but it turns out that the semantics type had not only changed several years ago when the test was first disabled, but again since the last stable, so the PR failed in post-submit where we run platform tests against stable as well as master. This adjusts the test to look for the problematic element in either element set for now, so that the test works on both stable and master. Validated locally with stable, since presubmit won't test it.
|
Since it's easy to fix this forward, and the fix can't be tested in presubmit anyway, I'm just fixing instead of reverting. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates iOS UI tests across multiple packages to handle a semantics type change for the 'Map coordinates' element between Flutter 3.44 and 3.47 by introducing a busy-wait loop that checks for both staticTexts and otherElements. Feedback suggests replacing this custom loop with app.descendants(matching: .any)["Map coordinates"] to simplify the implementation, avoid unnecessary delays, and ensure correct timeout behavior.
| } | ||
|
|
||
| let titleBar = app.staticTexts["Map coordinates"] | ||
| // The semantics type of this element changed between Flutter 3.44 and 3.47. |
There was a problem hiding this comment.
If it is then would that change be considered a breaking change if the tests weren't disabled, or these tests only run against flutter stable?
There was a problem hiding this comment.
Is it flutter/flutter#186916 ?
I'm not sure how the a11y folks think about changes like this relative to the Flutter SDK's definition of "breaking". This test wasn't specifically trying to assert the specific semantics, it was just a side effect of the implementation.
stuartmorgan-g
added
emergency
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
…er#189659) flutter/packages@9f95026...4fdc766 2026-07-17 [email protected] [pigeon] allow empty class (flutter/packages#12181) 2026-07-16 [email protected] [material_ui, cupertino_ui] Rename l10n macros (flutter/packages#12211) 2026-07-16 [email protected] [ci] Remove manual SwiftPM enabling step (flutter/packages#12204) 2026-07-16 [email protected] [google_maps_flutter] Fix XCUITest on stable (flutter/packages#12214) 2026-07-16 [email protected] [google_maps_flutter] Convert XCUITests to Swift (flutter/packages#12208) 2026-07-16 [email protected] [material_ui] Rename the remaining templates (flutter/packages#12210) 2026-07-15 [email protected] [material_ui, cupertino_ui] Rename macro names to package names (flutter/packages#12198) 2026-07-15 [email protected] [material_ui] Fix upstream localization test (flutter/packages#12207) 2026-07-15 [email protected] [material_ui, cupertino_ui] Localizations (flutter/packages#12119) 2026-07-15 [email protected] fix(ci): harden some workflows in packages (flutter/packages#12178) 2026-07-15 [email protected] Roll Flutter from 846664b to fc1ad95 (18 revisions) (flutter/packages#12203) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
#12208 re-enabled these tests using new semantics types, but it turns out that the semantics type had not only changed several years ago when the test was first disabled, but again since the last stable, so the PR failed in post-submit where we run platform tests against stable as well as master.
This adjusts the test to look for the problematic element as any type, so that the test works on both stable and master. Validated locally with stable, since presubmit won't test it.
Part of flutter/flutter#154641
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2