Repository navigation
[google_maps_flutter_web] Issue 64073 implement my location - #12186
Merged
auto-submit[bot] merged 30 commits intoOct 21, 2026
Merged
Conversation
Zubii12
force-pushed
the
issue-64073-implement-my-location
branch
2 times, most recently
from
July 14, 2026 21:10
01d001a to
771d770
Compare
Zubii12
marked this pull request as ready for review
July 24, 2026 14:57
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for the 'My Location' button and current location tracking in the Google Maps Web plugin by introducing MyLocationController, MyLocationButton, and a mockable GeolocationApi. The review feedback highlights several critical issues, including potential resource and memory leaks from uncleared geolocation watches and map event listeners, runtime crashes in non-secure contexts due to unchecked geolocation support, and unsafe force-unwrapping of _markersController. Additionally, the feedback suggests using relative asset paths instead of web.window.location.href, triggering the location button's loading animation, preventing duplicate CSS injections, adding accessibility attributes, and improving double literal readability.
Zubii12
marked this pull request as draft
July 24, 2026 15:02
Zubii12
force-pushed
the
issue-64073-implement-my-location
branch
from
July 24, 2026 20:25
771d770 to
17725bd
Compare
Zubii12
marked this pull request as ready for review
July 28, 2026 10:09
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for the 'My Location' button and current location tracking (blue dot) on the web platform for google_maps_flutter. The feedback highlights several critical runtime issues and improvements: instantiating HTML elements directly via constructors throws a TypeError on the web and should be replaced with web.document.createElement; navigator.geolocation requires null-safety checks for insecure contexts; the location button animation should handle null locations gracefully; removing the button control should target its specific index rather than using pop(); and the bang operator on _markersController should be avoided to prevent potential null pointer exceptions.
Contributor
|
@mdebbar can you take a look at this PR? |
mdebbar
requested changes
Sep 2, 2026
Zubii12
force-pushed
the
issue-64073-implement-my-location
branch
from
September 29, 2026 11:28
49913ef to
d1563cc
Compare
Contributor
Author
|
@mdebbar just made the changes you requested |
mdebbar
requested changes
Oct 2, 2026
Zubii12
force-pushed
the
issue-64073-implement-my-location
branch
from
October 3, 2026 11:42
a9ce05e to
26803ef
Compare
mdebbar
requested changes
Oct 5, 2026
Zubii12
force-pushed
the
issue-64073-implement-my-location
branch
from
October 6, 2026 17:55
91d7956 to
3a35a39
Compare
Contributor
Author
mdebbar
approved these changes
Oct 7, 2026
mdebbar
left a comment
mdebbar
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the contribution!
…very config update
Zubii12
force-pushed
the
issue-64073-implement-my-location
branch
from
October 21, 2026 17:14
3a35a39 to
0fd5804
Compare
Contributor
Author
|
@mdebbar just fixed the conflicts |
mdebbar
added
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/packages/12186, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
mdebbar
approved these changes
Oct 21, 2026
mdebbar
added
CICD
GhagSagar23
pushed a commit
to Kryonex-Labs/flutter
that referenced
this pull request
Oct 22, 2026
flutter/packages@1383427...93baed9 2026-10-22 [email protected] [material_ui] Port flutter/flutter flutter#186777 MaterialColor test (flutter/packages#12858) 2026-10-21 [email protected] [rfw] Migrate to material_ui (flutter/packages#12811) 2026-10-21 [email protected] [cupertino_ui] Fix the installing command of the cupertino_ui package (flutter/packages#13141) 2026-10-21 [email protected] [cupertino_ui] Unskip web tests that pass on CanvasKit and Skwasm: date_picker_test, spell_check_suggestions_toolbar_test (flutter/packages#13367) 2026-10-21 [email protected] [video_player] Convert player classes to Swift (flutter/packages#13197) 2026-10-21 [email protected] [camera_windows] Fall back to a physical stream for cameras that reject preferred-stream selectors (flutter/packages#12748) 2026-10-21 [email protected] [google_sign_in_ios, video_player] Specify types for pattern variable declarations (flutter/packages#13362) 2026-10-21 [email protected] [google_maps_flutter_web] Issue 64073 implement my location (flutter/packages#12186) 2026-10-21 [email protected] [material_ui] Unskip web tests that pass on CanvasKit and Skwasm: app_bar_theme_test, input_decorator_test, paginated_data_table_test, spell_check_suggestions_toolbar_test (flutter/packages#13352) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
flutter/packages@1383427...93baed9 2026-10-22 [email protected] [material_ui] Port flutter/flutter flutter#186777 MaterialColor test (flutter/packages#12858) 2026-10-21 [email protected] [rfw] Migrate to material_ui (flutter/packages#12811) 2026-10-21 [email protected] [cupertino_ui] Fix the installing command of the cupertino_ui package (flutter/packages#13141) 2026-10-21 [email protected] [cupertino_ui] Unskip web tests that pass on CanvasKit and Skwasm: date_picker_test, spell_check_suggestions_toolbar_test (flutter/packages#13367) 2026-10-21 [email protected] [video_player] Convert player classes to Swift (flutter/packages#13197) 2026-10-21 [email protected] [camera_windows] Fall back to a physical stream for cameras that reject preferred-stream selectors (flutter/packages#12748) 2026-10-21 [email protected] [google_sign_in_ios, video_player] Specify types for pattern variable declarations (flutter/packages#13362) 2026-10-21 [email protected] [google_maps_flutter_web] Issue 64073 implement my location (flutter/packages#12186) 2026-10-21 [email protected] [material_ui] Unskip web tests that pass on CanvasKit and Skwasm: app_bar_theme_test, input_decorator_test, paginated_data_table_test, spell_check_suggestions_toolbar_test (flutter/packages#13352) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement my location button, add blue dot location
Fixes flutter/flutter#64073
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2