[cupertino_ui] Migrate a snippet in `CupertinoCheckbox`'s API doc to `{@example}` and add unit tests by dkwingsmt · Pull Request #12180 · flutter/packages

dkwingsmt · 2026-07-10T22:43:45Z

This PR demonstrates how to migrate an inline API documentation snippet into a separate file and verify it with unit tests.

Steps

Create a new example file.
- The file name should contain snippet.
- The example file doesn't need a main function.
- The widget body should contain the snippet, which is isolated by #region and #endregion directives.
- If necessary, the file can have multiple regions. The region name doesn't have to be body.
Add a corresponding test file to ensure the snippet functions correctly.
Update the original documentation to use the new @example directive.
Remove the TODO.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

…ckbox

gemini-code-assist

Code Review

This pull request extracts an inline code snippet for CupertinoCheckbox into a standalone example file and adds a corresponding widget test. The documentation in checkbox.dart is updated to reference this external snippet. A compilation error was identified in the test file where .light is used instead of Brightness.light.

…ckbox

gemini-code-assist

Code Review

This pull request introduces a new code snippet example for the CupertinoCheckbox widget and adds corresponding unit tests. The review identified syntax issues regarding Dart double literals, which require a leading digit (e.g., 0.32 instead of .32), and an incorrect usage of the brightness property in the test file, which should explicitly reference the Brightness enum.

gemini-code-assist · 2026-09-17T00:18:47Z

+        Set<WidgetState> states,
+      ) {
+        if (states.contains(WidgetState.disabled)) {
+          return Colors.orange.withValues(alpha: .32);


In Dart, double literals cannot start with a leading decimal point (e.g., .32). They must have a leading digit, such as 0.32.

Suggested change

return Colors.orange.withValues(alpha: .32);

return Colors.orange.withValues(alpha: 0.32);

gemini-code-assist · 2026-09-17T00:18:48Z

+
+    Widget buildApp({required ValueChanged<bool?>? onChanged}) {
+      return CupertinoApp(
+        theme: CupertinoThemeData(brightness: .light),


Dart does not support leading dot syntax for enum values (like Swift's .light). You must explicitly reference the enum type Brightness.light.

Suggested change

theme: CupertinoThemeData(brightness: .light),

theme: CupertinoThemeData(brightness: Brightness.light),

gemini-code-assist · 2026-09-17T00:18:48Z

+    await tester.pumpAndSettle();
+    expect(
+      getCheckboxRenderer(),
+      paints..rrect(color: Colors.orange.withValues(alpha: .32)),


In Dart, double literals cannot start with a leading decimal point (e.g., .32). They must have a leading digit, such as 0.32.

Suggested change

paints..rrect(color: Colors.orange.withValues(alpha: .32)),

paints..rrect(color: Colors.orange.withValues(alpha: 0.32)),

dkwingsmt · 2026-09-17T00:19:50Z

@Piinks This PR is ready for review. I intend it as a basis for discussing the format for similar changes, and after this PR lands I plan to use the agent to migrate the remaining cases, a few at a time for review. LMK if you'd like more people to join reviewing.

Piinks · 2026-09-17T18:04:45Z

It looks like this is failing a number of tests

Piinks

LGTM with CI satisfied. :)

…ckbox

…nto demo-snippet-test-checkbox

@example

Roll Packages from c2b58e1 to 431ea69 (56 revisions) flutter/packages@c2b58e1...431ea69 2026-09-24 [email protected] [cross_file] Updates cross_file to a package separated federated plugin (flutter/packages#11010) 2026-09-23 [email protected] [material_ui] Remove static access of `copyWith` from `dart fix` golden tests for `ThemeData/TextTheme` (flutter/packages#12994) 2026-09-23 [email protected] [camera_avfoundation] Replace deprecated high-resolution capture APIs (flutter/packages#12372) 2026-09-23 [email protected] [pigeon] update nullish checks to use new isNullish method (flutter/packages#12985) 2026-09-23 [email protected] [ci] Assign batch release PR approver as reviewer on sync-back PR (flutter/packages#12976) 2026-09-23 [email protected] [image_picker] Fix scaling 10-bit images (flutter/packages#12557) 2026-09-23 [email protected] [material_ui] Improve Autocomplete, DrawerHeader, and Tooltip accessibility (flutter/packages#12918) 2026-09-23 [email protected] [google_fonts] Decouple GoogleFontsLite for full tree-shaking and add full feature parity (flutter/packages#12830) 2026-09-23 [email protected] [file_selector] Ignore flakey `file_selector_android` tests (flutter/packages#12992) 2026-09-23 [email protected] [CI] Remove bringup from `Mac_arm64 build_all_packages` targets (flutter/packages#12978) 2026-09-22 [email protected] [material_ui] Unskip 5 passing web tests in bottom_app_bar_test and text_field_test (flutter/packages#12983) 2026-09-22 [email protected] [cupertino_ui] Unskip 5 passing web tests in adaptive_text_selection_toolbar_test and text_field_test (flutter/packages#12984) 2026-09-22 [email protected] [go_router] Fix ShellRoute chrome dropped from semantics tree by ModalBarrier (flutter/packages#12353) 2026-09-22 [email protected] [material_ui] Add contrastLevel for M3 ColorScheme (flutter/packages#12743) 2026-09-22 [email protected] [go_router] Preserve nested pushes during config updates (flutter/packages#12611) 2026-09-22 [email protected] [material_ui] Migrate M3 Chip template to use new gen_defaults (flutter/packages#12847) 2026-09-22 [email protected] [material_ui] Fix LocalHistoryEntry leak when double tapping Drawer scrim (flutter/packages#12552) 2026-09-22 [email protected] Update suggested reviewers (flutter/packages#12974) 2026-09-22 [email protected] Sync release-material_ui-1.4.0 to main (flutter/packages#12966) 2026-09-22 [email protected] Sync release-cupertino_ui-1.1.1 to main (flutter/packages#12965) 2026-09-21 [email protected] [ci] Update repo for 3.47 stable release (flutter/packages#12959) 2026-09-21 [email protected] Manual roll Flutter from 27fec0e to 4fcd90b (1 revision) (flutter/packages#12904) 2026-09-21 [email protected] Revert "[go_router_builder] Migrate to material_ui" (flutter/packages#12962) 2026-09-21 [email protected] [material_ui] Update `material_ui` tests to prevent them from failing when framework `TextStyle` changes (flutter/packages#12728) 2026-09-21 [email protected] [go_router_builder] Migrate to material_ui (flutter/packages#12913) 2026-09-21 [email protected] [material_ui, cupertino_ui] Bump Flutter version from to 3.47 (flutter/packages#12944) 2026-09-21 [email protected] [cupertino_ui] Work around dart2wasm optional parameter inference bug in example checkbox tests (flutter/packages#12961) 2026-09-21 [email protected] [cupertino_ui] Work around dart2wasm optional parameter inference bug in checkbox_test.dart (flutter/packages#12956) 2026-09-21 [email protected] [google_sign_in] PR 3/4 Migrate ViewProvider and GID SDK wrappers from Objective-C to Swift (flutter/packages#12657) 2026-09-21 [email protected] [google_sign_in] PR 2/4 Migrate the plugin class from Objective-C to Swift. (flutter/packages#12655) 2026-09-20 [email protected] [cross_file_darwin] iOS/macOS implementation of `cross_file` (flutter/packages#12910) 2026-09-20 [email protected] [cross_file_web] Web implementation of `cross_file` (flutter/packages#12908) 2026-09-20 [email protected] [material_ui] Migrate M3 `InputChip` template to use new gen_defaults (flutter/packages#12850) 2026-09-20 [email protected] [material_ui] Migrate M3 Checkbox defaults to new gen_defaults (flutter/packages#12816) 2026-09-20 [email protected] [material_ui] Migrate M3 `FilterChip` template to use new gen_defaults (flutter/packages#12849) 2026-09-19 [email protected] [material_ui] Announce PopupMenuButton with a child as a button (flutter/packages#12585) 2026-09-19 [email protected] Roll Flutter (stable) from 9584c67 to 6a19cca (7 revisions) (flutter/packages#12950) 2026-09-18 [email protected] [material_ui] Reduce the `material_ui` non-wasm web test suite (flutter/packages#12763) 2026-09-18 [email protected] Replace `Mac_x64` builders with `Mac_arm64` ones (flutter/packages#12941) 2026-09-18 [email protected] [in_app_purchase_storekit] Use `_$SKPaymentDiscountWrapperToJson` (flutter/packages#12721) 2026-09-18 [email protected] [In_app _purchase] README excerpt examples and changelog (flutter/packages#12739) 2026-09-18 [email protected] [material_ui] Add alternative input method for `RangeSlider` in `NavigationMode.directional` (flutter/packages#12630) 2026-09-18 [email protected] [cross_file_android] Android implementation of `cross_file` (flutter/packages#12909) 2026-09-18 [email protected] [camera_platform_interface] Adds videoOutputPath support to startVideoRecording (flutter/packages#12667) 2026-09-17 [email protected] [cupertino_ui] Migrate a snippet in `CupertinoCheckbox`'s API doc to `{@example}` and add unit tests (flutter/packages#12180) 2026-09-17 [email protected] [material_ui] Default gen_defaults color helper prefix (flutter/packages#12848) ...

dkwingsmt added 3 commits July 8, 2026 22:36

Impl

d2a8249

More

e94b9f7

Merge remote-tracking branch 'origin/main' into demo-snippet-test-che…

3937f2f

…ckbox

github-actions Bot added triage-framework Should be looked at in framework triage p: cupertino_ui labels Jul 10, 2026

dkwingsmt added 2 commits July 10, 2026 15:44

Add doc

fb90d5c

Merge remote-tracking branch 'origin/main' into demo-snippet-test-che…

cd40ff4

…ckbox

dkwingsmt marked this pull request as ready for review July 13, 2026 05:01

gemini-code-assist Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread packages/cupertino_ui/example/test/checkbox/cupertino_checkbox.snippet.0_test.dart Resolved

dkwingsmt added the CICD Run CI/CD label Jul 13, 2026

Format

008751d

github-actions Bot removed the CICD Run CI/CD label Jul 13, 2026

dkwingsmt added the CICD Run CI/CD label Jul 13, 2026

Merge remote-tracking branch 'origin/main' into demo-snippet-test-che…

44faf87

…ckbox

dkwingsmt marked this pull request as draft August 5, 2026 18:24

Piinks added triage-design Should be looked at in design triage and removed triage-framework Should be looked at in framework triage labels Aug 17, 2026

dkwingsmt marked this pull request as ready for review September 17, 2026 00:16

Merge branch 'main' into demo-snippet-test-checkbox

5f14c82

dkwingsmt requested a review from Piinks September 17, 2026 00:17

gemini-code-assist Bot reviewed Sep 17, 2026

View reviewed changes

Piinks approved these changes Sep 17, 2026

View reviewed changes

dkwingsmt added 3 commits September 17, 2026 13:11

Merge remote-tracking branch 'origin/main' into demo-snippet-test-che…

7b9f70d

…ckbox

Merge remote-tracking branch 'dkwingsmt/demo-snippet-test-checkbox' i…

1d050f6

…nto demo-snippet-test-checkbox

Fix analyzer errors

04d2b4e

dkwingsmt added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Sep 17, 2026

dkwingsmt merged commit eb2ecc2 into flutter:main Sep 17, 2026
13 checks passed

dkwingsmt deleted the demo-snippet-test-checkbox branch September 17, 2026 21:02

engine-flutter-autoroll mentioned this pull request Sep 24, 2026

Roll Packages from c2b58e1a97fb to 431ea69a42e2 (56 revisions) flutter/flutter#193289

Merged

Navigation Menu

Repository navigation

[cupertino_ui] Migrate a snippet in `CupertinoCheckbox`'s API doc to `{@example}` and add unit tests - #12180

[cupertino_ui] Migrate a snippet in `CupertinoCheckbox`'s API doc to `{@example}` and add unit tests#12180
dkwingsmt merged 11 commits into
flutter:mainfrom
dkwingsmt:demo-snippet-test-checkbox

dkwingsmt commented Jul 10, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Sep 17, 2026

Uh oh!

gemini-code-assist Bot Sep 17, 2026

Uh oh!

gemini-code-assist Bot Sep 17, 2026

Uh oh!

dkwingsmt commented Sep 17, 2026 •

edited

Loading

Uh oh!

Piinks commented Sep 17, 2026

Uh oh!

Piinks left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	return Colors.orange.withValues(alpha: .32);
	return Colors.orange.withValues(alpha: 0.32);

	theme: CupertinoThemeData(brightness: .light),
	theme: CupertinoThemeData(brightness: Brightness.light),

	paints..rrect(color: Colors.orange.withValues(alpha: .32)),
	paints..rrect(color: Colors.orange.withValues(alpha: 0.32)),

Conversation

dkwingsmt commented Jul 10, 2026

Steps

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Sep 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Sep 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Sep 17, 2026

Choose a reason for hiding this comment

Uh oh!

dkwingsmt commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Piinks commented Sep 17, 2026

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dkwingsmt commented Sep 17, 2026 •

edited

Loading