Update legacy test to be in Warn Range#12168
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the legacy project CI configuration by upgrading the Gradle version from 8.11.1 to 8.14 and the Android Gradle Plugin (AGP) version from 8.9.1 to 8.11.1. These changes are reflected in the gradle-wrapper properties, settings.gradle, and the README documentation. There are no review comments, and I have no feedback to provide.
jmagman
approved these changes
Jul 9, 2026
This was referenced Jul 10, 2026
loic-sharma
pushed a commit
to ishaquehassan/flutter
that referenced
this pull request
Jul 13, 2026
…er#189387) flutter/packages@20928d5...ad2eab1 2026-07-13 [email protected] [camera] Guard CameraController value updates after dispose (flutter/packages#11861) 2026-07-13 [email protected] [material_ui] Remove unused example files (flutter/packages#12179) 2026-07-13 [email protected] [google_maps_flutter_platform_interface] Adds support for mapTypeControlEnabled, fullscreenControlEnabled, and streetViewControlEnabled for web (flutter/packages#12191) 2026-07-13 [email protected] [pigeon] Report a clear error for enhanced enums (flutter/packages#11880) 2026-07-13 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 6.1.0 to 6.2.0 in the all-github-actions group (flutter/packages#12190) 2026-07-13 [email protected] [shared_preferences] Convert legacy codepath to Kotlin (flutter/packages#12139) 2026-07-12 [email protected] Roll Flutter from f7b66f3 to cf9e8af (11 revisions) (flutter/packages#12188) 2026-07-11 [email protected] [video_player] Improve seek performance on Android (flutter/packages#11810) 2026-07-11 [email protected] [pigeon] Disable iOS test parallelization (flutter/packages#12177) 2026-07-11 [email protected] [material_ui, cupertino_ui] Migrate snippet TODOs to `<callout-box>` (flutter/packages#12146) 2026-07-11 [email protected] [cupertino_ui] Fix example path (flutter/packages#12151) 2026-07-10 [email protected] Roll Flutter from dc2a870 to f7b66f3 (12 revisions) (flutter/packages#12175) 2026-07-10 [email protected] Roll Flutter (stable) from f94f4fc to ee80f08 (3 revisions) (flutter/packages#12171) 2026-07-10 [email protected] Manual roll Flutter from 91939cc to dc2a870 (50 revisions) (flutter/packages#12169) 2026-07-09 [email protected] Update `legacy` test to be in Warn Range (flutter/packages#12168) 2026-07-09 [email protected] [material_ui, cupertino_ui] Migrate dartpad TODOs to `<callout-box>` (flutter/packages#12120) 2026-07-09 [email protected] [video_player_avfoundation] Implement preventsDisplaySleepDuringVideoPlayback (flutter/packages#11547) 2026-07-09 [email protected] [pigeon] Add usage docs to generated Dart event channel methods (flutter/packages#11894) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the error and warn versions in this PR: flutter/flutter#189109, which broke the flutter roll into packages. The legacy version was below the error version, so I upgraded the version to the error version (which is in the warn range).
Some helpful definitions:
[very low version, error version) --> in error range; app fails (legacy test fell in this range)
[error version, warn version) --> in warn range (warning logs)
[warn version, some very modern version) --> safe range (no logs)
Fixes: flutter/flutter#189218
Related to: flutter/flutter#189383
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2